Issues in VKGroups.php (master) - Issues in master - darki73/FreedomCoreVKAPI - Measure and Improve Code Quality continuously with Scrutinizer

Issues (63)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

source/API/VKGroups.php (29 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace FreedomCore\VK\API;

use FreedomCore\VK\VKBase;

class VKGroups extends VKAPI {

    /**
     * API Method for this class
     * @var string
     */
    protected $apiMethod = 'groups.';

    /**
     * Permission Required To Work With This Extension
     * @var int
     */
    protected $requiredPermission = parent::PERMISSION_GROUPS;

    /**
     * Default Fields For Selection
     */
    const defaultFields = [ 'description', 'members_count', 'status', 'contacts' ];

    /**
     * VKGroups constructor.
     * @param VKBase $vkObject
     */
    public function __construct(VKBase $vkObject) {
        parent::__construct($vkObject);
        parent::isAllowed($this->requiredPermission);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns information specifying whether a user is a member of a community
     * @param int | string $groupID
     * @param int $userID
     * @param int $isExtended
     * @return mixed
     */
    public function isMember($groupID, $userID, $isExtended = 0) {
        $requestParameters = [
            'group_id'      =>  $groupID,
            'user_id'       =>  $userID,
            'extended'      =>  ($isExtended > 1 || $isExtended < 0) ? 0 : $isExtended
        ];

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns information about communities by their ID (IDs)
     * @param int | string $groupID
     * @param array $requestFields
     * @return mixed
     */
    public function getById($groupID, $requestFields = self::defaultFields) {
        $requestParameters = [
            'fields'    => $this->getAllowedFields($requestFields)
        ];

        if (is_array($groupID)) {
            $requestParameters[ 'group_ids' ] = implode(',', $groupID);
        } else {
            $requestParameters[ 'group_id' ] = $groupID;
        }

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns a list of the communities to which a user belongs
     * @param int $userID
     * @param int $isExtended
     * @param string $setFilter
     * @param array $requestFields
     * @return mixed
     */
    public function get($userID, $isExtended = 0, $setFilter = null, $requestFields = self::defaultFields) {
        $allowedFilterTypes = [ 'admin', 'editor', 'moder', 'groups', 'publics', 'events' ];
        $requestParameters = [
            'user_id'   =>  $userID,
            'extended'  =>  ($isExtended > 1 || $isExtended < 0) ? 0 : $isExtended,
            'fields'    =>  $this->getAllowedFields($requestFields)
        ];
        if ($setFilter != null && in_array($setFilter, $allowedFilterTypes)) { 

            $requestParameters[ 'filter' ] = $setFilter; 
        }

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns a list of community members
     * @param int | string $groupID
     * @param array $requestFields
     * @return mixed
     */
    public function getMembers($groupID, $requestFields = VKUsers::standardFields) {

        $requestParameters = [
            'group_id'  =>  $groupID,
            'fields'    =>  $requestFields
        ];

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * With this method you can join the group or public page, and also confirm your participation in an event.
     * @param int $groupID
     * @param null $ifMeeting
     * @return mixed
     */
    public function join($groupID, $ifMeeting = null) {
        $requestParameters[ 'group_id' ] = $groupID;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        if ($ifMeeting != null){ 
            if ($ifMeeting == 1 || $ifMeeting == 0) { 
                $requestParameters[ 'not_sure' ]  =   $ifMeeting; 
            } 
        }

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * With this method you can leave a group, public page, or event.
     * @param int $groupID
     * @return mixed
     */
    public function leave($groupID) {
        $requestParameters[ 'group_id' ] = $groupID;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Searches for communities by substring.
     * @param string $searchQuery
     * @param string $groupType
     * @return mixed
     */
    public function search($searchQuery, $groupType = null) {
        $requestParameters[ 'q' ] = $searchQuery;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        if ($groupType != null && in_array($groupType, [ 'group', 'page', 'event' ])) { 

            $requestParameters[ 'type' ] = $groupType; 
        }

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns a list of invitations to join communities and events.
     * @param int $isExtended
     * @return mixed
     */
    public function getInvites($isExtended = 0) {
        $requestParameters[ 'extended' ] = ($isExtended > 1 || $isExtended < 0) ? 0 : $isExtended;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns invited users list of a community
     * @param int $groupID
     * @param array $requestFields
     * @return mixed
     */
    public function getInvitedUsers($groupID, $requestFields = VKUsers::standardFields) {

        $requestParameters = [
            'group_id'  => $groupID,
            'fields ' => $requestFields
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Adds a user to a community blacklist
     * @param int $groupID
     * @param int $userID
     * @param int $banReason -  1 — spam 2 — verbal abuse 3 — strong language 4 — irrelevant messages 0 — other (default)
     * @param string $banComment - Comment of ban action
     * @param int $endDateTimeStamp - Unix Time
     * @param int $commentVisible - Show Comment To User (1 - Yes | 0 - No)
     */
    public function banUser($groupID, $userID, $banReason = 0, $banComment = '', $endDateTimeStamp = null, $commentVisible = 1) {
        $requestParameters = [
            'group_id'          =>  $groupID,
            'user_id'           =>  $userID,
            'reason'            =>  ($banReason < 0 || $banReason > 4) ? 0 : $banReason,
            'comment'           =>  $banComment,
            'end_date'          =>  ($endDateTimeStamp == null) ? strtotime(date("Y-m-d", strtotime("+1 week"))) : $endDateTimeStamp,

            'comment_visible'   =>  $commentVisible
        ];

        parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Deletes a user from a community blacklist
     * @param int $groupID
     * @param int $userID
     * @return mixed
     */
    public function unbanUser($groupID, $userID) {
        $requestParameters = [
            'group_id'  => $groupID,
            'user_id'   => $userID
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Returns a list of users on a community blacklist (Requires Moderator Status)
     * @param int $groupID
     * @return mixed
     */
    public function getBanned($groupID) {
        return parent::executeQuery(__FUNCTION__, [ 'group_id' => $groupID]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Creates a new community
     * @param string $groupTitle
     * @param string $groupDescription
     * @param string $groupType
     * @param int $subType
     * @return mixed
     */
    public function create($groupTitle, $groupDescription, $groupType = 'group', $subType = null) {
        $allowedGroupTypes = [ 'group', 'event', 'public' ];
        $requestParameters = [
            'title'     =>  $groupTitle,
            'type'      =>  (in_array($groupType, $allowedGroupTypes)) ? $groupType : 'group'
        ];
        if ($groupType != 'public') { 
            $requestParameters[ 'description' ] = $groupDescription; 
        }
        if ($subType !== null) { 
            $requestParameters[ 'subtype' ] = ($subType > 4 || $subType < 1) ? 2 : $subType;
        }

        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Edits a community
     * @param int $groupID
     * @param string $groupTitle
     * @param string $groupDescription
     * @param string $groupScreenName
     * @param int $groupAccess
     * @param string $groupWebSite
     * @param int $groupSubject
     * @return array
     */
    public function edit($groupID, $groupTitle, $groupDescription, $groupScreenName, $groupAccess, $groupWebSite, $groupSubject) {
        $requestParameters = [
            'group_id'      =>  $groupID,
            'title'         =>  $groupTitle,
            'description'   =>  $groupDescription,
            'screen_name'   =>  $groupScreenName,
            'access'        =>  ($groupAccess > 2 || $groupAccess < 0) ? 1 : $groupAccess,
            'website'       =>  $groupWebSite,
            'subject'       =>  ($groupSubject < 1 || $groupSubject > 42) ? 26 : $groupSubject,
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Get Group Settings
     * @param int $groupID
     * @return mixed
     */
    public function getSettings($groupID) {
        return parent::executeQuery(__FUNCTION__, [ 'group_id' => $groupID]);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Get Group Access Request
     * @param int $groupID
     * @param array $requestFields
     * @param int $setCount
     * @return array
     */
    public function getRequests($groupID, $requestFields = null, $setCount = 20) {
        if ($requestFields == null) {
            $requestFields = VKUsers::standardFields;
        }

        $requestParameters = [
            'group_id'  =>  $groupID,
            'fields'    =>  $requestFields,
            'count'     =>  $setCount
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Invite User To Group
     * @param int $groupID
     * @param int $userID
     * @return mixed
     */
    public function invite($groupID, $userID) {
        $requestParameters = [
            'group_id'  =>  $groupID,
            'user_id'   =>  $userID
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Remove User From Group
     * @param int $groupID
     * @param int $userID
     * @return mixed
     */
    public function removeUser($groupID, $userID) {
        $requestParameters = [
            'group_id'  =>  $groupID,
            'user_id'   =>  $userID
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * Approve User Request To Join Group
     * @param int $groupID
     * @param int $userID
     * @return mixed
     */
    public function approveRequest($groupID, $userID) {
        $requestParameters = [
            'group_id'  =>  $groupID,
            'user_id'   =>  $userID
        ];
        return parent::executeQuery(__FUNCTION__, $requestParameters);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }


    /**
     * Get Fields That Allowed To Be Used With Groups API
     * @param $fieldsArray
     * @return string
     */
    private function getAllowedFields($fieldsArray) {
        $groupsFields = [
            'group_id',
            'name',
            'screen_name',
            'is_closed',
            'is_admin',
            'admin_level',
            'is_member',
            'type',
            'photo',
            'photo_medium',
            'photo_big',
            'city',
            'country',
            'place',
            'description',
            'wiki_page',
            'members_count',
            'counters',
            'start_date ',
            'end_date',
            'can_post',
            'can_see_all_posts',
            'activity',
            'status',
            'contacts'
        ];

        foreach($fieldsArray as $fKey => $fValue) {
            if (!in_array($fValue, $groupsFields)) {
                unset($fieldsArray[$fKey]);
            }
        }
        return implode(',', $fieldsArray);
    }
}

1			<?php
2
3			namespace FreedomCore\VK\API;
4
5			use FreedomCore\VK\VKBase;
6
7			class VKGroups extends VKAPI {
8
9			/**
10			* API Method for this class
11			* @var string
12			*/
13			protected $apiMethod = 'groups.';
14
15			/**
16			* Permission Required To Work With This Extension
17			* @var int
18			*/
19			protected $requiredPermission = parent::PERMISSION_GROUPS;
20
21			/**
22			* Default Fields For Selection
23			*/
24			const defaultFields = [ 'description', 'members_count', 'status', 'contacts' ];
25
26			/**
27			* VKGroups constructor.
28			* @param VKBase $vkObject
29			*/
30			public function __construct(VKBase $vkObject) {
31			parent::__construct($vkObject);
32			parent::isAllowed($this->requiredPermission);
			0 ignored issues – show Comprehensibility Bug introduced 2016-04-01 14:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you call parent on a different method (`isAllowed()` instead of `__construct()`). Are you sure this is correct? If so, you might want to change this to `$this->isAllowed()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
33			}
34
35			/**
36			* Returns information specifying whether a user is a member of a community
37			* @param int \| string $groupID
38			* @param int $userID
39			* @param int $isExtended

darki73 / FreedomCoreVKAPI

Issues (63)

Security Analysis no request data

source/API/VKGroups.php (29 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like