danielneis / moodle-availability_paypal

ipn.php

Indentation +1 added lines, -1 removed lines

@@ -219,7 +219,7 @@
 
         // Pass $view=true to filter hidden caps if the user cannot see them.
         if ($users = get_users_by_capability($context, 'moodle/course:update', 'u.*', 'u.id ASC',
-                                             '', '', '', '', false, true)) {
+                                                '', '', '', '', false, true)) {
             $users = sort_by_roleassignment_authority($users, $context);
             $teacher = array_shift($users);
         } else {

Spacing +11 added lines, -11 removed lines

@@ -34,7 +34,7 @@ 
 require("../../../config.php");
 
 require_once($CFG->libdir.'/eventslib.php');
-require_once($CFG->libdir . '/filelib.php');
+require_once($CFG->libdir.'/filelib.php');
 
 // PayPal does not like when we return error messages here,
 // the custom handler just logs exceptions and stops.
@@ -77,15 +77,15 @@ 
 $custom = optional_param('custom', '', PARAM_TEXT);
 $custom = explode('-', $custom);
 $data->userid           = (int)$custom[0];
-$data->contextid       = (int)$custom[1];
+$data->contextid = (int)$custom[1];
 $data->timeupdated      = time();
 
-if (! $user = $DB->get_record("user", array("id" => $data->userid))) {
+if (!$user = $DB->get_record("user", array("id" => $data->userid))) {
     availability_paypal_message_error_to_admin("Not a valid user id", $data);
     die;
 }
 
-if (! $context = context::instance_by_id($data->contextid, IGNORE_MISSING)) {
+if (!$context = context::instance_by_id($data->contextid, IGNORE_MISSING)) {
     availability_paypal_message_error_to_admin("Not a valid context id", $data);
     die;
 }
@@ -144,7 +144,7 @@ 
 
         // If currency is incorrectly set then someone maybe trying to cheat the system.
         if ($data->payment_currency != $paypal->currency) {
-            $str = "Currency does not match course settings, received: " . $data->payment_currency;
+            $str = "Currency does not match course settings, received: ".$data->payment_currency;
             availability_paypal_message_error_to_admin($str, $data);
             die;
         }
@@ -169,8 +169,8 @@ 
 
         // If our status is not completed or not pending on an echeck clearance then ignore and die.
         // This check is redundant at present but may be useful if paypal extend the return codes in the future.
-        if (! ( $data->payment_status == "Completed" or
-               ($data->payment_status == "Pending" and $data->pending_reason == "echeck") ) ) {
+        if (!($data->payment_status == "Completed" or
+               ($data->payment_status == "Pending" and $data->pending_reason == "echeck"))) {
             die;
         }
 
@@ -204,10 +204,10 @@ 
         $coursecontext = context_course::instance($course->id, IGNORE_MISSING);
 
         // Check that amount paid is the correct amount.
-        if ( (float) $paypal->cost < 0 ) {
-            $cost = (float) 0;
+        if ((float)$paypal->cost < 0) {
+            $cost = (float)0;
         } else {
-            $cost = (float) $paypal->cost;
+            $cost = (float)$paypal->cost;
         }
 
         // Use the same rounding of floats as on the plugin form.
@@ -229,7 +229,7 @@ 
             $teacher = false;
         }
 
-    } else if (strcmp ($result, "INVALID") == 0) { // ERROR.
+    } else if (strcmp($result, "INVALID") == 0) { // ERROR.
         $DB->insert_record("availability_paypal_tnx", $data, false);
         availability_paypal_message_error_to_admin("Received an invalid payment notification!! (Fake payment?)", $data);
     }

classes/condition.php

Indentation +1 added lines, -1 removed lines

@@ -99,7 +99,7 @@
         // Should double-check with paypal everytime ?
         $context = $info->get_context();
         $allow = $DB->record_exists('availability_paypal_tnx',
-                                  array('userid' => $userid,
+                                    array('userid' => $userid,
                                         'contextid' => $context->id,
                                         'payment_status' => 'Completed'));
         if ($not) {

version.php

Spacing +1 added lines, -1 removed lines

@@ -27,5 +27,5 @@
 $plugin->version = 2018121902;
 $plugin->requires = 2015050500;
 $plugin->release = 7;
-$plugin->maturity   = MATURITY_STABLE;
+$plugin->maturity = MATURITY_STABLE;
 $plugin->component = 'availability_paypal';

view.php

Spacing +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
             <input type="hidden" name="no_note" value="1" />
             <input type="hidden" name="no_shipping" value="1" />
             <input type="hidden" name="notify_url" value="<?php echo "{$CFG->wwwroot}/availability/condition/paypal/ipn.php" ?>" />
-            <?php $returnurl = $CFG->wwwroot . '/availability/condition/paypal/view.php?contextid=' . $contextid; ?>
+            <?php $returnurl = $CFG->wwwroot.'/availability/condition/paypal/view.php?contextid='.$contextid; ?>
             <input type="hidden" name="return" value="<?php echo $returnurl; ?>" />
             <input type="hidden" name="cancel_return" value="<?php echo $returnurl; ?>" />
             <input type="hidden" name="rm" value="2" />