View GitHub Repository bank-holidays

Schedule Inspection
Subscribe
Completed
Push — master ( 017dcb...952f93 )
by Daniel
02:12
created
Status
Category
Toggle Patches
source/Romanian.php 1 patch
Doc Comments   +13 added lines, -7 removed lines patch added patch discarded remove patch 
@@ -36,12 +36,18 @@  discard block
 
 block discarded – undo
36 36 
 trait Romanian
37 37 
 {
38 38
39 
+    /**
40 
+     * @param string $year
41 
+     */
39 42 
     private function getEasterDatetime($year) {
40 43 
         $base = new \DateTime("$year-03-21");
41 44 
         $days = easter_days($year);
42 45 
         return $base->add(new \DateInterval("P{$days}D"));
43 46 
     }
44 47
48 
+    /**
49 
+     * @param string $fileBaseName
50 
+     */
45 51 
     private function readTypeFromJsonFile($fileBaseName) {
46 52 
         $fName       = __DIR__ . DIRECTORY_SEPARATOR . 'json' . DIRECTORY_SEPARATOR . $fileBaseName . '.min.json';
47 53 
         $fJson       = fopen($fName, 'r');
 
@@ -53,7 +59,7 @@  discard block
 
 block discarded – undo
53 59 
     /**
54 60 
      * List of legal holidays
55 61 
      *
56 
-     * @param date $lngDate
62 
+     * @param \DateTime $lngDate
57 63 
      * @param boolean $inclCatholicEaster
58 64 
      * @return array
59 65 
      */
 
@@ -79,8 +85,8 @@  discard block
 
 block discarded – undo
79 85 
      * List of all Romanian fixed holidays
80 86 
      * (where fixed means every single year occur on same day of the month)
81 87 
      *
82 
-     * @param date $lngDate
83 
-     * @return array
88 
+     * @param \DateTime $lngDate
89 
+     * @return integer[]
84 90 
      */
85 91 
     private function setHolidaysFixed(\DateTime $lngDate) {
86 92 
         $givenYear = $lngDate->format('Y');
 
@@ -103,7 +109,7 @@  discard block
 
 block discarded – undo
103 109 
      * List of Romanian fixed holidays that are still working (weird ones)
104 110 
      * (where fixed means every single year occur on same day of the month)
105 111 
      *
106 
-     * @param date $lngDate
112 
+     * @param \DateTime $lngDate
107 113 
      * @return array
108 114 
      */
109 115 
     private function setHolidaysFixedButWorking(\DateTime $lngDate) {
 
@@ -121,7 +127,7 @@  discard block
 
 block discarded – undo
121 127 
     /**
122 128 
      * List of all Orthodox holidays and Pentecost
123 129 
      *
124 
-     * @param date $lngDate
130 
+     * @param \DateTime $lngDate
125 131 
      * @return array
126 132 
      */
127 133 
     private function setHolidaysOrthodoxEaster(\DateTime $lngDate) {
 
@@ -139,7 +145,7 @@  discard block
 
 block discarded – undo
139 145 
     /**
140 146 
      * returns bank holidays in a given month
141 147 
      *
142 
-     * @param date $lngDate
148 
+     * @param \DateTime $lngDate
143 149 
      * @param boolean $inclCatholicEaster
144 150 
      * @return int
145 151 
      */
 
@@ -165,7 +171,7 @@  discard block
 
 block discarded – undo
165 171 
     /**
166 172 
      * returns working days in a given month
167 173 
      *
168 
-     * @param date $lngDate
174 
+     * @param \DateTime $lngDate
169 175 
      * @param boolean $inclCatholicEaster
170 176 
      * @return int
171 177 
      */
Please login to merge, or discard this patch.