danielgp / bank-holidays

source/Romanian.php

Doc Comments +12 added lines, -6 removed lines

@@ -36,12 +36,18 @@ 
 trait Romanian
 {
 
+    /**
+     * @param string $year
+     */
     private function getEasterDatetime($year) {
         $base = new \DateTime("$year-03-21");
         $days = easter_days($year);
         return $base->add(new \DateInterval("P{$days}D"));
     }
 
+    /**
+     * @param string $fileBaseName
+     */
     private function readTypeFromJsonFile($fileBaseName) {
         $fName       = __DIR__ . DIRECTORY_SEPARATOR . 'json' . DIRECTORY_SEPARATOR . $fileBaseName . '.min.json';
         $fJson       = fopen($fName, 'r');
@@ -53,7 +59,7 @@ 
     /**
      * List of legal holidays
      *
-     * @param date $lngDate
+     * @param \DateTime $lngDate
      * @param boolean $inclCatholicEaster
      * @return array
      */
@@ -79,8 +85,8 @@ 
      * List of all Romanian fixed holidays
      * (where fixed means every single year occur on same day of the month)
      *
-     * @param date $lngDate
-     * @return array
+     * @param \DateTime $lngDate
+     * @return integer[]
      */
     private function setHolidaysFixed($lngDate) {
         $givenYear = $lngDate->format('Y');
@@ -103,7 +109,7 @@ 
      * List of Romanian fixed holidays that are still working (weird ones)
      * (where fixed means every single year occur on same day of the month)
      *
-     * @param date $lngDate
+     * @param \DateTime $lngDate
      * @return array
      */
     private function setHolidaysFixedButWorking($lngDate) {
@@ -121,7 +127,7 @@ 
     /**
      * List of all Orthodox holidays and Pentecost
      *
-     * @param date $lngDate
+     * @param \DateTime $lngDate
      * @return array
      */
     private function setHolidaysOrthodoxEaster($lngDate) {
@@ -165,7 +171,7 @@ 
     /**
      * returns working days in a given month
      *
-     * @param date $lngDate
+     * @param \DateTime $lngDate
      * @param boolean $inclCatholicEaster
      * @return int
      */

sample/BankHoliday.php

Spacing +4 added lines, -4 removed lines

@@ -39,13 +39,13 @@
     public function __construct() {
         $todaysDate       = new \DateTime('now');
         $thisYearHolidays = $this->setHolidays($todaysDate);
-        echo '<h1>For ' . $todaysDate->format('Y') . ' the Romanian bank holidays are:</h1>'
+        echo '<h1>For '.$todaysDate->format('Y').' the Romanian bank holidays are:</h1>'
         . '<ul>';
         foreach ($thisYearHolidays as $value) {
-            echo '<li>' . $value . ' --- ' . date('l, d F Y', $value) . '</li>';
+            echo '<li>'.$value.' --- '.date('l, d F Y', $value).'</li>';
         }
         echo '</ul>'
-        . '<p>For the month of ' . $todaysDate->format('M Y') . ' the number of working days is: '
-        . $this->setWorkingDaysInMonth($todaysDate) . '<p>';
+        . '<p>For the month of '.$todaysDate->format('M Y').' the number of working days is: '
+        . $this->setWorkingDaysInMonth($todaysDate).'<p>';
     }
 }