MarketBook::getResults() - Code Metrics - danieledangeli/betfair-php - Measure and Improve Code Quality continuously with Scrutinizer

MarketBook::getResults() A
last analyzed 2019-01-31 14:52 UTC

↳ Parent: MarketBook

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php
/**
 * This file is part of the Betfair library.
 *
 * (c) Daniele D'Angeli <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Betfair\BettingApi\MarketBook;

use Betfair\AbstractBetfair;
use Betfair\Adapter\AdapterInterface;
use Betfair\Client\BetfairClientInterface;
use Betfair\Factory\MarketFilterFactoryInterface;
use Betfair\Factory\ParamFactoryInterface;
use Betfair\Model\PriceProjection;

class MarketBook extends AbstractBetfair
{
    const API_METHOD_NAME = "listMarketBook";

    private $marketIds = [];
    private $priceProjection;
    private $orderProjection;
    private $matchProjection;
    private $currencyCode;
    private $locale;

    /**
     * @param BetfairClientInterface $betfairClient
     * @param AdapterInterface $adapter
     * @param ParamFactoryInterface $paramFactory
     * @param MarketFilterFactoryInterface $marketFilterFactory
     */
    public function __construct(
        BetfairClientInterface $betfairClient,
        AdapterInterface $adapter,
        ParamFactoryInterface $paramFactory,
        MarketFilterFactoryInterface $marketFilterFactory
    ) {
        parent::__construct($betfairClient, $adapter, $paramFactory, $marketFilterFactory);
    }

    public function getResults()
    {
        $param = $this->createParam();
        $param->setMarketIds($this->marketIds)
            ->setPriceProjection($this->priceProjection)
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            ->setOrderProjection($this->orderProjection)
            ->setMarketProjection($this->matchProjection)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setCurrencyCode($this->currencyCode)
            ->setLocale($this->locale);

        $this->restoreDefaults();
        return $this->executeCustomQuery($param, self::API_METHOD_NAME);
    }

    public function getMarketBookFilterByMarketIds(array $marketIds)

    {
        $param = $this->createParam();

        $param->setMarketIds($marketIds);

        $this->restoreDefaults();

        return $this->adapter->adaptResponse(
            $this->apiNgRequest(self::API_METHOD_NAME, $param)
        );
    }

    public function getMarketBookFilterByMarketIdsWithPriceData(array $marketIds, array $priceData)

    {
        $param = $this->createParam();

        $param->setMarketIds($marketIds)
            ->setPriceProjection(new PriceProjection($priceData));

        $this->restoreDefaults();

        return $this->adapter->adaptResponse(
            $this->apiNgRequest(self::API_METHOD_NAME, $param)
        );
    }

    public function getMarketBookFilterByMarketIdsWithPriceProjection(array $marketIds, PriceProjection $priceProjection)

    {
        $param = $this->createParam()
            ->setMarketIds($marketIds)
            ->setPriceProjection($priceProjection);

        $this->restoreDefaults();

        return $this->adapter->adaptResponse(
            $this->apiNgRequest(self::API_METHOD_NAME, $param)
        );
    }

    public function withMarketIds($marketIds)
    {
        $this->marketIds = $marketIds;
        return $marketIds;
    }

    public function withPriceProjection(PriceProjection $priceProjection)
    {
        $this->priceProjection = $priceProjection;
        return $this;
    }

    public function withOrderProjection($orderProjection)
    {
        $this->orderProjection = $orderProjection;
        return $this;
    }

    public function withMatchProjection($matchProjection)
    {
        $this->matchProjection = $matchProjection;
        return $this;
    }

    public function withCurrencyCode($currencyCode)
    {
        $this->currencyCode = $currencyCode;
        return $this;
    }

    public function withLocale($locale)
    {
        $this->locale = $locale;
    }

    private function restoreDefaults()
    {
        $this->marketIds = null;

        $this->priceProjection = null;
        $this->orderProjection = null;
        $this->matchProjection = null;
        $this->currencyCode = null;
    }
}


1		<?php
2		/**
3		* This file is part of the Betfair library.
4		*
5		* (c) Daniele D'Angeli <[email protected]>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10		namespace Betfair\BettingApi\MarketBook;
11
12		use Betfair\AbstractBetfair;
13		use Betfair\Adapter\AdapterInterface;
14		use Betfair\Client\BetfairClientInterface;
15		use Betfair\Factory\MarketFilterFactoryInterface;
16		use Betfair\Factory\ParamFactoryInterface;
17		use Betfair\Model\PriceProjection;
18
19		class MarketBook extends AbstractBetfair
20		{
21		const API_METHOD_NAME = "listMarketBook";
22
23		private $marketIds = [];
24		private $priceProjection;
25		private $orderProjection;
26		private $matchProjection;
27		private $currencyCode;
28		private $locale;
29
30		/**
31		* @param BetfairClientInterface $betfairClient
32		* @param AdapterInterface $adapter
33		* @param ParamFactoryInterface $paramFactory
34		* @param MarketFilterFactoryInterface $marketFilterFactory
35		*/
36		public function __construct(
37		BetfairClientInterface $betfairClient,
38		AdapterInterface $adapter,
39		ParamFactoryInterface $paramFactory,
40		MarketFilterFactoryInterface $marketFilterFactory
41		) {
42		parent::__construct($betfairClient, $adapter, $paramFactory, $marketFilterFactory);
43		}
44
45		public function getResults()
46		{
47		$param = $this->createParam();
48		$param->setMarketIds($this->marketIds)
49		->setPriceProjection($this->priceProjection)
		0 ignored issues – show Bug introduced 2016-03-06 15:11 UTC by Report Bug Copy Issue Report It seems like `$this->priceProjection` can be `null`; however, `setPriceProjection()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
50		->setOrderProjection($this->orderProjection)
51		->setMarketProjection($this->matchProjection)
		0 ignored issues – show Documentation introduced 2016-09-05 00:51 UTC by Report Bug Copy Issue Report `$this->matchProjection` is of type `null`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52		->setCurrencyCode($this->currencyCode)
53		->setLocale($this->locale);
54
55		$this->restoreDefaults();
56		return $this->executeCustomQuery($param, self::API_METHOD_NAME);
57		}
58
59	View Code Duplication	public function getMarketBookFilterByMarketIds(array $marketIds)
		0 ignored issues – show Duplication introduced 2019-01-31 14:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
60		{
61		$param = $this->createParam();
62
63		$param->setMarketIds($marketIds);
64
65		$this->restoreDefaults();
66
67		return $this->adapter->adaptResponse(
68		$this->apiNgRequest(self::API_METHOD_NAME, $param)
69		);
70		}
71
72	View Code Duplication	public function getMarketBookFilterByMarketIdsWithPriceData(array $marketIds, array $priceData)
		0 ignored issues – show Duplication introduced 2019-01-31 14:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		{
74		$param = $this->createParam();
75
76		$param->setMarketIds($marketIds)
77		->setPriceProjection(new PriceProjection($priceData));
78
79		$this->restoreDefaults();
80
81		return $this->adapter->adaptResponse(
82		$this->apiNgRequest(self::API_METHOD_NAME, $param)
83		);
84		}
85
86	View Code Duplication	public function getMarketBookFilterByMarketIdsWithPriceProjection(array $marketIds, PriceProjection $priceProjection)
		0 ignored issues – show Duplication introduced 2016-03-06 15:11 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$param = $this->createParam()
89		->setMarketIds($marketIds)
90		->setPriceProjection($priceProjection);
91
92		$this->restoreDefaults();
93
94		return $this->adapter->adaptResponse(
95		$this->apiNgRequest(self::API_METHOD_NAME, $param)
96		);
97		}
98
99		public function withMarketIds($marketIds)
100		{
101		$this->marketIds = $marketIds;
102		return $marketIds;
103		}
104
105		public function withPriceProjection(PriceProjection $priceProjection)
106		{
107		$this->priceProjection = $priceProjection;
108		return $this;
109		}
110
111		public function withOrderProjection($orderProjection)
112		{
113		$this->orderProjection = $orderProjection;
114		return $this;
115		}
116
117		public function withMatchProjection($matchProjection)
118		{
119		$this->matchProjection = $matchProjection;
120		return $this;
121		}
122
123		public function withCurrencyCode($currencyCode)
124		{
125		$this->currencyCode = $currencyCode;
126		return $this;
127		}
128
129		public function withLocale($locale)
130		{
131		$this->locale = $locale;
132		}
133
134		private function restoreDefaults()
135		{
136		$this->marketIds = null;
		0 ignored issues – show Documentation Bug introduced 2016-03-06 15:11 UTC by Report Bug Copy Issue Report It seems like `null` of type `null` is incompatible with the declared type `array` of property `$marketIds`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
137		$this->priceProjection = null;
138		$this->orderProjection = null;
139		$this->matchProjection = null;
140		$this->currencyCode = null;
141		}
142		}
143

danieledangeli / betfair-php

MarketBook::getResults() A last analyzed 2019-01-31 14:52 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

MarketBook::getResults() A
last analyzed 2019-01-31 14:52 UTC