Betfair\BettingApi\MarketBook\MarketBook

Complexity

Total Complexity

12

Size/Duplication

Total Lines	124
Duplicated Lines	29.84 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	getResults()	0	13	1
A	getMarketBookFilterByMarketIds()	12	12	1
A	getMarketBookFilterByMarketIdsWithPriceData()	13	13	1
A	getMarketBookFilterByMarketIdsWithPriceProjection()	12	12	1
A	withMarketIds()	0	5	1
A	withPriceProjection()	0	5	1
A	withOrderProjection()	0	5	1
A	withMatchProjection()	0	5	1
A	withCurrencyCode()	0	5	1
A	withLocale()	0	4	1
A	restoreDefaults()	0	8	1

<?php
/**
 * This file is part of the Betfair library.
 *
 * (c) Daniele D'Angeli <dangeli88.daniele@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Betfair\BettingApi\MarketBook;

use Betfair\AbstractBetfair;
use Betfair\Adapter\AdapterInterface;
use Betfair\Client\BetfairClientInterface;
use Betfair\Factory\MarketFilterFactoryInterface;
use Betfair\Factory\ParamFactoryInterface;
use Betfair\Model\PriceProjection;

class MarketBook extends AbstractBetfair
{
    const API_METHOD_NAME = "listMarketBook";

    private $marketIds = [];
    private $priceProjection;
    private $orderProjection;
    private $matchProjection;
    private $currencyCode;
    private $locale;

    /**
     * @param BetfairClientInterface $betfairClient
     * @param AdapterInterface $adapter
     * @param ParamFactoryInterface $paramFactory
     * @param MarketFilterFactoryInterface $marketFilterFactory
     */
    public function __construct(
        BetfairClientInterface $betfairClient,
        AdapterInterface $adapter,
        ParamFactoryInterface $paramFactory,
        MarketFilterFactoryInterface $marketFilterFactory
    ) {
        parent::__construct($betfairClient, $adapter, $paramFactory, $marketFilterFactory);
    }

    public function getResults()
    {
        $param = $this->createParam();
        $param->setMarketIds($this->marketIds)
            ->setPriceProjection($this->priceProjection)

It seems like $this->priceProjection can be null; however, setPriceProjection() does not accept null, maybe add an additional type check?

            ->setOrderProjection($this->orderProjection)
            ->setMarketProjection($this->matchProjection)

$this->matchProjection is of type null, but the function expects a array.

            ->setCurrencyCode($this->currencyCode)
            ->setLocale($this->locale);

        $this->restoreDefaults();
        return $this->executeCustomQuery($param, self::API_METHOD_NAME);
    }

    public function getMarketBookFilterByMarketIds(array $marketIds)

This method seems to be duplicated in your project.

    {
        $param = $this->createParam();

        $param->setMarketIds($marketIds);

        $this->restoreDefaults();

        return $this->adapter->adaptResponse(
            $this->apiNgRequest(self::API_METHOD_NAME, $param)
        );
    }

    public function getMarketBookFilterByMarketIdsWithPriceData(array $marketIds, array $priceData)

This method seems to be duplicated in your project.

    {
        $param = $this->createParam();

        $param->setMarketIds($marketIds)
            ->setPriceProjection(new PriceProjection($priceData));

        $this->restoreDefaults();

        return $this->adapter->adaptResponse(
            $this->apiNgRequest(self::API_METHOD_NAME, $param)
        );
    }

    public function getMarketBookFilterByMarketIdsWithPriceProjection(array $marketIds, PriceProjection $priceProjection)

This method seems to be duplicated in your project.

    {
        $param = $this->createParam()
            ->setMarketIds($marketIds)
            ->setPriceProjection($priceProjection);

        $this->restoreDefaults();

        return $this->adapter->adaptResponse(
            $this->apiNgRequest(self::API_METHOD_NAME, $param)
        );
    }

    public function withMarketIds($marketIds)
    {
        $this->marketIds = $marketIds;
        return $marketIds;
    }

    public function withPriceProjection(PriceProjection $priceProjection)
    {
        $this->priceProjection = $priceProjection;
        return $this;
    }

    public function withOrderProjection($orderProjection)
    {
        $this->orderProjection = $orderProjection;
        return $this;
    }

    public function withMatchProjection($matchProjection)
    {
        $this->matchProjection = $matchProjection;
        return $this;
    }

    public function withCurrencyCode($currencyCode)
    {
        $this->currencyCode = $currencyCode;
        return $this;
    }

    public function withLocale($locale)
    {
        $this->locale = $locale;
    }

    private function restoreDefaults()
    {
        $this->marketIds = null;

It seems like null of type null is incompatible with the declared type array of property $marketIds.

        $this->priceProjection = null;
        $this->orderProjection = null;
        $this->matchProjection = null;
        $this->currencyCode = null;
    }
}