damax-solutions / media

src/Flysystem/FlysystemStorage.php

<?php

declare(strict_types=1);

namespace Damax\Media\Flysystem;

use Damax\Media\Domain\Exception\StorageFailure;
use Damax\Media\Domain\Model\File;
use Damax\Media\Domain\Storage\AbstractStorage;
use Damax\Media\Domain\Storage\Keys\Keys;
use Damax\Media\Flysystem\Registry\Registry;
use Damax\Media\Type\Types;
use Throwable;

final class FlysystemStorage extends AbstractStorage
{
    private $registry;

    public function __construct(Types $types, Keys $keys, Registry $registry)
    {
        parent::__construct($types, $keys);

        $this->registry = $registry;
    }

    protected function readFile(File $file): string
    {
        return $this->registry

The expression return $this->registry->get($file->storage())->read($file->key()) could return the type false which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

            ->get($file->storage())
            ->read($file->key())
        ;
    }

    protected function streamFile(File $file)
    {
        return $this->registry

The expression return $this->registry->get($file->storage())->readStream($file->key()) also could return the type false which is incompatible with the return type mandated by Damax\Media\Domain\Storage\AbstractStorage::streamFile() of resource.

            ->get($file->storage())
            ->readStream($file->key())
        ;
    }

    protected function deleteFile(File $file): void
    {
        $this->registry
            ->get($file->storage())
            ->delete($file->key())
        ;
    }

    protected function writeFile(string $key, string $storage, $stream): void
    {
        if (!$this->registry->has($storage)) {
            throw StorageFailure::unsupported($storage);
        }

        try {
            $result = $this->registry->get($storage)->writeStream($key, $stream);
        } catch (Throwable $e) {
            throw StorageFailure::invalidWrite($key, $e);
        }

        if (!$result) {
            throw StorageFailure::invalidWrite($key);
        }
    }
}