FlysystemStorage::readFile() - Code Metrics - damax-solutions/media - Measure and Improve Code Quality continuously with Scrutinizer

FlysystemStorage::readFile() A
last analyzed 2019-02-17 16:08 UTC

↳ Parent: FlysystemStorage

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	5
rs	10
c	0
b	0
f	0

<?php

declare(strict_types=1);

namespace Damax\Media\Flysystem;

use Damax\Media\Domain\Exception\StorageFailure;
use Damax\Media\Domain\Model\File;
use Damax\Media\Domain\Storage\AbstractStorage;
use Damax\Media\Domain\Storage\Keys\Keys;
use Damax\Media\Flysystem\Registry\Registry;
use Damax\Media\Type\Types;
use Throwable;

final class FlysystemStorage extends AbstractStorage
{
    private $registry;

    public function __construct(Types $types, Keys $keys, Registry $registry)
    {
        parent::__construct($types, $keys);

        $this->registry = $registry;
    }

    protected function readFile(File $file): string
    {
        return $this->registry

            ->get($file->storage())
            ->read($file->key())
        ;
    }

    protected function streamFile(File $file)
    {
        return $this->registry

            ->get($file->storage())
            ->readStream($file->key())
        ;
    }

    protected function deleteFile(File $file): void
    {
        $this->registry
            ->get($file->storage())
            ->delete($file->key())
        ;
    }

    protected function writeFile(string $key, string $storage, $stream): void
    {
        if (!$this->registry->has($storage)) {
            throw StorageFailure::unsupported($storage);
        }

        try {
            $result = $this->registry->get($storage)->writeStream($key, $stream);
        } catch (Throwable $e) {
            throw StorageFailure::invalidWrite($key, $e);
        }

        if (!$result) {
            throw StorageFailure::invalidWrite($key);
        }
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Damax\Media\Flysystem;
6
7			use Damax\Media\Domain\Exception\StorageFailure;
8			use Damax\Media\Domain\Model\File;
9			use Damax\Media\Domain\Storage\AbstractStorage;
10			use Damax\Media\Domain\Storage\Keys\Keys;
11			use Damax\Media\Flysystem\Registry\Registry;
12			use Damax\Media\Type\Types;
13			use Throwable;
14
15			final class FlysystemStorage extends AbstractStorage
16			{
17			private $registry;
18
19			public function __construct(Types $types, Keys $keys, Registry $registry)
20			{
21			parent::__construct($types, $keys);
22
23			$this->registry = $registry;
24			}
25
26			protected function readFile(File $file): string
27			{
28			return $this->registry
			0 ignored issues – show Bug Best Practice introduced 2019-02-17 15:49 UTC by Report Bug Copy Issue Report The expression `return $this->registry->...())->read($file->key())` could return the type `false` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
29			->get($file->storage())
30			->read($file->key())
31			;
32			}
33
34			protected function streamFile(File $file)
35			{
36			return $this->registry
			0 ignored issues – show Bug Best Practice introduced 2019-02-17 15:49 UTC by Report Bug Copy Issue Report The expression `return $this->registry->...eadStream($file->key())` also could return the type `false` which is incompatible with the return type mandated by `Damax\Media\Domain\Stora...ctStorage::streamFile()` of `resource`. Loading history...
37			->get($file->storage())
38			->readStream($file->key())
39			;
40			}
41
42			protected function deleteFile(File $file): void
43			{
44			$this->registry
45			->get($file->storage())
46			->delete($file->key())
47			;
48			}
49
50			protected function writeFile(string $key, string $storage, $stream): void
51			{
52			if (!$this->registry->has($storage)) {
53			throw StorageFailure::unsupported($storage);
54			}
55
56			try {
57			$result = $this->registry->get($storage)->writeStream($key, $stream);
58			} catch (Throwable $e) {
59			throw StorageFailure::invalidWrite($key, $e);
60			}
61
62			if (!$result) {
63			throw StorageFailure::invalidWrite($key);
64			}
65			}
66			}
67

damax-solutions / media

FlysystemStorage::readFile() A last analyzed 2019-02-17 16:08 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

FlysystemStorage::readFile() A
last analyzed 2019-02-17 16:08 UTC