Passed
Push — master ( 5988e7...23b4c3 )
by stéphane
02:08
created
yaml/Compact.php 1 patch
Braces   +6 added lines, -2 removed lines patch added patch discarded remove patch
@@ -25,8 +25,12 @@
 block discarded – undo
25 25
     public function jsonSerialize():array
26 26
     {
27 27
         $prop = get_object_vars($this);
28
-        if (count($prop) > 0) return $prop;
29
-        if (count($this) > 0) return iterator_to_array($this);
28
+        if (count($prop) > 0) {
29
+            return $prop;
30
+        }
31
+        if (count($this) > 0) {
32
+            return iterator_to_array($this);
33
+        }
30 34
     }
31 35
 
32 36
     /**
Please login to merge, or discard this patch.
yaml/Node.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -174,7 +174,7 @@
 block discarded – undo
174 174
         elseif (in_array($first, ['?', ':']))      NodeHandlers::onSetElement($nodeValue, $this);
175 175
         elseif (in_array($first, ['!', '&', '*'])) NodeHandlers::onNodeAction($nodeValue, $this);
176 176
         else {
177
-            $characters = [ '#' =>  [Y::COMMENT, $v],
177
+            $characters = ['#' =>  [Y::COMMENT, $v],
178 178
                             '%' =>  [Y::DIRECTIVE, $v],
179 179
                             '>' =>  [Y::LITT_FOLDED, null],
180 180
                             '|' =>  [Y::LITT, null]
Please login to merge, or discard this patch.
Braces   +18 added lines, -9 removed lines patch added patch discarded remove patch
@@ -68,8 +68,12 @@  discard block
 block discarded – undo
68 68
      */
69 69
     public function getParent(int $indent = null, $type = 0):Node
70 70
     {
71
-        if ($this->type === Y::ROOT) return $this;
72
-        if (!is_int($indent)) return $this->parent ?? $this;
71
+        if ($this->type === Y::ROOT) {
72
+            return $this;
73
+        }
74
+        if (!is_int($indent)) {
75
+            return $this->parent ?? $this;
76
+        }
73 77
         $cursor = $this;
74 78
         while ($cursor instanceof Node && $cursor->indent >= $indent) {
75 79
             if ($cursor->indent === $indent && $cursor->type !== $type) {
@@ -100,7 +104,7 @@  discard block
 block discarded – undo
100 104
         if (is_null($this->value)) {
101 105
             $this->value = $child;
102 106
             return;
103
-        }elseif ($this->value instanceof Node) {
107
+        } elseif ($this->value instanceof Node) {
104 108
             if ($this->value->type & Y::LITTERALS) {
105 109
                 $type = $this->value->type;
106 110
                 $this->value = new NodeList();
@@ -168,12 +172,17 @@  discard block
 block discarded – undo
168 172
     {
169 173
         $v = ltrim(substr($nodeValue, 1));
170 174
         $first = $nodeValue[0];
171
-        if ($first === "-")                        NodeHandlers::onHyphen($nodeValue, $this);
172
-        elseif (in_array($first, ['"', "'"]))      NodeHandlers::onQuoted($nodeValue, $this);
173
-        elseif (in_array($first, ['{', '[']))      NodeHandlers::onCompact($nodeValue, $this);
174
-        elseif (in_array($first, ['?', ':']))      NodeHandlers::onSetElement($nodeValue, $this);
175
-        elseif (in_array($first, ['!', '&', '*'])) NodeHandlers::onNodeAction($nodeValue, $this);
176
-        else {
175
+        if ($first === "-") {
176
+            NodeHandlers::onHyphen($nodeValue, $this);
177
+        } elseif (in_array($first, ['"', "'"])) {
178
+            NodeHandlers::onQuoted($nodeValue, $this);
179
+        } elseif (in_array($first, ['{', '['])) {
180
+            NodeHandlers::onCompact($nodeValue, $this);
181
+        } elseif (in_array($first, ['?', ':'])) {
182
+            NodeHandlers::onSetElement($nodeValue, $this);
183
+        } elseif (in_array($first, ['!', '&', '*'])) {
184
+            NodeHandlers::onNodeAction($nodeValue, $this);
185
+        } else {
177 186
             $characters = [ '#' =>  [Y::COMMENT, $v],
178 187
                             '%' =>  [Y::DIRECTIVE, $v],
179 188
                             '>' =>  [Y::LITT_FOLDED, null],
Please login to merge, or discard this patch.
yaml/NodeHandlers.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -66,28 +66,28 @@
 block discarded – undo
66 66
     public static function onCompact($value, Node $node)
67 67
     {
68 68
         $node->value = json_decode($value, false, 512, JSON_PARTIAL_OUTPUT_ON_ERROR|JSON_UNESCAPED_SLASHES);
69
-        if (json_last_error() === JSON_ERROR_NONE){
69
+        if (json_last_error() === JSON_ERROR_NONE) {
70 70
             $node->type = Y::JSON;
71 71
             return;
72 72
         }
73 73
         $node->value = new NodeList();
74
-        if (preg_match(R::MAPPING, $value)){
74
+        if (preg_match(R::MAPPING, $value)) {
75 75
             $node->type = Y::COMPACT_MAPPING;
76 76
             $node->value->type = Y::COMPACT_MAPPING;
77
-            preg_match_all(R::MAPPING_VALUES, trim(substr($value, 1,-1)), $matches);
77
+            preg_match_all(R::MAPPING_VALUES, trim(substr($value, 1, -1)), $matches);
78 78
             foreach ($matches['k'] as $index => $property) {
79 79
                 $n = new Node('', $node->line);
80 80
                 $n->type = Y::KEY;
81
-                $n->identifier = trim($property, '"\' ');//TODO : maybe check for proper quoting first ?
81
+                $n->identifier = trim($property, '"\' '); //TODO : maybe check for proper quoting first ?
82 82
                 $n->value = new Node($matches['v'][$index], $node->line);
83 83
                 $node->value->push($n);
84 84
             }
85 85
             return;
86 86
         }
87
-        if (preg_match(R::SEQUENCE, $value)){
87
+        if (preg_match(R::SEQUENCE, $value)) {
88 88
             $node->type = Y::COMPACT_SEQUENCE;
89 89
             $node->value->type = Y::COMPACT_SEQUENCE;
90
-            preg_match_all(R::SEQUENCE_VALUES, trim(substr($value, 1,-1)), $matches);
90
+            preg_match_all(R::SEQUENCE_VALUES, trim(substr($value, 1, -1)), $matches);
91 91
             foreach ($matches['item'] as $key => $item) {
92 92
                 $i = new Node('', $node->line);
93 93
                 $i->type = Y::ITEM;
Please login to merge, or discard this patch.
yaml/Builder.php 2 patches
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
         if ($_root->value instanceof NddeList) $_root->value->setIteratorMode(NodeList::IT_MODE_DELETE);
37 37
         foreach ($_root->value as $child) {
38 38
             if ($child->type & Y::DOC_START) {
39
-                if(++$totalDocStart > 1){
39
+                if (++$totalDocStart > 1) {
40 40
                     $documents[] = self::buildDocument($buffer, count($documents));
41 41
                     $buffer = new NodeList($child);
42 42
                 }
@@ -81,13 +81,13 @@  discard block
 block discarded – undo
81 81
      *
82 82
      * @return mixed    The parent (object|array) or a string representing the NodeList.
83 83
      */
84
-    public static function buildNodeList(NodeList $node, &$parent=null)
84
+    public static function buildNodeList(NodeList $node, &$parent = null)
85 85
     {
86 86
         $node->forceType();
87
-        if ($node->type & (Y::RAW | Y::LITTERALS)) {
87
+        if ($node->type & (Y::RAW|Y::LITTERALS)) {
88 88
             return self::buildLitteral($node, (int) $node->type);
89 89
         }
90
-        $action = function ($child, &$parent, &$out) {
90
+        $action = function($child, &$parent, &$out) {
91 91
             self::build($child, $out);
92 92
         };
93 93
         if ($node->type & (Y::COMPACT_MAPPING|Y::MAPPING|Y::SET)) {
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
             $out = $parent ?? [];
97 97
         } else {
98 98
             $out = '';
99
-            $action = function ($child, &$parent, &$out) {
99
+            $action = function($child, &$parent, &$out) {
100 100
                 if ($child->type & (Y::SCALAR|Y::QUOTED)) {
101 101
                     if ($parent) {
102 102
                         $parent->setText(self::build($child));
@@ -135,11 +135,11 @@  discard block
 block discarded – undo
135 135
         ];
136 136
         if (isset($actions[$type])) {
137 137
             return TB::{$actions[$type]}($node, $parent);
138
-        } elseif ($type & Y::COMMENT) {
138
+        } elseif ($type&Y::COMMENT) {
139 139
             self::$_root->addComment($line, $value);
140
-        } elseif ($type & (Y::COMPACT_MAPPING|Y::COMPACT_SEQUENCE)) {
140
+        } elseif ($type&(Y::COMPACT_MAPPING|Y::COMPACT_SEQUENCE)) {
141 141
             return self::buildNodeList($value, $parent);
142
-        } elseif ($type & (Y::REF_DEF | Y::REF_CALL)) {
142
+        } elseif ($type&(Y::REF_DEF|Y::REF_CALL)) {
143 143
             return TB::buildReference($node, $parent);
144 144
         } elseif ($value instanceof Node) {
145 145
             return self::buildNode($value, $parent);
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
         //remove trailing blank
166 166
         while ($list->top()->type & Y::BLANK) $list->pop();
167 167
         $result = '';
168
-        $separator = [ Y::RAW => '', Y::LITT => "\n", Y::LITT_FOLDED => ' '][$type];
168
+        $separator = [Y::RAW => '', Y::LITT => "\n", Y::LITT_FOLDED => ' '][$type];
169 169
         foreach ($list as $child) {
170 170
             if ($child->value instanceof NodeList) {
171 171
                 $result .= self::buildLitteral($child->value, $type).$separator;
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
     private static function setLiteralValue(Node $child, string &$result, int $refIndent, string $separator, int $type)
180 180
     {
181 181
         $val = $child->type & (Y::SCALAR) ? $child->value : substr($child->raw, $refIndent);
182
-        if ($type & Y::LITT_FOLDED && ($child->indent > $refIndent || ($child->type & Y::BLANK))) {
182
+        if ($type&Y::LITT_FOLDED && ($child->indent > $refIndent || ($child->type & Y::BLANK))) {
183 183
             if ($result[-1] === $separator)
184 184
                 $result[-1] = "\n";
185 185
             if ($result[-1] === "\n")
Please login to merge, or discard this patch.
Braces   +15 added lines, -7 removed lines patch added patch discarded remove patch
@@ -33,7 +33,9 @@  discard block
 block discarded – undo
33 33
         $totalDocStart = 0;
34 34
         $documents = [];
35 35
         $buffer = new NodeList();
36
-        if ($_root->value instanceof NddeList) $_root->value->setIteratorMode(NodeList::IT_MODE_DELETE);
36
+        if ($_root->value instanceof NddeList) {
37
+            $_root->value->setIteratorMode(NodeList::IT_MODE_DELETE);
38
+        }
37 39
         foreach ($_root->value as $child) {
38 40
             if ($child->type & Y::DOC_START) {
39 41
                 if(++$totalDocStart > 1){
@@ -69,7 +71,9 @@  discard block
 block discarded – undo
69 71
      */
70 72
     public static function build(object $node, &$parent = null)
71 73
     {
72
-        if ($node instanceof NodeList) return self::buildNodeList($node, $parent);
74
+        if ($node instanceof NodeList) {
75
+            return self::buildNodeList($node, $parent);
76
+        }
73 77
         return self::buildNode($node, $parent);
74 78
     }
75 79
 
@@ -163,7 +167,9 @@  discard block
 block discarded – undo
163 167
         $list->rewind();
164 168
         $refIndent = $list->current()->indent;
165 169
         //remove trailing blank
166
-        while ($list->top()->type & Y::BLANK) $list->pop();
170
+        while ($list->top()->type & Y::BLANK) {
171
+            $list->pop();
172
+        }
167 173
         $result = '';
168 174
         $separator = [ Y::RAW => '', Y::LITT => "\n", Y::LITT_FOLDED => ' '][$type];
169 175
         foreach ($list as $child) {
@@ -180,10 +186,12 @@  discard block
 block discarded – undo
180 186
     {
181 187
         $val = $child->type & (Y::SCALAR) ? $child->value : substr($child->raw, $refIndent);
182 188
         if ($type & Y::LITT_FOLDED && ($child->indent > $refIndent || ($child->type & Y::BLANK))) {
183
-            if ($result[-1] === $separator)
184
-                $result[-1] = "\n";
185
-            if ($result[-1] === "\n")
186
-                $result .= $val;
189
+            if ($result[-1] === $separator) {
190
+                            $result[-1] = "\n";
191
+            }
192
+            if ($result[-1] === "\n") {
193
+                            $result .= $val;
194
+            }
187 195
             return;
188 196
         }
189 197
         $result .= $val.$separator;
Please login to merge, or discard this patch.
yaml/TypesBuilder.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
      * @throws \ParseError if Key has no name(identifier) Note: empty string is allowed
33 33
      * @return null
34 34
      */
35
-    public static function buildKey(Node $node, &$parent=null)
35
+    public static function buildKey(Node $node, &$parent = null)
36 36
     {
37 37
         extract((array) $node, EXTR_REFS);
38 38
         if (is_null($identifier)) {
@@ -98,7 +98,7 @@  discard block
 block discarded – undo
98 98
     public function buildSetKey(Node $node, &$parent)
99 99
     {
100 100
         $built = is_object($node->value) ? Builder::build($node->value) : null;
101
-        $stringKey = is_string($built) && Regex::isProperlyQuoted($built) ? trim($built, '\'" '): $built;
101
+        $stringKey = is_string($built) && Regex::isProperlyQuoted($built) ? trim($built, '\'" ') : $built;
102 102
         $key = json_encode($stringKey, JSON_PARTIAL_OUTPUT_ON_ERROR|JSON_UNESCAPED_SLASHES);
103 103
         if (empty($key)) throw new \Exception("Cant serialize complex key: ".var_export($node->value, true), 1);
104 104
         $parent->{trim($key, '\'" ')} = null;
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
     {
115 115
         $prop = array_keys(get_object_vars($parent));
116 116
         $key = end($prop);
117
-        if ($node->value->type & (Y::ITEM|Y::KEY )) {
117
+        if ($node->value->type & (Y::ITEM|Y::KEY)) {
118 118
             $node->value = new NodeList($node->value);
119 119
         }
120 120
         $parent->{$key} = Builder::build(/** @scrutinizer ignore-type */ $node->value);
Please login to merge, or discard this patch.