MigrationTrait::getName() - Code Metrics - Inspection of "Add migration support" - daikon-cqrs/dbal - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 456c6d...06ba11 )

by Mr

created 2017-07-10 12:38 UTC

MigrationTrait::getName() A

↳ Parent: MigrationTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Importance

Changes

Metric	Value
dl	8
loc	8
c	0
b	0
f	0
rs	9.4285
cc	2
eloc	5
nc	2
nop	0

<?php

namespace Daikon\Dbal\Migration;

use Assert\Assertion;
use Daikon\Dbal\Connector\ConnectorInterface;
use Daikon\Dbal\Exception\MigrationException;

trait MigrationTrait
{
    private $executedAt;

    private $connector;

    public function __construct(\DateTimeImmutable $executedAt = null)
    {
        $this->executedAt = $executedAt;
    }

    public function execute(ConnectorInterface $connector, string $direction = self::MIGRATE_UP): void
    {
        $this->connector = $connector;

        if ($direction === self::MIGRATE_DOWN) {
            Assertion::true($this->isReversible());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            Assertion::true($this->hasExecuted());
            $this->down();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->executedAt = null;
        } else {
            Assertion::false($this->hasExecuted());
            $this->up();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            $this->executedAt = new \DateTimeImmutable('now');
        }
    }

    public function getName(): string

    {
        $shortName = (new \ReflectionClass(static::class))->getShortName();
        if (!preg_match('#^(?<name>.+?)\d+$#', $shortName, $matches)) {
            throw new MigrationException('Unexpected migration name in '.$shortName);
        }
        return $matches['name'];
    }

    public function getVersion(): int

    {
        $shortName= (new \ReflectionClass(static::class))->getShortName();
        if (!preg_match('#(?<version>\d{14})$#', $shortName, $matches)) {
            throw new MigrationException('Unexpected migration version in '.$shortName);
        }
        return intval($matches['version']);
    }

    public function hasExecuted(): bool
    {
        return $this->executedAt instanceof \DateTimeImmutable;
    }

    public function toArray(): array
    {
        $arr = [
            '@type' => static::class,
            'name' => $this->getName(),
            'version' => $this->getVersion(),
            'description' => $this->getDescription()
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        ];

        if ($this->hasExecuted()) {
            $arr['executedAt']  = $this->executedAt->format('c');
        }

        return $arr;
    }
}


1		<?php
2
3		namespace Daikon\Dbal\Migration;
4
5		use Assert\Assertion;
6		use Daikon\Dbal\Connector\ConnectorInterface;
7		use Daikon\Dbal\Exception\MigrationException;
8
9		trait MigrationTrait
10		{
11		private $executedAt;
12
13		private $connector;
14
15		public function __construct(\DateTimeImmutable $executedAt = null)
16		{
17		$this->executedAt = $executedAt;
18		}
19
20		public function execute(ConnectorInterface $connector, string $direction = self::MIGRATE_UP): void
21		{
22		$this->connector = $connector;
23
24		if ($direction === self::MIGRATE_DOWN) {
25		Assertion::true($this->isReversible());
		0 ignored issues – show Bug introduced 2017-07-10 12:40 UTC by Report Bug Copy Issue Report It seems like `isReversible()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26		Assertion::true($this->hasExecuted());
27		$this->down();
		0 ignored issues – show Bug introduced 2017-07-10 12:40 UTC by Report Bug Copy Issue Report It seems like `down()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
28		$this->executedAt = null;
29		} else {
30		Assertion::false($this->hasExecuted());
31		$this->up();
		0 ignored issues – show Bug introduced 2017-07-10 12:40 UTC by Report Bug Copy Issue Report It seems like `up()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32		$this->executedAt = new \DateTimeImmutable('now');
33		}
34		}
35
36	View Code Duplication	public function getName(): string
		0 ignored issues – show Duplication introduced 2017-07-10 12:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$shortName = (new \ReflectionClass(static::class))->getShortName();
39		if (!preg_match('#^(?<name>.+?)\d+$#', $shortName, $matches)) {
40		throw new MigrationException('Unexpected migration name in '.$shortName);
41		}
42		return $matches['name'];
43		}
44
45	View Code Duplication	public function getVersion(): int
		0 ignored issues – show Duplication introduced 2017-07-10 12:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
46		{
47		$shortName= (new \ReflectionClass(static::class))->getShortName();
48		if (!preg_match('#(?<version>\d{14})$#', $shortName, $matches)) {
49		throw new MigrationException('Unexpected migration version in '.$shortName);
50		}
51		return intval($matches['version']);
52		}
53
54		public function hasExecuted(): bool
55		{
56		return $this->executedAt instanceof \DateTimeImmutable;
57		}
58
59		public function toArray(): array
60		{
61		$arr = [
62		'@type' => static::class,
63		'name' => $this->getName(),
64		'version' => $this->getVersion(),
65		'description' => $this->getDescription()
		0 ignored issues – show Bug introduced 2017-07-10 12:40 UTC by Report Bug Copy Issue Report It seems like `getDescription()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
66		];
67
68		if ($this->hasExecuted()) {
69		$arr['executedAt'] = $this->executedAt->format('c');
70		}
71
72		return $arr;
73		}
74		}
75

daikon-cqrs / dbal

Push — master ( 456c6d...06ba11 )

MigrationTrait::getName() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like