Daikon\Dbal\Migration\MigrationTrait

Complexity

Total Complexity

10

Size/Duplication

Total Lines	66
Duplicated Lines	24.24 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	execute()	0	15	2
A	getName()	8	8	2
A	getVersion()	8	8	2
A	hasExecuted()	0	4	1
A	toArray()	0	15	2

<?php

namespace Daikon\Dbal\Migration;

use Assert\Assertion;
use Daikon\Dbal\Connector\ConnectorInterface;
use Daikon\Dbal\Exception\MigrationException;

trait MigrationTrait
{
    private $executedAt;

    private $connector;

    public function __construct(\DateTimeImmutable $executedAt = null)
    {
        $this->executedAt = $executedAt;
    }

    public function execute(ConnectorInterface $connector, string $direction = self::MIGRATE_UP): void
    {
        $this->connector = $connector;

        if ($direction === self::MIGRATE_DOWN) {
            Assertion::true($this->isReversible());

It seems like isReversible() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            Assertion::true($this->hasExecuted());
            $this->down();

It seems like down() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->executedAt = null;
        } else {
            Assertion::false($this->hasExecuted());
            $this->up();

It seems like up() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->executedAt = new \DateTimeImmutable('now');
        }
    }

    public function getName(): string

This method seems to be duplicated in your project.

    {
        $shortName = (new \ReflectionClass(static::class))->getShortName();
        if (!preg_match('#^(?<name>.+?)\d+$#', $shortName, $matches)) {
            throw new MigrationException('Unexpected migration name in '.$shortName);
        }
        return $matches['name'];
    }

    public function getVersion(): int

This method seems to be duplicated in your project.

    {
        $shortName= (new \ReflectionClass(static::class))->getShortName();
        if (!preg_match('#(?<version>\d{14})$#', $shortName, $matches)) {
            throw new MigrationException('Unexpected migration version in '.$shortName);
        }
        return intval($matches['version']);
    }

    public function hasExecuted(): bool
    {
        return $this->executedAt instanceof \DateTimeImmutable;
    }

    public function toArray(): array
    {
        $arr = [
            '@type' => static::class,
            'name' => $this->getName(),
            'version' => $this->getVersion(),
            'description' => $this->getDescription()

It seems like getDescription() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        ];

        if ($this->hasExecuted()) {
            $arr['executedAt']  = $this->executedAt->format('c');
        }

        return $arr;
    }
}