Completed
Pull Request — master (#243)
by Luc
06:45 queued 01:00
created
src/CalendarFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -205,7 +205,7 @@
 block discarded – undo
205 205
     }
206 206
 
207 207
     /**
208
-     * @param array $openingHours
208
+     * @param OpeningHour[] $openingHours
209 209
      * @return array
210 210
      */
211 211
     private function openingHoursToArray(array $openingHours)
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -33,14 +33,14 @@  discard block
 block discarded – undo
33 33
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
34 34
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
35 35
             $period = $cdbCalendar->current();
36
-            $startDateString = $period->getDateFrom() . 'T00:00:00';
36
+            $startDateString = $period->getDateFrom().'T00:00:00';
37 37
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
38 38
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
39 39
             $timestamp = $cdbCalendar->current();
40 40
             if ($timestamp->getStartTime()) {
41
-                $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
41
+                $startDateString = $timestamp->getDate().'T'.$timestamp->getStartTime();
42 42
             } else {
43
-                $startDateString = $timestamp->getDate() . 'T00:00:00';
43
+                $startDateString = $timestamp->getDate().'T00:00:00';
44 44
             }
45 45
         }
46 46
         $startDate = !empty($startDateString) ? DateTimeFactory::dateTimeFromDateString($startDateString) : null;
@@ -53,17 +53,17 @@  discard block
 block discarded – undo
53 53
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
54 54
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
55 55
             $period = $cdbCalendar->current();
56
-            $endDateString = $period->getDateTo() . 'T00:00:00';
56
+            $endDateString = $period->getDateTo().'T00:00:00';
57 57
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
58 58
             $firstTimestamp = $cdbCalendar->current();
59 59
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
60 60
             $cdbCalendarAsArray = iterator_to_array($cdbCalendar);
61 61
             $timestamp = iterator_count($cdbCalendar) > 1 ? end($cdbCalendarAsArray) : $firstTimestamp;
62 62
             if ($timestamp->getEndTime()) {
63
-                $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
63
+                $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
64 64
             } else {
65 65
                 $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
66
-                $endDateString = $timestamp->getDate() . 'T' . $endTime;
66
+                $endDateString = $timestamp->getDate().'T'.$endTime;
67 67
             }
68 68
         }
69 69
         $endDate = !empty($endDateString) ? DateTimeFactory::dateTimeFromDateString($endDateString) : null;
@@ -80,13 +80,13 @@  discard block
 block discarded – undo
80 80
                 $cdbCalendar->next();
81 81
 
82 82
                 if ($timestamp->getStartTime()) {
83
-                    $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
83
+                    $startDateString = $timestamp->getDate().'T'.$timestamp->getStartTime();
84 84
 
85 85
                     if ($timestamp->getEndTime()) {
86
-                        $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
86
+                        $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
87 87
                     } else {
88 88
                         $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
89
-                        $endDateString = $timestamp->getDate() . 'T' . $endTime;
89
+                        $endDateString = $timestamp->getDate().'T'.$endTime;
90 90
                     }
91 91
                 }
92 92
 
@@ -216,7 +216,7 @@  discard block
 block discarded – undo
216 216
             foreach ($openingHours as $openingHour) {
217 217
                 $openingHoursAsArray[] = [
218 218
                     'dayOfWeek' => array_map(
219
-                        function (WeekDay $weekDay) {
219
+                        function(WeekDay $weekDay) {
220 220
                             return strtolower($weekDay->toNative());
221 221
                         },
222 222
                         $openingHour->getWeekDays()
Please login to merge, or discard this patch.
src/Event/ReadModel/JSONLD/CdbXMLImporter.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Event\ReadModel\JSONLD;
4 4
 
5 5
 use CultureFeed_Cdb_Data_File;
6
-use CultureFeed_Cdb_Data_Keyword;
7 6
 use CultuurNet\UDB3\CalendarFactory;
8 7
 use CultuurNet\UDB3\Cdb\CdbId\EventCdbIdExtractorInterface;
9 8
 use CultuurNet\UDB3\Cdb\PriceDescriptionParser;
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     private function dateFromUdb2UnixTime($unixTime)
160 160
     {
161 161
         $dateTime = new \DateTime(
162
-            '@' . $unixTime,
162
+            '@'.$unixTime,
163 163
             new \DateTimeZone('Europe/Brussels')
164 164
         );
165 165
 
@@ -258,7 +258,7 @@  discard block
 block discarded – undo
258 258
                     'addressLocality' => $address->getCity(),
259 259
                     'postalCode' => $address->getZip(),
260 260
                     'streetAddress' =>
261
-                        $address->getStreet() . ' ' . $address->getHouseNumber(
261
+                        $address->getStreet().' '.$address->getHouseNumber(
262 262
                         ),
263 263
                 );
264 264
             }
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
     ) {
439 439
         $contactInfo = $event->getContactInfo();
440 440
 
441
-        $notForReservations = function ($item) {
441
+        $notForReservations = function($item) {
442 442
             /** @var \CultureFeed_Cdb_Data_Url|\CultureFeed_Cdb_Data_Phone|\CultureFeed_Cdb_Data_Mail $item */
443 443
             return !$item->isForReservations();
444 444
         };
@@ -450,7 +450,7 @@  discard block
 block discarded – undo
450 450
 
451 451
             if (!empty($emails)) {
452 452
                 $contactPoint['email'] = array_map(
453
-                    function (\CultureFeed_Cdb_Data_Mail $email) {
453
+                    function(\CultureFeed_Cdb_Data_Mail $email) {
454 454
                         return $email->getMailAddress();
455 455
                     },
456 456
                     $emails
@@ -462,7 +462,7 @@  discard block
 block discarded – undo
462 462
 
463 463
             if (!empty($phones)) {
464 464
                 $contactPoint['phone'] = array_map(
465
-                    function (\CultureFeed_Cdb_Data_phone $phone) {
465
+                    function(\CultureFeed_Cdb_Data_phone $phone) {
466 466
                         return $phone->getNumber();
467 467
                     },
468 468
                     $phones
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
474 474
 
475 475
             if (!empty($urls)) {
476 476
                 $contactPoint['url'] = array_map(
477
-                    function (\CultureFeed_Cdb_Data_Url $url) {
477
+                    function(\CultureFeed_Cdb_Data_Url $url) {
478 478
                         return $url->getUrl();
479 479
                     },
480 480
                     $urls
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
             $slug = '';
610 610
         }
611 611
 
612
-        $reference = 'http://www.uitinvlaanderen.be/agenda/e/' . $slug . '/' . $event->getCdbId();
612
+        $reference = 'http://www.uitinvlaanderen.be/agenda/e/'.$slug.'/'.$event->getCdbId();
613 613
 
614 614
 
615 615
         if (!property_exists($jsonLD, 'sameAs')) {
Please login to merge, or discard this patch.