Completed
Pull Request — master (#311)
by
unknown
04:10
created
src/Media/Events/MediaObjectCreated.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     }
84 84
 
85 85
     /**
86
-     * @return StringLiteral
86
+     * @return string
87 87
      */
88 88
     public function getDescription()
89 89
     {
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
     }
92 92
 
93 93
     /**
94
-     * @return StringLiteral
94
+     * @return string
95 95
      */
96 96
     public function getCopyrightHolder()
97 97
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -124,8 +124,8 @@
 block discarded – undo
124 124
             'mime_type' => $this->getMimeType()->toNative(),
125 125
             'description' => $this->getDescription()->toNative(),
126 126
             'copyright_holder' => $this->getCopyrightHolder()->toNative(),
127
-            'source_location' => (string) $this->getSourceLocation(),
128
-            'language' => (string) $this->getLanguage()
127
+            'source_location' => (string)$this->getSourceLocation(),
128
+            'language' => (string)$this->getLanguage()
129 129
         );
130 130
     }
131 131
 
Please login to merge, or discard this patch.
src/Media/ImageUploaderService.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Broadway\CommandHandling\CommandBusInterface;
6 6
 use Broadway\UuidGenerator\UuidGeneratorInterface;
7
-use CultuurNet\Entry\Number;
8 7
 use CultuurNet\UDB3\Language;
9 8
 use CultuurNet\UDB3\Media\Commands\UploadImage;
10 9
 use CultuurNet\UDB3\Media\Properties\MIMEType;
Please login to merge, or discard this patch.
src/Media/Serialization/MediaObjectSerializer.php 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -41,11 +41,11 @@  discard block
 block discarded – undo
41 41
         $normalizedData = [
42 42
             '@id' => $this->iriGenerator->iri($mediaObject->getMediaObjectId()),
43 43
             '@type' => $this->serializeMimeType($mediaObject->getMimeType()),
44
-            'contentUrl' => (string) $mediaObject->getSourceLocation(),
45
-            'thumbnailUrl' => (string) $mediaObject->getSourceLocation(),
46
-            'description' => (string) $mediaObject->getDescription(),
47
-            'copyrightHolder' => (string) $mediaObject->getCopyrightHolder(),
48
-            'inLanguage' => (string) $mediaObject->getLanguage(),
44
+            'contentUrl' => (string)$mediaObject->getSourceLocation(),
45
+            'thumbnailUrl' => (string)$mediaObject->getSourceLocation(),
46
+            'description' => (string)$mediaObject->getDescription(),
47
+            'copyrightHolder' => (string)$mediaObject->getCopyrightHolder(),
48
+            'inLanguage' => (string)$mediaObject->getLanguage(),
49 49
         ];
50 50
 
51 51
         return $normalizedData;
@@ -53,18 +53,18 @@  discard block
 block discarded – undo
53 53
 
54 54
     public function serializeMimeType(MIMEType $mimeType)
55 55
     {
56
-        $typeParts = explode('/', (string) $mimeType);
56
+        $typeParts = explode('/', (string)$mimeType);
57 57
         $type = array_shift($typeParts);
58 58
 
59 59
         if ($type === 'image') {
60 60
             return 'schema:ImageObject';
61 61
         }
62 62
 
63
-        if ((string) $mimeType === 'application/octet-stream') {
63
+        if ((string)$mimeType === 'application/octet-stream') {
64 64
             return 'schema:mediaObject';
65 65
         }
66 66
 
67
-        throw new UnsupportedException('Unsupported MIME-type "'. $mimeType .'"');
67
+        throw new UnsupportedException('Unsupported MIME-type "'.$mimeType.'"');
68 68
     }
69 69
 
70 70
     public function deserialize($data, $type, $format, array $context = array())
Please login to merge, or discard this patch.
src/Media/Image.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -127,12 +127,12 @@
 block discarded – undo
127 127
     public function serialize()
128 128
     {
129 129
         return [
130
-            'media_object_id' => (string) $this->getMediaObjectId(),
131
-            'mime_type' => (string) $this->getMimeType(),
132
-            'description' => (string) $this->getDescription(),
133
-            'copyright_holder' => (string) $this->getCopyrightHolder(),
134
-            'source_location' => (string) $this->getSourceLocation(),
135
-            'language' => (string) $this->getLanguage()
130
+            'media_object_id' => (string)$this->getMediaObjectId(),
131
+            'mime_type' => (string)$this->getMimeType(),
132
+            'description' => (string)$this->getDescription(),
133
+            'copyright_holder' => (string)$this->getCopyrightHolder(),
134
+            'source_location' => (string)$this->getSourceLocation(),
135
+            'language' => (string)$this->getLanguage()
136 136
         ];
137 137
     }
138 138
 }
Please login to merge, or discard this patch.
src/Media/MediaManager.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -78,11 +78,11 @@  discard block
 block discarded – undo
78 78
     ) {
79 79
         try {
80 80
             $existingMediaObject = $this->repository->load($id);
81
-            $this->logger->info('Trying to create media with id: ' .$id . ' but it already exists. Using existing Media Object!');
81
+            $this->logger->info('Trying to create media with id: '.$id.' but it already exists. Using existing Media Object!');
82 82
 
83 83
             return $existingMediaObject;
84 84
         } catch (AggregateNotFoundException $exception) {
85
-            $this->logger->info('No existing media with id: ' .$id . ' found. Creating a new Media Object!');
85
+            $this->logger->info('No existing media with id: '.$id.' found. Creating a new Media Object!');
86 86
         }
87 87
 
88 88
         $mediaObject = MediaObject::create(
@@ -117,7 +117,7 @@  discard block
 block discarded – undo
117 117
 
118 118
         $this->filesystem->rename(
119 119
             $uploadImage->getFilePath(),
120
-            $this->mediaDirectory . '/' . $destinationPath
120
+            $this->mediaDirectory.'/'.$destinationPath
121 121
         );
122 122
 
123 123
         $this->create(
@@ -129,7 +129,7 @@  discard block
 block discarded – undo
129 129
             $uploadImage->getLanguage()
130 130
         );
131 131
 
132
-        $jobInfo = ['file_id' => (string) $uploadImage->getFileId()];
132
+        $jobInfo = ['file_id' => (string)$uploadImage->getFileId()];
133 133
         $this->logger->info('job_info', $jobInfo);
134 134
     }
135 135
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     public function get(UUID $fileId)
140 140
     {
141 141
         try {
142
-            $mediaObject = $this->repository->load((string) $fileId);
142
+            $mediaObject = $this->repository->load((string)$fileId);
143 143
         } catch (AggregateNotFoundException $e) {
144 144
             throw new MediaObjectNotFoundException(
145 145
                 sprintf("Media object with id '%s' not found", $fileId),
@@ -163,8 +163,8 @@  discard block
 block discarded – undo
163 163
         $image = new Image(
164 164
             $mediaObject->getMediaObjectId(),
165 165
             $mediaObject->getMimeType(),
166
-            new Description((string) $mediaObject->getDescription()),
167
-            new CopyrightHolder((string) $mediaObject->getCopyrightHolder()),
166
+            new Description((string)$mediaObject->getDescription()),
167
+            new CopyrightHolder((string)$mediaObject->getCopyrightHolder()),
168 168
             $mediaObject->getSourceLocation(),
169 169
             $mediaObject->getLanguage()
170 170
         );
Please login to merge, or discard this patch.
src/Offer/ReadModel/JSONLD/OfferLDProjector.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -151,7 +151,7 @@  discard block
 block discarded – undo
151 151
 
152 152
             if (preg_match('/^apply(.+)$/', $method, $matches)) {
153 153
                 $event = $matches[1];
154
-                $classNameMethod = 'get' . $event . 'ClassName';
154
+                $classNameMethod = 'get'.$event.'ClassName';
155 155
 
156 156
                 if (method_exists($this, $classNameMethod)) {
157 157
                     $eventFullClassName = call_user_func(array($this, $classNameMethod));
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
         $labelsProperty = $labelAdded->getLabel()->isVisible() ? 'labels' : 'hiddenLabels';
293 293
 
294 294
         $labels = isset($offerLd->{$labelsProperty}) ? $offerLd->{$labelsProperty} : [];
295
-        $label = (string) $labelAdded->getLabel();
295
+        $label = (string)$labelAdded->getLabel();
296 296
 
297 297
         $labels[] = $label;
298 298
         $offerLd->{$labelsProperty} = array_unique($labels);
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
             if (isset($offerLd->{$labelsProperty}) && is_array($offerLd->{$labelsProperty})) {
319 319
                 $offerLd->{$labelsProperty} = array_filter(
320 320
                     $offerLd->{$labelsProperty},
321
-                    function ($label) use ($labelRemoved) {
321
+                    function($label) use ($labelRemoved) {
322 322
                         return !$labelRemoved->getLabel()->equals(
323 323
                             new Label($label)
324 324
                         );
@@ -418,7 +418,7 @@  discard block
 block discarded – undo
418 418
             return;
419 419
         }
420 420
 
421
-        $imageId = (string) $imageRemoved->getImage()->getMediaObjectId();
421
+        $imageId = (string)$imageRemoved->getImage()->getMediaObjectId();
422 422
 
423 423
         /**
424 424
          * Matches any object that is not the removed image.
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
          * @return bool
430 430
          *  Returns true when the media object does not match the image to remove.
431 431
          */
432
-        $shouldNotBeRemoved = function ($mediaObject) use ($imageId) {
432
+        $shouldNotBeRemoved = function($mediaObject) use ($imageId) {
433 433
             $containsId = !!strpos($mediaObject->{'@id'}, $imageId);
434 434
             return !$containsId;
435 435
         };
@@ -468,7 +468,7 @@  discard block
 block discarded – undo
468 468
         $document = $this->loadDocumentFromRepository($mainImageSelected);
469 469
         $offerLd = $document->getBody();
470 470
         $imageId = $mainImageSelected->getImage()->getMediaObjectId();
471
-        $mediaObjectMatcher = function ($matchingMediaObject, $currentMediaObject) use ($imageId) {
471
+        $mediaObjectMatcher = function($matchingMediaObject, $currentMediaObject) use ($imageId) {
472 472
             if (!$matchingMediaObject && $this->mediaObjectMatchesId($currentMediaObject, $imageId)) {
473 473
                 $matchingMediaObject = $currentMediaObject;
474 474
             }
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
      */
494 494
     protected function mediaObjectMatchesId($mediaObject, UUID $mediaObjectId)
495 495
     {
496
-        return strpos($mediaObject->{'@id'}, (string) $mediaObjectId) > 0;
496
+        return strpos($mediaObject->{'@id'}, (string)$mediaObjectId) > 0;
497 497
     }
498 498
 
499 499
     /**
@@ -657,7 +657,7 @@  discard block
 block discarded – undo
657 657
         $document = $this->loadDocumentFromRepository($typicalAgeRangeUpdated);
658 658
 
659 659
         $offerLd = $document->getBody();
660
-        $offerLd->typicalAgeRange = (string) $typicalAgeRangeUpdated->getTypicalAgeRange();
660
+        $offerLd->typicalAgeRange = (string)$typicalAgeRangeUpdated->getTypicalAgeRange();
661 661
 
662 662
         return $document->withBody($offerLd);
663 663
     }
@@ -785,14 +785,14 @@  discard block
 block discarded – undo
785 785
         $images = $imagesEvent->getImages();
786 786
         $currentMediaObjects = isset($offerLd->mediaObject) ? $offerLd->mediaObject : [];
787 787
         $dutchMediaObjects = array_map(
788
-            function (Image $image) {
788
+            function(Image $image) {
789 789
                 return $this->mediaObjectSerializer->serialize($image, 'json-ld');
790 790
             },
791 791
             $images->toArray()
792 792
         );
793 793
         $translatedMediaObjects = array_filter(
794 794
             $currentMediaObjects,
795
-            function ($image) {
795
+            function($image) {
796 796
                 return $image->inLanguage !== 'nl';
797 797
             }
798 798
         );
@@ -805,7 +805,7 @@  discard block
 block discarded – undo
805 805
         }
806 806
 
807 807
         if (isset($mainImage)) {
808
-            $offerLd->image = (string) $mainImage->getSourceLocation();
808
+            $offerLd->image = (string)$mainImage->getSourceLocation();
809 809
         }
810 810
     }
811 811
 
Please login to merge, or discard this patch.