Inspection of "Feature/iii 2454" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#359)

unknown

created 2018-04-09 14:40 UTC

Status

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -65,21 +65,21 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\Events\EventCreated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultMainLanguage($serializedObject);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Place\Events\PlaceCreated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultMainLanguage($serializedObject);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Organizer\Events\OrganizerCreatedWithUniqueWebsite',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultMainLanguage($serializedObject);
             }
         );
@@ -90,7 +90,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\TitleTranslated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = TitleTranslated::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -101,7 +101,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\DescriptionTranslated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = DescriptionTranslated::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -116,49 +116,49 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadeInvisible',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadeVisible',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadePrivate',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadePublic',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Organizer\Events\LabelAdded',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Organizer\Events\LabelRemoved',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\Events\EventWasLabelled',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelAdded::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\EventWasTagged',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelAdded::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -182,7 +182,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\TagErased',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelRemoved::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\Events\Unlabelled',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelRemoved::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -210,7 +210,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\EventImportedFromUDB2',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = EventImportedFromUDB2::class;
 
                 return $serializedObject;
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
          */
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Place\Events\FacilitiesUpdated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
 
                 return $serializedObject;
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
          */
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Place\Events\GeoCoordinatesUpdated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
 
                 return $serializedObject;
@@ -259,7 +259,7 @@  discard block
 block discarded – undo
         foreach ($refactoredEventEvents as $refactoredEventEvent) {
             $payloadManipulatingSerializer->manipulateEventsOfClass(
                 $refactoredEventEvent,
-                function (array $serializedObject) {
+                function(array $serializedObject) {
                     $serializedObject = self::replaceEventIdWithItemId($serializedObject);
                     return $serializedObject;
                 }
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
         foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) {
             $payloadManipulatingSerializer->manipulateEventsOfClass(
                 $refactoredPlaceEvent,
-                function (array $serializedObject) {
+                function(array $serializedObject) {
                     $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
                     return $serializedObject;
                 }
@@ -301,11 +301,11 @@  discard block
 block discarded – undo
         foreach ($priceInfoEvents as $priceInfoEvent) {
             $payloadManipulatingSerializer->manipulateEventsOfClass(
                 $priceInfoEvent,
-                function (array $serializedObject) {
+                function(array $serializedObject) {
                     $payload = &$serializedObject['payload'];
                     $priceInfo = &$payload['price_info'];
                     $tariffs = array_map(
-                        function (array $tariff) {
+                        function(array $tariff) {
                             $name = $tariff['name'];
                             if (is_string($name)) {
                                 $name = ['nl' => $name];

Please login to merge, or discard this patch.

		@@ -65,21 +65,21 @@ discard block
		block discarded – undo
65	65
66	66	$payloadManipulatingSerializer->manipulateEventsOfClass(
67	67	'CultuurNet\UDB3\Event\Events\EventCreated',
68		- function (array $serializedObject) {
	68	+ function(array $serializedObject) {
69	69	return self::addDefaultMainLanguage($serializedObject);
70	70	}
71	71	);
72	72
73	73	$payloadManipulatingSerializer->manipulateEventsOfClass(
74	74	'CultuurNet\UDB3\Place\Events\PlaceCreated',
75		- function (array $serializedObject) {
	75	+ function(array $serializedObject) {
76	76	return self::addDefaultMainLanguage($serializedObject);
77	77	}
78	78	);
79	79
80	80	$payloadManipulatingSerializer->manipulateEventsOfClass(
81	81	'CultuurNet\UDB3\Organizer\Events\OrganizerCreatedWithUniqueWebsite',
82		- function (array $serializedObject) {
	82	+ function(array $serializedObject) {
83	83	return self::addDefaultMainLanguage($serializedObject);
84	84	}
85	85	);
		@@ -90,7 +90,7 @@ discard block
		block discarded – undo
90	90
91	91	$payloadManipulatingSerializer->manipulateEventsOfClass(
92	92	'CultuurNet\UDB3\Event\TitleTranslated',
93		- function (array $serializedObject) {
	93	+ function(array $serializedObject) {
94	94	$serializedObject['class'] = TitleTranslated::class;
95	95
96	96	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -101,7 +101,7 @@ discard block
		block discarded – undo
101	101
102	102	$payloadManipulatingSerializer->manipulateEventsOfClass(
103	103	'CultuurNet\UDB3\Event\DescriptionTranslated',
104		- function (array $serializedObject) {
	104	+ function(array $serializedObject) {
105	105	$serializedObject['class'] = DescriptionTranslated::class;
106	106
107	107	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -116,49 +116,49 @@ discard block
		block discarded – undo
116	116
117	117	$payloadManipulatingSerializer->manipulateEventsOfClass(
118	118	'CultuurNet\UDB3\Label\Events\MadeInvisible',
119		- function (array $serializedObject) use ($labelRepository) {
	119	+ function(array $serializedObject) use ($labelRepository) {
120	120	return self::addLabelName($serializedObject, $labelRepository);
121	121	}
122	122	);
123	123
124	124	$payloadManipulatingSerializer->manipulateEventsOfClass(
125	125	'CultuurNet\UDB3\Label\Events\MadeVisible',
126		- function (array $serializedObject) use ($labelRepository) {
	126	+ function(array $serializedObject) use ($labelRepository) {
127	127	return self::addLabelName($serializedObject, $labelRepository);
128	128	}
129	129	);
130	130
131	131	$payloadManipulatingSerializer->manipulateEventsOfClass(
132	132	'CultuurNet\UDB3\Label\Events\MadePrivate',
133		- function (array $serializedObject) use ($labelRepository) {
	133	+ function(array $serializedObject) use ($labelRepository) {
134	134	return self::addLabelName($serializedObject, $labelRepository);
135	135	}
136	136	);
137	137
138	138	$payloadManipulatingSerializer->manipulateEventsOfClass(
139	139	'CultuurNet\UDB3\Label\Events\MadePublic',
140		- function (array $serializedObject) use ($labelRepository) {
	140	+ function(array $serializedObject) use ($labelRepository) {
141	141	return self::addLabelName($serializedObject, $labelRepository);
142	142	}
143	143	);
144	144
145	145	$payloadManipulatingSerializer->manipulateEventsOfClass(
146	146	'CultuurNet\UDB3\Organizer\Events\LabelAdded',
147		- function (array $serializedObject) use ($labelRepository) {
	147	+ function(array $serializedObject) use ($labelRepository) {
148	148	return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
149	149	}
150	150	);
151	151
152	152	$payloadManipulatingSerializer->manipulateEventsOfClass(
153	153	'CultuurNet\UDB3\Organizer\Events\LabelRemoved',
154		- function (array $serializedObject) use ($labelRepository) {
	154	+ function(array $serializedObject) use ($labelRepository) {
155	155	return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
156	156	}
157	157	);
158	158
159	159	$payloadManipulatingSerializer->manipulateEventsOfClass(
160	160	'CultuurNet\UDB3\Event\Events\EventWasLabelled',
161		- function (array $serializedObject) {
	161	+ function(array $serializedObject) {
162	162	$serializedObject['class'] = LabelAdded::class;
163	163
164	164	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -169,7 +169,7 @@ discard block
		block discarded – undo
169	169
170	170	$payloadManipulatingSerializer->manipulateEventsOfClass(
171	171	'CultuurNet\UDB3\Event\EventWasTagged',
172		- function (array $serializedObject) {
	172	+ function(array $serializedObject) {
173	173	$serializedObject['class'] = LabelAdded::class;
174	174
175	175	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -182,7 +182,7 @@ discard block
		block discarded – undo
182	182
183	183	$payloadManipulatingSerializer->manipulateEventsOfClass(
184	184	'CultuurNet\UDB3\Event\TagErased',
185		- function (array $serializedObject) {
	185	+ function(array $serializedObject) {
186	186	$serializedObject['class'] = LabelRemoved::class;
187	187
188	188	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -195,7 +195,7 @@ discard block
		block discarded – undo
195	195
196	196	$payloadManipulatingSerializer->manipulateEventsOfClass(
197	197	'CultuurNet\UDB3\Event\Events\Unlabelled',
198		- function (array $serializedObject) {
	198	+ function(array $serializedObject) {
199	199	$serializedObject['class'] = LabelRemoved::class;
200	200
201	201	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -210,7 +210,7 @@ discard block
		block discarded – undo
210	210
211	211	$payloadManipulatingSerializer->manipulateEventsOfClass(
212	212	'CultuurNet\UDB3\Event\EventImportedFromUDB2',
213		- function (array $serializedObject) {
	213	+ function(array $serializedObject) {
214	214	$serializedObject['class'] = EventImportedFromUDB2::class;
215	215
216	216	return $serializedObject;
		@@ -222,7 +222,7 @@ discard block
		block discarded – undo
222	222	*/
223	223	$payloadManipulatingSerializer->manipulateEventsOfClass(
224	224	'CultuurNet\UDB3\Place\Events\FacilitiesUpdated',
225		- function (array $serializedObject) {
	225	+ function(array $serializedObject) {
226	226	$serializedObject = self::replacePlaceIdWithItemId($serializedObject);
227	227
228	228	return $serializedObject;
		@@ -234,7 +234,7 @@ discard block
		block discarded – undo
234	234	*/
235	235	$payloadManipulatingSerializer->manipulateEventsOfClass(
236	236	'CultuurNet\UDB3\Place\Events\GeoCoordinatesUpdated',
237		- function (array $serializedObject) {
	237	+ function(array $serializedObject) {
238	238	$serializedObject = self::replacePlaceIdWithItemId($serializedObject);
239	239
240	240	return $serializedObject;
		@@ -259,7 +259,7 @@ discard block
		block discarded – undo
259	259	foreach ($refactoredEventEvents as $refactoredEventEvent) {
260	260	$payloadManipulatingSerializer->manipulateEventsOfClass(
261	261	$refactoredEventEvent,
262		- function (array $serializedObject) {
	262	+ function(array $serializedObject) {
263	263	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
264	264	return $serializedObject;
265	265	}
		@@ -283,7 +283,7 @@ discard block
		block discarded – undo
283	283	foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) {
284	284	$payloadManipulatingSerializer->manipulateEventsOfClass(
285	285	$refactoredPlaceEvent,
286		- function (array $serializedObject) {
	286	+ function(array $serializedObject) {
287	287	$serializedObject = self::replacePlaceIdWithItemId($serializedObject);
288	288	return $serializedObject;
289	289	}
		@@ -301,11 +301,11 @@ discard block
		block discarded – undo
301	301	foreach ($priceInfoEvents as $priceInfoEvent) {
302	302	$payloadManipulatingSerializer->manipulateEventsOfClass(
303	303	$priceInfoEvent,
304		- function (array $serializedObject) {
	304	+ function(array $serializedObject) {
305	305	$payload = &$serializedObject['payload'];
306	306	$priceInfo = &$payload['price_info'];
307	307	$tariffs = array_map(
308		- function (array $tariff) {
	308	+ function(array $tariff) {
309	309	$name = $tariff['name'];
310	310	if (is_string($name)) {
311	311	$name = ['nl' => $name];

cultuurnet / udb3-php

Pull Request — master (#359)

Status

Category

Spacing +22 added lines, -22 removed lines patch added patch discarded remove patch