CdbXmlCreatedByToUserIdResolver::resolveByEmailOrByNick() - Code Metrics - Inspection of "Feature/iii 810 Sanity check backwards compatibili..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#137)

by Kristof

created 2016-03-09 20:22 UTC

resolveByEmailOrByNick() A

↳ Parent: CdbXmlCreatedByToUserIdResolver

Complexity

Conditions	2
Paths	3

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	11
rs	9.4285
cc	2
eloc	7
nc	3
nop	1

<?php
/**
 * @file
 */

namespace CultuurNet\UDB3\UiTID;

use CultuurNet\UDB3\Cdb\CreatedByToUserIdResolverInterface;
use Exception;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\NullLogger;
use ValueObjects\Exception\InvalidNativeArgumentException;
use ValueObjects\String\String;
use ValueObjects\Web\EmailAddress;

class CdbXmlCreatedByToUserIdResolver implements LoggerAwareInterface, CreatedByToUserIdResolverInterface
{
    use LoggerAwareTrait;

    /**
     * @var UsersInterface
     */
    private $users;

    /**
     * @param UsersInterface $users
     */
    public function __construct(UsersInterface $users)
    {
        $this->users = $users;
        $this->logger = new NullLogger();
    }

    /**
     * @inheritdoc
     */
    public function resolveCreatedByToUserId(String $createdByIdentifier)
    {
        $userId = null;

        try {
            $userId = $this->resolveByEmailOrByNick($createdByIdentifier);

            if (!$userId) {
                $this->logger->warning(
                    'Unable to find user with identifier ' . $createdByIdentifier
                );
            }
        }
        catch (Exception $e) {
            $this->logger->error(
                sprintf(
                    'An unexpected error occurred while resolving user with identifier %s',
                    $createdByIdentifier
                ),
                [
                    'exception' => $e,
                ]
            );
        }

        return $userId;
    }

    /**
     * @param String $createdByIdentifier
     * @return String
     */
    private function resolveByEmailOrByNick(String $createdByIdentifier)
    {
        try {
            $email = new EmailAddress($createdByIdentifier->toNative());
function someFunction(A $objectMaybe = null)
{
    if ($objectMaybe instanceof A) {
        $objectMaybe->doSomething();
    }
}
            $userId = $this->users->byEmail($email);
        } catch (InvalidNativeArgumentException $e) {
            $userId = $this->users->byNick($createdByIdentifier);
        }

        return $userId;
    }
}


1			<?php
2			/**
3			* @file
4			*/
5
6			namespace CultuurNet\UDB3\UiTID;
7
8			use CultuurNet\UDB3\Cdb\CreatedByToUserIdResolverInterface;
9			use Exception;
10			use Psr\Log\LoggerAwareInterface;
11			use Psr\Log\LoggerAwareTrait;
12			use Psr\Log\NullLogger;
13			use ValueObjects\Exception\InvalidNativeArgumentException;
14			use ValueObjects\String\String;
15			use ValueObjects\Web\EmailAddress;
16
17			class CdbXmlCreatedByToUserIdResolver implements LoggerAwareInterface, CreatedByToUserIdResolverInterface
18			{
19			use LoggerAwareTrait;
20
21			/**
22			* @var UsersInterface
23			*/
24			private $users;
25
26			/**
27			* @param UsersInterface $users
28			*/
29			public function __construct(UsersInterface $users)
30			{
31			$this->users = $users;
32			$this->logger = new NullLogger();
33			}
34
35			/**
36			* @inheritdoc
37			*/
38			public function resolveCreatedByToUserId(String $createdByIdentifier)
39			{
40			$userId = null;
41
42			try {
43			$userId = $this->resolveByEmailOrByNick($createdByIdentifier);
44
45			if (!$userId) {
46			$this->logger->warning(
47			'Unable to find user with identifier ' . $createdByIdentifier
48			);
49			}
50			}
51			catch (Exception $e) {
52			$this->logger->error(
53			sprintf(
54			'An unexpected error occurred while resolving user with identifier %s',
55			$createdByIdentifier
56			),
57			[
58			'exception' => $e,
59			]
60			);
61			}
62
63			return $userId;
64			}
65
66			/**
67			* @param String $createdByIdentifier
68			* @return String
69			*/
70			private function resolveByEmailOrByNick(String $createdByIdentifier)
71			{
72			try {
73			$email = new EmailAddress($createdByIdentifier->toNative());
			0 ignored issues – show Bug introduced 2016-03-09 20:27 UTC by Report Bug Copy Issue Report It seems like `$createdByIdentifier` is not always an object, but can also be of type `string`. Maybe add an additional type check? If a variable is not always an object, we recommend to add an additional type check to ensure your method call is safe: function someFunction(A $objectMaybe = null) { if ($objectMaybe instanceof A) { $objectMaybe->doSomething(); } } Loading history...
74			$userId = $this->users->byEmail($email);
75			} catch (InvalidNativeArgumentException $e) {
76			$userId = $this->users->byNick($createdByIdentifier);
77			}
78
79			return $userId;
80			}
81			}
82

cultuurnet / udb3-php

Pull Request — master (#137)

resolveByEmailOrByNick() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like