CultuurNet\UDB3\UiTID\CdbXmlCreatedByToUserIdResolver

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
B	resolveCreatedByToUserId()	0	27	3
A	resolveByEmailOrByNick()	0	11	2

<?php
/**
 * @file
 */

namespace CultuurNet\UDB3\UiTID;

use CultuurNet\UDB3\Cdb\CreatedByToUserIdResolverInterface;
use Exception;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\NullLogger;
use ValueObjects\Exception\InvalidNativeArgumentException;
use ValueObjects\String\String;
use ValueObjects\Web\EmailAddress;

class CdbXmlCreatedByToUserIdResolver implements LoggerAwareInterface, CreatedByToUserIdResolverInterface
{
    use LoggerAwareTrait;

    /**
     * @var UsersInterface
     */
    private $users;

    /**
     * @param UsersInterface $users
     */
    public function __construct(UsersInterface $users)
    {
        $this->users = $users;
        $this->logger = new NullLogger();
    }

    /**
     * @inheritdoc
     */
    public function resolveCreatedByToUserId(String $createdByIdentifier)
    {
        $userId = null;

        try {
            $userId = $this->resolveByEmailOrByNick($createdByIdentifier);

            if (!$userId) {
                $this->logger->warning(
                    'Unable to find user with identifier ' . $createdByIdentifier
                );
            }
        }
        catch (Exception $e) {
            $this->logger->error(
                sprintf(
                    'An unexpected error occurred while resolving user with identifier %s',
                    $createdByIdentifier
                ),
                [
                    'exception' => $e,
                ]
            );
        }

        return $userId;
    }

    /**
     * @param String $createdByIdentifier
     * @return String
     */
    private function resolveByEmailOrByNick(String $createdByIdentifier)
    {
        try {
            $email = new EmailAddress($createdByIdentifier->toNative());

It seems like $createdByIdentifier is not always an object, but can also be of type string. Maybe add an additional type check?

            $userId = $this->users->byEmail($email);
        } catch (InvalidNativeArgumentException $e) {
            $userId = $this->users->byNick($createdByIdentifier);
        }

        return $userId;
    }
}