Inspection of "III-2786: Add unit test for fix committed in aece9..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 70b047...5c79cc )

by Kristof

created 2019-01-09 08:36 UTC

Status

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch

@@ -69,21 +69,21 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\Events\EventCreated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultMainLanguage($serializedObject);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Place\Events\PlaceCreated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultMainLanguage($serializedObject);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Organizer\Events\OrganizerCreatedWithUniqueWebsite',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultMainLanguage($serializedObject);
             }
         );
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\TitleTranslated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = TitleTranslated::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\DescriptionTranslated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = DescriptionTranslated::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -120,49 +120,49 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadeInvisible',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadeVisible',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadePrivate',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Label\Events\MadePublic',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::addLabelName($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Organizer\Events\LabelAdded',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Organizer\Events\LabelRemoved',
-            function (array $serializedObject) use ($labelRepository) {
+            function(array $serializedObject) use ($labelRepository) {
                 return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\Events\EventWasLabelled',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelAdded::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -173,7 +173,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\EventWasTagged',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelAdded::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\TagErased',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelRemoved::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\Events\Unlabelled',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = LabelRemoved::class;
 
                 $serializedObject = self::replaceEventIdWithItemId($serializedObject);
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Event\EventImportedFromUDB2',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = EventImportedFromUDB2::class;
 
                 return $serializedObject;
@@ -226,7 +226,7 @@  discard block
 block discarded – undo
          */
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Place\Events\FacilitiesUpdated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
 
                 return $serializedObject;
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
          */
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Place\Events\GeoCoordinatesUpdated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
 
                 return $serializedObject;
@@ -248,7 +248,7 @@  discard block
 block discarded – undo
         /**
          * BOOKING INFO EVENT
          */
-        $manipulateAvailability = function (array $serializedBookingInfo, $propertyName) {
+        $manipulateAvailability = function(array $serializedBookingInfo, $propertyName) {
             if (!isset($serializedBookingInfo[$propertyName]) || empty($serializedBookingInfo[$propertyName])) {
                 $serializedBookingInfo[$propertyName] = null;
                 return $serializedBookingInfo;
@@ -278,7 +278,7 @@  discard block
 block discarded – undo
             return $serializedBookingInfo;
         };
 
-        $manipulateUrlLabel = function (array $serializedBookingInfo) {
+        $manipulateUrlLabel = function(array $serializedBookingInfo) {
             if (!isset($serializedBookingInfo['urlLabel'])) {
                 return $serializedBookingInfo;
             }
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
             return $serializedBookingInfo;
         };
 
-        $manipulateBookingInfoEvent = function (
+        $manipulateBookingInfoEvent = function(
             array $serializedEvent
         ) use (
             $manipulateAvailability,
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
         foreach ($refactoredEventEvents as $refactoredEventEvent) {
             $payloadManipulatingSerializer->manipulateEventsOfClass(
                 $refactoredEventEvent,
-                function (array $serializedObject) {
+                function(array $serializedObject) {
                     $serializedObject = self::replaceEventIdWithItemId($serializedObject);
                     return $serializedObject;
                 }
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
         foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) {
             $payloadManipulatingSerializer->manipulateEventsOfClass(
                 $refactoredPlaceEvent,
-                function (array $serializedObject) {
+                function(array $serializedObject) {
                     $serializedObject = self::replacePlaceIdWithItemId($serializedObject);
                     return $serializedObject;
                 }
@@ -390,11 +390,11 @@  discard block
 block discarded – undo
         foreach ($priceInfoEvents as $priceInfoEvent) {
             $payloadManipulatingSerializer->manipulateEventsOfClass(
                 $priceInfoEvent,
-                function (array $serializedObject) {
+                function(array $serializedObject) {
                     $payload = &$serializedObject['payload'];
                     $priceInfo = &$payload['price_info'];
                     $tariffs = array_map(
-                        function (array $tariff) {
+                        function(array $tariff) {
                             $name = $tariff['name'];
                             if (is_string($name)) {
                                 $name = ['nl' => $name];
@@ -415,7 +415,7 @@  discard block
 block discarded – undo
          */
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             'CultuurNet\UDB3\Role\Events\ConstraintCreated',
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 $serializedObject['class'] = ConstraintAdded::class;
                 return self::addDefaultSapiVersion($serializedObject);
             }
@@ -423,14 +423,14 @@  discard block
 block discarded – undo
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             ConstraintUpdated::class,
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultSapiVersion($serializedObject);
             }
         );
 
         $payloadManipulatingSerializer->manipulateEventsOfClass(
             ConstraintRemoved::class,
-            function (array $serializedObject) {
+            function(array $serializedObject) {
                 return self::addDefaultSapiVersion($serializedObject);
             }
         );

Please login to merge, or discard this patch.

		@@ -69,21 +69,21 @@ discard block
		block discarded – undo
69	69
70	70	$payloadManipulatingSerializer->manipulateEventsOfClass(
71	71	'CultuurNet\UDB3\Event\Events\EventCreated',
72		- function (array $serializedObject) {
	72	+ function(array $serializedObject) {
73	73	return self::addDefaultMainLanguage($serializedObject);
74	74	}
75	75	);
76	76
77	77	$payloadManipulatingSerializer->manipulateEventsOfClass(
78	78	'CultuurNet\UDB3\Place\Events\PlaceCreated',
79		- function (array $serializedObject) {
	79	+ function(array $serializedObject) {
80	80	return self::addDefaultMainLanguage($serializedObject);
81	81	}
82	82	);
83	83
84	84	$payloadManipulatingSerializer->manipulateEventsOfClass(
85	85	'CultuurNet\UDB3\Organizer\Events\OrganizerCreatedWithUniqueWebsite',
86		- function (array $serializedObject) {
	86	+ function(array $serializedObject) {
87	87	return self::addDefaultMainLanguage($serializedObject);
88	88	}
89	89	);
		@@ -94,7 +94,7 @@ discard block
		block discarded – undo
94	94
95	95	$payloadManipulatingSerializer->manipulateEventsOfClass(
96	96	'CultuurNet\UDB3\Event\TitleTranslated',
97		- function (array $serializedObject) {
	97	+ function(array $serializedObject) {
98	98	$serializedObject['class'] = TitleTranslated::class;
99	99
100	100	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -105,7 +105,7 @@ discard block
		block discarded – undo
105	105
106	106	$payloadManipulatingSerializer->manipulateEventsOfClass(
107	107	'CultuurNet\UDB3\Event\DescriptionTranslated',
108		- function (array $serializedObject) {
	108	+ function(array $serializedObject) {
109	109	$serializedObject['class'] = DescriptionTranslated::class;
110	110
111	111	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -120,49 +120,49 @@ discard block
		block discarded – undo
120	120
121	121	$payloadManipulatingSerializer->manipulateEventsOfClass(
122	122	'CultuurNet\UDB3\Label\Events\MadeInvisible',
123		- function (array $serializedObject) use ($labelRepository) {
	123	+ function(array $serializedObject) use ($labelRepository) {
124	124	return self::addLabelName($serializedObject, $labelRepository);
125	125	}
126	126	);
127	127
128	128	$payloadManipulatingSerializer->manipulateEventsOfClass(
129	129	'CultuurNet\UDB3\Label\Events\MadeVisible',
130		- function (array $serializedObject) use ($labelRepository) {
	130	+ function(array $serializedObject) use ($labelRepository) {
131	131	return self::addLabelName($serializedObject, $labelRepository);
132	132	}
133	133	);
134	134
135	135	$payloadManipulatingSerializer->manipulateEventsOfClass(
136	136	'CultuurNet\UDB3\Label\Events\MadePrivate',
137		- function (array $serializedObject) use ($labelRepository) {
	137	+ function(array $serializedObject) use ($labelRepository) {
138	138	return self::addLabelName($serializedObject, $labelRepository);
139	139	}
140	140	);
141	141
142	142	$payloadManipulatingSerializer->manipulateEventsOfClass(
143	143	'CultuurNet\UDB3\Label\Events\MadePublic',
144		- function (array $serializedObject) use ($labelRepository) {
	144	+ function(array $serializedObject) use ($labelRepository) {
145	145	return self::addLabelName($serializedObject, $labelRepository);
146	146	}
147	147	);
148	148
149	149	$payloadManipulatingSerializer->manipulateEventsOfClass(
150	150	'CultuurNet\UDB3\Organizer\Events\LabelAdded',
151		- function (array $serializedObject) use ($labelRepository) {
	151	+ function(array $serializedObject) use ($labelRepository) {
152	152	return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
153	153	}
154	154	);
155	155
156	156	$payloadManipulatingSerializer->manipulateEventsOfClass(
157	157	'CultuurNet\UDB3\Organizer\Events\LabelRemoved',
158		- function (array $serializedObject) use ($labelRepository) {
	158	+ function(array $serializedObject) use ($labelRepository) {
159	159	return self::fixOrganizerLabelEvent($serializedObject, $labelRepository);
160	160	}
161	161	);
162	162
163	163	$payloadManipulatingSerializer->manipulateEventsOfClass(
164	164	'CultuurNet\UDB3\Event\Events\EventWasLabelled',
165		- function (array $serializedObject) {
	165	+ function(array $serializedObject) {
166	166	$serializedObject['class'] = LabelAdded::class;
167	167
168	168	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -173,7 +173,7 @@ discard block
		block discarded – undo
173	173
174	174	$payloadManipulatingSerializer->manipulateEventsOfClass(
175	175	'CultuurNet\UDB3\Event\EventWasTagged',
176		- function (array $serializedObject) {
	176	+ function(array $serializedObject) {
177	177	$serializedObject['class'] = LabelAdded::class;
178	178
179	179	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -186,7 +186,7 @@ discard block
		block discarded – undo
186	186
187	187	$payloadManipulatingSerializer->manipulateEventsOfClass(
188	188	'CultuurNet\UDB3\Event\TagErased',
189		- function (array $serializedObject) {
	189	+ function(array $serializedObject) {
190	190	$serializedObject['class'] = LabelRemoved::class;
191	191
192	192	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -199,7 +199,7 @@ discard block
		block discarded – undo
199	199
200	200	$payloadManipulatingSerializer->manipulateEventsOfClass(
201	201	'CultuurNet\UDB3\Event\Events\Unlabelled',
202		- function (array $serializedObject) {
	202	+ function(array $serializedObject) {
203	203	$serializedObject['class'] = LabelRemoved::class;
204	204
205	205	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
		@@ -214,7 +214,7 @@ discard block
		block discarded – undo
214	214
215	215	$payloadManipulatingSerializer->manipulateEventsOfClass(
216	216	'CultuurNet\UDB3\Event\EventImportedFromUDB2',
217		- function (array $serializedObject) {
	217	+ function(array $serializedObject) {
218	218	$serializedObject['class'] = EventImportedFromUDB2::class;
219	219
220	220	return $serializedObject;
		@@ -226,7 +226,7 @@ discard block
		block discarded – undo
226	226	*/
227	227	$payloadManipulatingSerializer->manipulateEventsOfClass(
228	228	'CultuurNet\UDB3\Place\Events\FacilitiesUpdated',
229		- function (array $serializedObject) {
	229	+ function(array $serializedObject) {
230	230	$serializedObject = self::replacePlaceIdWithItemId($serializedObject);
231	231
232	232	return $serializedObject;
		@@ -238,7 +238,7 @@ discard block
		block discarded – undo
238	238	*/
239	239	$payloadManipulatingSerializer->manipulateEventsOfClass(
240	240	'CultuurNet\UDB3\Place\Events\GeoCoordinatesUpdated',
241		- function (array $serializedObject) {
	241	+ function(array $serializedObject) {
242	242	$serializedObject = self::replacePlaceIdWithItemId($serializedObject);
243	243
244	244	return $serializedObject;
		@@ -248,7 +248,7 @@ discard block
		block discarded – undo
248	248	/**
249	249	* BOOKING INFO EVENT
250	250	*/
251		- $manipulateAvailability = function (array $serializedBookingInfo, $propertyName) {
	251	+ $manipulateAvailability = function(array $serializedBookingInfo, $propertyName) {
252	252	if (!isset($serializedBookingInfo[$propertyName]) \|\| empty($serializedBookingInfo[$propertyName])) {
253	253	$serializedBookingInfo[$propertyName] = null;
254	254	return $serializedBookingInfo;
		@@ -278,7 +278,7 @@ discard block
		block discarded – undo
278	278	return $serializedBookingInfo;
279	279	};
280	280
281		- $manipulateUrlLabel = function (array $serializedBookingInfo) {
	281	+ $manipulateUrlLabel = function(array $serializedBookingInfo) {
282	282	if (!isset($serializedBookingInfo['urlLabel'])) {
283	283	return $serializedBookingInfo;
284	284	}
		@@ -304,7 +304,7 @@ discard block
		block discarded – undo
304	304	return $serializedBookingInfo;
305	305	};
306	306
307		- $manipulateBookingInfoEvent = function (
	307	+ $manipulateBookingInfoEvent = function(
308	308	array $serializedEvent
309	309	) use (
310	310	$manipulateAvailability,
		@@ -349,7 +349,7 @@ discard block
		block discarded – undo
349	349	foreach ($refactoredEventEvents as $refactoredEventEvent) {
350	350	$payloadManipulatingSerializer->manipulateEventsOfClass(
351	351	$refactoredEventEvent,
352		- function (array $serializedObject) {
	352	+ function(array $serializedObject) {
353	353	$serializedObject = self::replaceEventIdWithItemId($serializedObject);
354	354	return $serializedObject;
355	355	}
		@@ -372,7 +372,7 @@ discard block
		block discarded – undo
372	372	foreach ($refactoredPlaceEvents as $refactoredPlaceEvent) {
373	373	$payloadManipulatingSerializer->manipulateEventsOfClass(
374	374	$refactoredPlaceEvent,
375		- function (array $serializedObject) {
	375	+ function(array $serializedObject) {
376	376	$serializedObject = self::replacePlaceIdWithItemId($serializedObject);
377	377	return $serializedObject;
378	378	}
		@@ -390,11 +390,11 @@ discard block
		block discarded – undo
390	390	foreach ($priceInfoEvents as $priceInfoEvent) {
391	391	$payloadManipulatingSerializer->manipulateEventsOfClass(
392	392	$priceInfoEvent,
393		- function (array $serializedObject) {
	393	+ function(array $serializedObject) {
394	394	$payload = &$serializedObject['payload'];
395	395	$priceInfo = &$payload['price_info'];
396	396	$tariffs = array_map(
397		- function (array $tariff) {
	397	+ function(array $tariff) {
398	398	$name = $tariff['name'];
399	399	if (is_string($name)) {
400	400	$name = ['nl' => $name];
		@@ -415,7 +415,7 @@ discard block
		block discarded – undo
415	415	*/
416	416	$payloadManipulatingSerializer->manipulateEventsOfClass(
417	417	'CultuurNet\UDB3\Role\Events\ConstraintCreated',
418		- function (array $serializedObject) {
	418	+ function(array $serializedObject) {
419	419	$serializedObject['class'] = ConstraintAdded::class;
420	420	return self::addDefaultSapiVersion($serializedObject);
421	421	}
		@@ -423,14 +423,14 @@ discard block
		block discarded – undo
423	423
424	424	$payloadManipulatingSerializer->manipulateEventsOfClass(
425	425	ConstraintUpdated::class,
426		- function (array $serializedObject) {
	426	+ function(array $serializedObject) {
427	427	return self::addDefaultSapiVersion($serializedObject);
428	428	}
429	429	);
430	430
431	431	$payloadManipulatingSerializer->manipulateEventsOfClass(
432	432	ConstraintRemoved::class,
433		- function (array $serializedObject) {
	433	+ function(array $serializedObject) {
434	434	return self::addDefaultSapiVersion($serializedObject);
435	435	}
436	436	);

cultuurnet / udb3-php

Push — master ( 70b047...5c79cc )

Status

Category

Spacing +28 added lines, -28 removed lines patch added patch discarded remove patch