Completed
Pull Request — master (#277)
by Kristof
09:06
created
src/Offer/ReadModel/History/OfferHistoryProjector.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
     }
173 173
 
174 174
     /**
175
-     * @param $dateString
175
+     * @param string $dateString
176 176
      * @return \DateTime
177 177
      */
178 178
     protected function dateFromUdb2DateString($dateString)
@@ -186,7 +186,7 @@  discard block
 block discarded – undo
186 186
 
187 187
     /**
188 188
      * @param Metadata $metadata
189
-     * @return String|null
189
+     * @return StringLiteral|null
190 190
      */
191 191
     protected function getAuthorFromMetadata(Metadata $metadata)
192 192
     {
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
 
200 200
     /**
201 201
      * @param Metadata $metadata
202
-     * @return String|null
202
+     * @return StringLiteral|null
203 203
      */
204 204
     protected function getConsumerFromMetadata(Metadata $metadata)
205 205
     {
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
 
228 228
     /**
229 229
      * @param string $eventId
230
-     * @param Log[]|Log $logs
230
+     * @param Log $logs
231 231
      */
232 232
     protected function writeHistory($eventId, $logs)
233 233
     {
Please login to merge, or discard this patch.
src/SavedSearches/FixedSavedSearchRepository.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     protected $user;
17 17
 
18 18
     /**
19
-     * @param StringLiteral $userId
19
+     * @param StringLiteral $user
20 20
      */
21 21
     public function __construct(\CultureFeed_User $user)
22 22
     {
Please login to merge, or discard this patch.
src/SavedSearches/Properties/CreatedByQueryString.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,6 @@
 block discarded – undo
12 12
     protected $emailAddress;
13 13
 
14 14
     /**
15
-     * @param StringLiteral $userId
16 15
      */
17 16
     public function __construct(EmailAddress $emailAddress)
18 17
     {
Please login to merge, or discard this patch.
src/UiTID/CdbXmlCreatedByToUserIdResolver.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
 
65 65
     /**
66 66
      * @param StringLiteral $createdByIdentifier
67
-     * @return String
67
+     * @return StringLiteral|null
68 68
      */
69 69
     private function resolveByEmailOrByNick(StringLiteral $createdByIdentifier)
70 70
     {
Please login to merge, or discard this patch.
src/Variations/Command/CreateOfferVariationJSONDeserializer.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Variations\Command;
4 4
 
5 5
 use CultuurNet\Deserializer\JSONDeserializer;
6
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactory;
7
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
8 6
 use CultuurNet\UDB3\Variations\Model\Properties\Description;
9 7
 use CultuurNet\UDB3\Variations\Model\Properties\OwnerId;
10 8
 use CultuurNet\UDB3\Variations\Model\Properties\Purpose;
Please login to merge, or discard this patch.
src/SavedSearches/UiTIDSavedSearchRepository.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
     {
77 77
         $name = new StringLiteral($savedSearch->name);
78 78
         $query = QueryString::fromURLQueryString($savedSearch->query);
79
-        $id = new StringLiteral((string) $savedSearch->id);
79
+        $id = new StringLiteral((string)$savedSearch->id);
80 80
 
81 81
         return new SavedSearch($name, $query, $id);
82 82
     }
@@ -86,8 +86,8 @@  discard block
 block discarded – undo
86 86
      */
87 87
     public function write(StringLiteral $userId, StringLiteral $name, QueryString $queryString)
88 88
     {
89
-        $userId = (string) $userId;
90
-        $name = (string) $name;
89
+        $userId = (string)$userId;
90
+        $name = (string)$name;
91 91
         $query = $queryString->toURLQueryString();
92 92
 
93 93
         $savedSearch = new \CultureFeed_SavedSearches_SavedSearch(
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
                         'error' => $exception->getMessage(),
108 108
                         'userId' => $userId,
109 109
                         'name' => $name,
110
-                        'query' => (string) $queryString,
110
+                        'query' => (string)$queryString,
111 111
                     ]
112 112
                 );
113 113
             }
@@ -119,8 +119,8 @@  discard block
 block discarded – undo
119 119
      */
120 120
     public function delete(StringLiteral $userId, StringLiteral $searchId)
121 121
     {
122
-        $userId = (string) $userId;
123
-        $searchId = (string) $searchId;
122
+        $userId = (string)$userId;
123
+        $searchId = (string)$searchId;
124 124
 
125 125
         try {
126 126
             $this->savedSearches->unsubscribe($searchId, $userId);
Please login to merge, or discard this patch.