SortedArrayHashMap::removeAt() - Code Metrics - Inspection of "removed the old collections component" - cubiche/collections - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d6f0bd...41a21b )

by Ivannis Suárez

created 2016-06-06 14:48 UTC

SortedArrayHashMap::removeAt() A

↳ Parent: SortedArrayHashMap

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
rs	9.6666
cc	2
eloc	5
nc	2
nop	1

<?php
/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Collections\ArrayCollection;

use Cubiche\Core\Comparable\Comparator;
use Cubiche\Core\Comparable\ComparatorInterface;

/**
 * SortedArrayHashMap Class.
 *
 * @author Karel Osorio Ramírez <[email protected]>
 * @author Ivannis Suárez Jerez <[email protected]>
 */
class SortedArrayHashMap extends ArrayHashMap
{
    /**
     * @var ComparatorInterface
     */
    protected $criteria;

    /**
     * SortedArrayHashMap constructor.
     *
     * @param array                    $elements
     * @param ComparatorInterface|null $criteria
     */
    public function __construct(array $elements = array(), ComparatorInterface $criteria = null)
    {
        if ($criteria === null) {
            $criteria = new Comparator();
        }

        $this->criteria = $criteria;
        foreach ($elements as $key => $element) {
            parent::set($key, $element);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
        }

        $this->sort();
    }

    /**
     * {@inheritdoc}
     */
    public function set($key, $value)
    {
        parent::set($key, $value);

        $this->sort();
    }

    /**
     * {@inheritdoc}
     */
    public function removeAt($key)
    {
        $removed = parent::removeAt($key);
        if ($removed !== null) {
            $this->sort();
        }

        return $removed;
    }

    /**
     * {@inheritdoc}
     */
    public function sort(ComparatorInterface $criteria = null)
    {
        if ($criteria !== null) {
            $this->criteria = $criteria;
        }

        parent::sort($this->criteria);
    }
}


1			<?php
2			/**
3			* This file is part of the Cubiche package.
4			*
5			* Copyright (c) Cubiche
6			*
7			* For the full copyright and license information, please view the LICENSE
8			* file that was distributed with this source code.
9			*/
10			namespace Cubiche\Core\Collections\ArrayCollection;
11
12			use Cubiche\Core\Comparable\Comparator;
13			use Cubiche\Core\Comparable\ComparatorInterface;
14
15			/**
16			* SortedArrayHashMap Class.
17			*
18			* @author Karel Osorio Ramírez <[email protected]>
19			* @author Ivannis Suárez Jerez <[email protected]>
20			*/
21			class SortedArrayHashMap extends ArrayHashMap
22			{
23			/**
24			* @var ComparatorInterface
25			*/
26			protected $criteria;
27
28			/**
29			* SortedArrayHashMap constructor.
30			*
31			* @param array $elements
32			* @param ComparatorInterface\|null $criteria
33			*/
34			public function __construct(array $elements = array(), ComparatorInterface $criteria = null)
35			{
36			if ($criteria === null) {
37			$criteria = new Comparator();
38			}
39
40			$this->criteria = $criteria;
41			foreach ($elements as $key => $element) {
42			parent::set($key, $element);
			0 ignored issues – show Comprehensibility Bug introduced 2016-06-06 14:54 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`set()` instead of `__construct()`). Are you sure this is correct? If so, you might want to change this to `$this->set()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
43			}
44
45			$this->sort();
46			}
47
48			/**
49			* {@inheritdoc}
50			*/
51			public function set($key, $value)
52			{
53			parent::set($key, $value);
54
55			$this->sort();
56			}
57
58			/**
59			* {@inheritdoc}
60			*/
61			public function removeAt($key)
62			{
63			$removed = parent::removeAt($key);
64			if ($removed !== null) {
65			$this->sort();
66			}
67
68			return $removed;
69			}
70
71			/**
72			* {@inheritdoc}
73			*/
74			public function sort(ComparatorInterface $criteria = null)
75			{
76			if ($criteria !== null) {
77			$this->criteria = $criteria;
78			}
79
80			parent::sort($this->criteria);
81			}
82			}
83

cubiche / collections

Push — master ( d6f0bd...41a21b )

SortedArrayHashMap::removeAt() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like