Cubiche\Core\Collections\ArrayCollection\SortedArrayHashMap

Complexity

Total Complexity

8

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	13	3
A	set()	0	6	1
A	removeAt()	0	9	2
A	sort()	0	8	2

<?php
/**
 * This file is part of the Cubiche package.
 *
 * Copyright (c) Cubiche
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
namespace Cubiche\Core\Collections\ArrayCollection;

use Cubiche\Core\Comparable\Comparator;
use Cubiche\Core\Comparable\ComparatorInterface;

/**
 * SortedArrayHashMap Class.
 *
 * @author Karel Osorio Ramírez <osorioramirez@gmail.com>
 * @author Ivannis Suárez Jerez <ivannis.suarez@gmail.com>
 */
class SortedArrayHashMap extends ArrayHashMap
{
    /**
     * @var ComparatorInterface
     */
    protected $criteria;

    /**
     * SortedArrayHashMap constructor.
     *
     * @param array                    $elements
     * @param ComparatorInterface|null $criteria
     */
    public function __construct(array $elements = array(), ComparatorInterface $criteria = null)
    {
        if ($criteria === null) {
            $criteria = new Comparator();
        }

        $this->criteria = $criteria;
        foreach ($elements as $key => $element) {
            parent::set($key, $element);

It seems like you call parent on a different method (set() instead of __construct()). Are you sure this is correct? If so, you might want to change this to $this->set().

        }

        $this->sort();
    }

    /**
     * {@inheritdoc}
     */
    public function set($key, $value)
    {
        parent::set($key, $value);

        $this->sort();
    }

    /**
     * {@inheritdoc}
     */
    public function removeAt($key)
    {
        $removed = parent::removeAt($key);
        if ($removed !== null) {
            $this->sort();
        }

        return $removed;
    }

    /**
     * {@inheritdoc}
     */
    public function sort(ComparatorInterface $criteria = null)
    {
        if ($criteria !== null) {
            $this->criteria = $criteria;
        }

        parent::sort($this->criteria);
    }
}