cubiche / async

Promise/RejectedPromise.php

Doc Comments -1 removed lines

@@ -24,7 +24,6 @@
     protected $reason;
 
     /**
-     * @param mixed $value
      */
     public function __construct($reason = null)
     {

Tests/Units/TestCase.php

Doc Comments +3 added lines, -4 removed lines

@@ -31,8 +31,8 @@ 
      * @param Extractor $annotationExtractor
      * @param Generator $asserterGenerator
      * @param Manager   $assertionManager
-     * @param Closure   $reflectionClassFactory
-     * @param Closure   $phpExtensionFactory
+     * @param \Closure   $reflectionClassFactory
+     * @param \Closure   $phpExtensionFactory
      * @param Analyzer  $analyzer
      */
     public function __construct(
@@ -85,7 +85,7 @@ 
     }
 
     /**
-     * @param mixed $return
+     * @param string $return
      *
      * @return \Cubiche\Core\Delegate\Delegate
      */
@@ -95,7 +95,6 @@ 
     }
 
     /**
-     * @param mixed $return
      *
      * @return \Cubiche\Core\Delegate\Delegate
      */

Spacing +3 added lines, -3 removed lines

@@ -56,7 +56,7 @@ 
 
         $this
             ->getAssertionManager()
-                ->setHandler('delegateCall', function (MockAggregator $mock) {
+                ->setHandler('delegateCall', function(MockAggregator $mock) {
                     return $this->delegateCall($mock);
                 })
         ;
@@ -79,7 +79,7 @@ 
      */
     protected function delegateMock($return = null)
     {
-        return $this->callableMock(function ($value = null) use ($return) {
+        return $this->callableMock(function($value = null) use ($return) {
             return $return === null ? $value : $return;
         });
     }
@@ -101,7 +101,7 @@ 
      */
     protected function delegateMockWithException(\Exception $e)
     {
-        return $this->callableMock(function () use ($e) {
+        return $this->callableMock(function() use ($e) {
             throw $e;
         });
     }

Promise/Promises.php

Spacing +8 added lines, -8 removed lines

@@ -77,7 +77,7 @@ 
         /** @var \Cubiche\Core\Async\Promise\PromiseInterface $promise */
         foreach ($promises as $key => $promise) {
             $promise->then(
-                function ($value) use ($deferred, &$results, $map, $key, &$pending) {
+                function($value) use ($deferred, &$results, $map, $key, &$pending) {
                     if ($map !== null) {
                         $value = $map($value);
                     }
@@ -87,7 +87,7 @@ 
                         $deferred->resolve($results);
                     }
                 },
-                function ($reason) use ($deferred) {
+                function($reason) use ($deferred) {
                     $deferred->reject($reason);
                 }
             );
@@ -106,14 +106,14 @@ 
     public static function timeout(PromiseInterface $promise, $time, LoopInterface $loop)
     {
         $deferred = self::defer();
-        $timer = $loop->timeout(function () use ($promise, $deferred, $time) {
+        $timer = $loop->timeout(function() use ($promise, $deferred, $time) {
             $deferred->reject(new TimeoutException($time));
         }, $time);
 
-        $promise->then(function ($value = null) use ($deferred, $timer) {
+        $promise->then(function($value = null) use ($deferred, $timer) {
             $timer->cancel();
             $deferred->resolve($value);
-        }, function ($reason = null) use ($deferred, $timer) {
+        }, function($reason = null) use ($deferred, $timer) {
             $timer->cancel();
             $deferred->reject($reason);
         });
@@ -138,11 +138,11 @@ 
             $promise = self::timeout($promise, $timeout, $loop);
         }
 
-        $promise->then(function ($value = null) use (&$result) {
+        $promise->then(function($value = null) use (&$result) {
             $result = $value;
-        }, function ($reason = null) use (&$rejectionReason) {
+        }, function($reason = null) use (&$rejectionReason) {
             $rejectionReason = $reason;
-        })->always(function () use ($loop) {
+        })->always(function() use ($loop) {
             $loop->stop();
         });
 

Promise/Promise.php

Spacing +3 added lines, -3 removed lines

@@ -35,13 +35,13 @@
     ) {
         $this->deferred = new PromiseDeferred();
 
-        $exportResolve(function ($value = null) {
+        $exportResolve(function($value = null) {
             return $this->resolve($value);
         });
-        $exportReject(function ($reason = null) {
+        $exportReject(function($reason = null) {
             return $this->reject($reason);
         });
-        $exportNotify(function ($state = null) {
+        $exportNotify(function($state = null) {
             return $this->notify($state);
         });
     }

Promise/AbstractPromise.php

Spacing +2 added lines, -2 removed lines

@@ -31,11 +31,11 @@
      */
     public function always(callable $finally, callable $onNotify = null)
     {
-        return $this->then(function ($value) use ($finally) {
+        return $this->then(function($value) use ($finally) {
             $finally($value, null);
 
             return $value;
-        }, function ($reason) use ($finally) {
+        }, function($reason) use ($finally) {
             $finally(null, $reason);
         }, $onNotify);
     }

Promise/Deferred.php

Spacing +3 added lines, -3 removed lines

@@ -55,13 +55,13 @@
     {
         if ($this->promise === null) {
             $this->promise = new Promise(
-                new Delegate(function (callable $callable) {
+                new Delegate(function(callable $callable) {
                     $this->resolveDelegate = new Delegate($callable);
                 }),
-                new Delegate(function (callable $callable) {
+                new Delegate(function(callable $callable) {
                     $this->rejectDelegate = new Delegate($callable);
                 }),
-                new Delegate(function (callable $callable) {
+                new Delegate(function(callable $callable) {
                     $this->notifyDelegate = new Delegate($callable);
                 })
             );

Tests/Units/Promise/CallablePromisorTests.php

Spacing +4 added lines, -4 removed lines

@@ -22,7 +22,7 @@ 
      */
     protected function defaultConstructorArguments()
     {
-        return array(function () {
+        return array(function() {
             return 'foo';
         });
     }
@@ -38,7 +38,7 @@ 
                 $promisor = $this->newDefaultTestedInstance(),
                 $onFulfilled = $this->delegateMock()
             )
-            ->when(function () use ($promisor, $onFulfilled) {
+            ->when(function() use ($promisor, $onFulfilled) {
                 $promisor();
                 $promisor->promise()->then($onFulfilled);
             })
@@ -52,12 +52,12 @@ 
             ->given(
                 $reason = new \Exception(),
                 /** @var \Cubiche\Core\Async\Promise\CallablePromisor $promisor */
-                $promisor = $this->newTestedInstance(function () use ($reason) {
+                $promisor = $this->newTestedInstance(function() use ($reason) {
                     throw $reason;
                 }),
                 $onRejected = $this->delegateMock()
             )
-            ->when(function () use ($promisor, $onRejected) {
+            ->when(function() use ($promisor, $onRejected) {
                 $promisor();
                 $promisor->promise()->then(null, $onRejected);
             })

Tests/Units/Promise/DeferredInterfaceTestCase.php

Indentation +1 added lines, -1 removed lines

@@ -103,7 +103,7 @@
             ->then()
                 ->delegateCall($onRejected)
                     ->withArguments($reason)
-                     ->once()
+                        ->once()
         ;
 
         $this->invalidActionTest($deferred);

Spacing +4 added lines, -4 removed lines

@@ -120,7 +120,7 @@ 
                 $deferred = $this->newDefaultTestedInstance(),
                 $onNotify = $this->delegateMock()
             )
-            ->when(function () use ($deferred, $onNotify) {
+            ->when(function() use ($deferred, $onNotify) {
                 $deferred->promise()->then(null, null, $onNotify);
                 $deferred->notify('foo');
             })
@@ -138,15 +138,15 @@ 
     {
         $this
             ->given($deferred)
-            ->exception(function () use ($deferred) {
+            ->exception(function() use ($deferred) {
                 $deferred->resolve();
             })
                 ->isInstanceOf(\LogicException::class)
-            ->exception(function () use ($deferred) {
+            ->exception(function() use ($deferred) {
                 $deferred->reject();
             })
                 ->isInstanceOf(\LogicException::class)
-            ->exception(function () use ($deferred) {
+            ->exception(function() use ($deferred) {
                 $deferred->notify();
             })
                 ->isInstanceOf(\LogicException::class)

Tests/Units/Promise/PromiseTests.php

Spacing +4 added lines, -4 removed lines

@@ -43,13 +43,13 @@ 
     protected function defaultConstructorArguments()
     {
         return array(
-            function (callable $callable) {
+            function(callable $callable) {
                 $this->resolve = new Delegate($callable);
             },
-            function (callable $callable) {
+            function(callable $callable) {
                 $this->reject = new Delegate($callable);
             },
-            function (callable $callable) {
+            function(callable $callable) {
                 $this->notify = new Delegate($callable);
             },
         );
@@ -119,7 +119,7 @@ 
                 $promise = $this->newDefaultTestedInstance(),
                 $onNotify = $this->delegateMock()
             )
-            ->when(function () use ($promise, $onNotify) {
+            ->when(function() use ($promise, $onNotify) {
                 $promise->then(null, null, $onNotify);
                 $this->notify('foo');
             })