Completed
Push — develop ( 981d0d...cdcdf2 )
by Carlo
9s
created
magefix/src/Magefix/Plugin/DriverSwitcher.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
         if ($iFrame instanceof Element) {
34 34
             $reflectedElement = new \ReflectionClass($iFrame);
35 35
             if ($reflectedElement->hasMethod('getCssId') === false) {
36
-                throw new \ReflectionException("getCssId method not in Element " . get_class($iFrame));
36
+                throw new \ReflectionException("getCssId method not in Element ".get_class($iFrame));
37 37
             }
38 38
             $iFrameId = $iFrame->getCssId();
39 39
             $this->getDriver()->switchToIFrame($iFrameId);
Please login to merge, or discard this patch.
magefix/src/Magefix/Plugin/Spinner.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -13,9 +13,9 @@  discard block
 block discarded – undo
13 13
 trait Spinner
14 14
 {
15 15
     /**
16
-     * @param $lambda
16
+     * @param \Closure $lambda
17 17
      * @param int $wait
18
-     * @return bool
18
+     * @return boolean|null
19 19
      * @throws \Exception
20 20
      */
21 21
     public function spin($lambda, $wait = 60)
@@ -119,7 +119,7 @@  discard block
 block discarded – undo
119 119
      * @param $context
120 120
      * @param $element
121 121
      * @param $action
122
-     * @param null $condition
122
+     * @param boolean|null $condition
123 123
      * @return bool
124 124
      */
125 125
     private function _spinnerAction($context, $element, $action, $condition = null)
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      */
44 44
     public function spinUntilVisible($element, $wait = 60)
45 45
     {
46
-        $this->spin(function ($context) use ($element) {
46
+        $this->spin(function($context) use ($element) {
47 47
             return $this->_spinnerAction($context, $element, 'isVisible', true);
48 48
         }, $wait);
49 49
     }
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      */
57 57
     public function spinUntilInvisible($element, $wait = 60)
58 58
     {
59
-        $this->spin(function ($context) use ($element) {
59
+        $this->spin(function($context) use ($element) {
60 60
             return $this->_spinnerAction($context, $element, 'isVisible', false);
61 61
         }, $wait);
62 62
     }
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
      */
70 70
     public function spinAndClick($element, $wait = 60)
71 71
     {
72
-        $this->spin(function ($context) use ($element) {
72
+        $this->spin(function($context) use ($element) {
73 73
             return $this->_spinnerAction($context, $element, 'click');
74 74
         }, $wait);
75 75
     }
@@ -82,7 +82,7 @@  discard block
 block discarded – undo
82 82
      */
83 83
     public function spinAndPress($element, $wait = 60)
84 84
     {
85
-        $this->spin(function ($context) use ($element) {
85
+        $this->spin(function($context) use ($element) {
86 86
             return $this->_spinnerAction($context, $element, 'press');
87 87
         }, $wait);
88 88
     }
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
      */
98 98
     public function spinAndDo($element, $action, $condition = null, $wait = 60)
99 99
     {
100
-        $this->spin(function ($context) use ($element, $action, $condition) {
100
+        $this->spin(function($context) use ($element, $action, $condition) {
101 101
             return $this->_spinnerAction($context, $element, $action, $condition);
102 102
         }, $wait);
103 103
     }
@@ -110,8 +110,8 @@  discard block
 block discarded – undo
110 110
         $backtrace = debug_backtrace();
111 111
 
112 112
         throw new \Exception(
113
-            "Timeout thrown by " . $backtrace[1]['class'] . "::" . $backtrace[1]['function'] . "()\n" .
114
-            $backtrace[1]['file'] . ", line " . $backtrace[1]['line']
113
+            "Timeout thrown by ".$backtrace[1]['class']."::".$backtrace[1]['function']."()\n".
114
+            $backtrace[1]['file'].", line ".$backtrace[1]['line']
115 115
         );
116 116
     }
117 117
 
Please login to merge, or discard this patch.