cryocaustik / seat-hr

rector.php

Spacing +2 added lines, -2 removed lines

@@ -8,9 +8,9 @@
 use Rector\Set\ValueObject\SetList;
 use RectorLaravel\Set\LaravelSetList;
 
-return static function (RectorConfig $rectorConfig): void {
+return static function(RectorConfig $rectorConfig): void {
     $rectorConfig->paths([
-        __DIR__ . '/src',
+        __DIR__.'/src',
     ]);
 
     // register a single rule

src/models/SeatHrCorporation.php

Spacing +2 added lines, -2 removed lines

@@ -37,7 +37,7 @@ 
     public function getCanReapplyAttribute($query)
     {
         // if corporation does not have any applications, allow user to apply without further verif
-        if($this->applications()->count() < 1) {
+        if ($this->applications()->count() < 1) {
             return true;
         }
         // get user's profile id and check if their last (based on created_at) app allows re-apply
@@ -45,7 +45,7 @@ 
         $applications = $this->applications()->where('profile_id', $profile_id)->latest('created_at');
 
         // if user does not have any applications, return true
-        if($applications->count() < 1) {
+        if ($applications->count() < 1) {
             return true;
         }
 

src/models/SeatHrProfile.php

Spacing +1 added lines, -1 removed lines

@@ -6,7 +6,7 @@
 
 class SeatHrProfile extends Model
 {
-    protected $fillable = [ 'user_id', 'probation'];
+    protected $fillable = ['user_id', 'probation'];
     protected $casts = [
         'probation' => 'boolean',
     ];

src/routes/web.php

Spacing +17 added lines, -17 removed lines

@@ -17,7 +17,7 @@ 
     Route::group([
         'namespace' => 'user',
         'prefix' => 'user',
-    ], function (): void {
+    ], function(): void {
         Route::get('/{character?}', [
             'uses' => 'UserController@index',
             'as' => 'seat-hr.profile',
@@ -37,7 +37,7 @@ 
 
         Route::group([
             'prefix' => '/{character}/applications',
-        ], function (): void {
+        ], function(): void {
 
             // TODO: fix middleware permissions to use seat-hr permissions
             Route::get('/', [
@@ -46,7 +46,7 @@ 
                 'middleware' => 'can:character.sheet,character',
             ]);
 
-            Route::match([ 'get', 'post' ], '/apply/{corporation?}', [
+            Route::match(['get', 'post'], '/apply/{corporation?}', [
                 'uses' => 'ApplicationController@apply',
                 'as' => 'seat-hr.profile.applications.apply',
                 'middleware' => 'can:character.sheet,character',
@@ -64,7 +64,7 @@ 
         Route::group([
             'prefix' => '/{character}/blacklist',
             'middleware' => 'can:seat-hr.officer',
-        ], function (): void{
+        ], function(): void{
             Route::get('/', [
                 'uses' => 'BlackListController@index',
                 'as' => 'seat-hr.profile.blacklist',
@@ -89,7 +89,7 @@ 
         Route::group([
             'prefix' => '/{character}/kickhistory',
             'middleware' => 'can:seat-hr.officer',
-        ], function (): void{
+        ], function(): void{
             Route::get('/', [
                 'uses' => 'KickHistoryController@index',
                 'as' => 'seat-hr.profile.kickhistory',
@@ -114,7 +114,7 @@ 
         Route::group([
             'prefix' => '/{character}/notes',
             'middleware' => 'can:seat-hr.officer',
-        ], function (): void{
+        ], function(): void{
             Route::get('/', [
                 'uses' => 'NoteController@index',
                 'as' => 'seat-hr.profile.note',
@@ -142,7 +142,7 @@ 
         'namespace' => 'review',
         'prefix' => '/review',
         'middleware' => 'can:seat-hr.officer',
-    ], function (): void {
+    ], function(): void {
         Route::get('/', [
             'uses' => 'ReviewController@index',
             'as' => 'seat-hr.review.index'
@@ -164,7 +164,7 @@ 
 
             Route::group([
                 'prefix' => '/applications/{application}',
-            ], function (): void {
+            ], function(): void {
                 Route::match(['get', 'post'], '/review', [
                     'uses' => 'ReviewController@application_review',
                     'as' => 'seat-hr.review.application.review',
@@ -204,28 +204,28 @@ 
         'namespace' => 'configuration',
         'prefix' => 'config',
         'middleware' => 'can:seat-hr.admin',
-    ], function (): void {
+    ], function(): void {
 
         Route::group([
             'prefix' => 'corp',
-        ], function (): void {
+        ], function(): void {
 
             Route::get('/', [
                 'uses' => 'CorporationController@view',
                 'as' => 'seat-hr.config.corp.view',
             ]);
 
-            Route::match([ 'get', 'post' ], '/create', [
+            Route::match(['get', 'post'], '/create', [
                 'uses' => 'CorporationController@create',
                 'as' => 'seat-hr.config.corp.create',
             ]);
 
-            Route::match([ 'get', 'post' ], '/edit/{id}', [
+            Route::match(['get', 'post'], '/edit/{id}', [
                 'uses' => 'CorporationController@edit',
                 'as' => 'seat-hr.config.corp.edit',
             ]);
 
-            Route::match([ 'get', 'post' ], '/delete/{id}', [
+            Route::match(['get', 'post'], '/delete/{id}', [
                 'uses' => 'CorporationController@delete',
                 'as' => 'seat-hr.config.corp.delete',
             ]);
@@ -234,19 +234,19 @@ 
 
         Route::group([
             'prefix' => 'question',
-        ], function (): void {
+        ], function(): void {
 
             Route::get('/', [
                 'uses' => 'QuestionController@view',
                 'as' => 'seat-hr.config.question.view',
             ]);
 
-            Route::match([ 'get', 'post' ], '/create', [
+            Route::match(['get', 'post'], '/create', [
                 'uses' => 'QuestionController@create',
                 'as' => 'seat-hr.config.question.create',
             ]);
 
-            Route::match([ 'get', 'post' ], '/edit/{id}', [
+            Route::match(['get', 'post'], '/edit/{id}', [
                 'uses' => 'QuestionController@edit',
                 'as' => 'seat-hr.config.question.edit',
             ]);
@@ -260,7 +260,7 @@ 
 
         Route::group([
             'prefix' => 'corporation-question',
-        ], function (): void {
+        ], function(): void {
             Route::get('/{id}', [
                 'uses' => 'CorporationQuestionController@view',
                 'as' => 'seat-hr.config.corporation-question.view',

src/http/controllers/configuration/QuestionController.php

Spacing +1 added lines, -1 removed lines

@@ -64,7 +64,7 @@
             }
 
             $question->fill($data);
-            if(!$question->isDirty())
+            if (!$question->isDirty())
             {
                 return redirect()->route('seat-hr.config.question.view')
                     ->with('info', 'No changes found; question not updated.');

src/http/controllers/configuration/CorporationController.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
             }
 
             $corporation->fill($data);
-            if(!$corporation->isDirty()){
+            if (!$corporation->isDirty()) {
                 return redirect()->route('seat-hr.config.corp.view')
                     ->with('info', 'No changes found; corporation not updated.');
             }

src/http/controllers/review/ReviewController.php

Spacing +5 added lines, -5 removed lines

@@ -34,7 +34,7 @@ 
 
     public function application_review(SeatHrCorporation $corporation, SeatHrApplication $application)
     {
-        if($application->currentStatus->status_id === 2) {
+        if ($application->currentStatus->status_id === 2) {
             return redirect()->back()->withErrors('Application is already in review.');
         }
         $application->status()->update(['active' => false]);
@@ -50,7 +50,7 @@ 
 
     public function application_approve(SeatHrCorporation $corporation, SeatHrApplication $application)
     {
-        if($application->currentStatus->status_id === 3) {
+        if ($application->currentStatus->status_id === 3) {
             return redirect()->back()->withErrors('Application is already approved.');
         }
         $application->status()->update(['active' => false]);
@@ -66,7 +66,7 @@ 
 
     public function application_cancel(SeatHrCorporation $corporation, SeatHrApplication $application)
     {
-        if($application->currentStatus->status_id === 4) {
+        if ($application->currentStatus->status_id === 4) {
             return redirect()->back()->withErrors('Application is already cancelled.');
         }
         $application->status()->update(['active' => false]);
@@ -82,7 +82,7 @@ 
 
     public function application_reject(SeatHrCorporation $corporation, SeatHrApplication $application)
     {
-        if($application->currentStatus->status_id === 5) {
+        if ($application->currentStatus->status_id === 5) {
             return redirect()->back()->withErrors('Application is already rejected.');
         }
         $application->status()->update(['active' => false]);
@@ -98,7 +98,7 @@ 
 
     public function application_toggle_reapply(SeatHrCorporation $corporation, SeatHrApplication $application)
     {
-        if($application->currentStatus->status_id < 3) {
+        if ($application->currentStatus->status_id < 3) {
             return redirect()->back()->withErrors('Application needs to have a decision before allowing to re-apply.');
         }
 

src/http/controllers/user/ApplicationController.php

Spacing +9 added lines, -9 removed lines

@@ -26,15 +26,15 @@ 
 
     public function apply(Request $request, CharacterInfo $character, SeatHrCorporation $corporation = null) {
         // POST, process submitted application
-        if($request->isMethod('POST')) {
-            if(!$corporation instanceof \Cryocaustik\SeatHr\models\SeatHrCorporation) {
+        if ($request->isMethod('POST')) {
+            if (!$corporation instanceof \Cryocaustik\SeatHr\models\SeatHrCorporation) {
                 return redirect()->back()->withErrors('Invalid or missing corporation Id');
             }
 
             $available_questions = $corporation->questions()->active()->get();
             // because validator will literally reindex and overwrite your object keys if you use integers!!!
             $question_ids = array_map(
-                fn($v): string => 'id-' . $v,
+                fn($v): string => 'id-'.$v,
                 $available_questions->pluck('question_id')->toArray()
             );
 
@@ -42,15 +42,15 @@ 
             $rules = [];
             $attributes = [];
 
-            foreach($available_questions as $q) {
-                $id = 'id-'. $q->question_id;
+            foreach ($available_questions as $q) {
+                $id = 'id-'.$q->question_id;
                 $type = $q->question->type;
 
                 // validator does not have rules for type text
-                if($type == 'text'){ $type = 'string'; }
+                if ($type == 'text') { $type = 'string'; }
 
                 // validator does not have a rule for datetime specifically
-                if($type == 'datetime') { $type = 'date'; }
+                if ($type == 'datetime') { $type = 'date'; }
 
                 $rules[$id] = ['required', $type];
                 $attributes[$id] = $q->question->name;
@@ -61,7 +61,7 @@ 
                 return back()->withErrors($validator->errors());
             }
 
-            $profile = SeatHrProfile::firstOrCreate([ 'user_id' => $character->user->id ]);
+            $profile = SeatHrProfile::firstOrCreate(['user_id' => $character->user->id]);
             $application = SeatHrApplication::create([
                 'corporation_id' => $corporation->id,
                 'profile_id' => $profile->id,
@@ -83,7 +83,7 @@ 
         }
 
         // no corporation specified, return list of recruiting corps
-        if(!$corporation instanceof \Cryocaustik\SeatHr\models\SeatHrCorporation) {
+        if (!$corporation instanceof \Cryocaustik\SeatHr\models\SeatHrCorporation) {
             $recruiting_corps = SeatHrCorporation::recruiting()->get();
             return view('seat-hr::user.applications.apply', ['recruiting_corps' => $recruiting_corps]);
         }

src/http/controllers/user/KickHistoryController.php

Spacing +3 added lines, -3 removed lines

@@ -17,7 +17,7 @@ 
 
     public function create(Request $request, CharacterInfo $character)
     {
-        if($request->isMethod('post'))
+        if ($request->isMethod('post'))
         {
             $data = $request->only([
                 'kicked_by',
@@ -35,7 +35,7 @@ 
                 return back()->withErrors($validator->errors());
             }
 
-            $profile = SeatHrProfile::firstOrCreate([ 'user_id' => $character->user->id ]);
+            $profile = SeatHrProfile::firstOrCreate(['user_id' => $character->user->id]);
             $data['profile_id'] = $profile->id;
             $data['created_by'] = auth()->user()->id;
 
@@ -50,7 +50,7 @@ 
 
     public function edit(Request $request, CharacterInfo $character, SeatHrKickHistory $kickhistory)
     {
-        if($request->isMethod('post'))
+        if ($request->isMethod('post'))
         {
             $data = $request->only([
                 'kicked_by',