crossjoin / Browscap

src/Source/FileAbstract.php

Spacing +3 added lines, -3 removed lines

@@ -30,7 +30,7 @@ 
     {
         if (!is_string($file)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($file) . "' for argument 'file'."
+                "Invalid type '".gettype($file)."' for argument 'file'."
             );
         }
 
@@ -55,7 +55,7 @@ 
     {
         if (!is_string($file)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($file) . "' for argument 'file'."
+                "Invalid type '".gettype($file)."' for argument 'file'."
             );
         }
 
@@ -79,7 +79,7 @@ 
     {
         if (!is_string($file)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($file) . "' for argument 'file'."
+                "Invalid type '".gettype($file)."' for argument 'file'."
             );
         }
 

src/Source/DataSet.php

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
     {
         if (!is_string($pattern)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($pattern) . "' for argument 'pattern'."
+                "Invalid type '".gettype($pattern)."' for argument 'pattern'."
             );
         }
 
@@ -57,7 +57,7 @@ 
     {
         if (!is_string($pattern)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($pattern) . "' for argument 'pattern'."
+                "Invalid type '".gettype($pattern)."' for argument 'pattern'."
             );
         }
 
@@ -100,12 +100,12 @@ 
     {
         if (!is_string($key)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($key) . "' for argument 'key'."
+                "Invalid type '".gettype($key)."' for argument 'key'."
             );
         }
         if (!is_string($value)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($value) . "' for argument 'value'."
+                "Invalid type '".gettype($value)."' for argument 'value'."
             );
         }
 

src/Source/DownloadAbstract.php

Spacing +3 added lines, -3 removed lines

@@ -48,7 +48,7 @@ 
     {
         if (!is_string($sourceUri)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($sourceUri) . "' for argument 'sourceUri'."
+                "Invalid type '".gettype($sourceUri)."' for argument 'sourceUri'."
             );
         }
         
@@ -96,7 +96,7 @@ 
     {
         if (!is_string($sourceUri)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($sourceUri) . "' for argument 'sourceUri'."
+                "Invalid type '".gettype($sourceUri)."' for argument 'sourceUri'."
             );
         }
 
@@ -150,7 +150,7 @@ 
             // Check status code
             if ($response->getStatusCode() !== 200) {
                 throw new SourceUnavailableException(
-                    'HTTP error: ' . $response->getStatusCode() . ' ' . $response->getReasonPhrase(),
+                    'HTTP error: '.$response->getStatusCode().' '.$response->getReasonPhrase(),
                     1459162268
                 );
             }

src/Source/SourceFactory.php

Spacing +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
                 self::$sourceClasses = $rememberClasses;
 
                 throw new InvalidArgumentException(
-                    "A value in the class name array is of type '" . gettype($className) . "'. String expected."
+                    "A value in the class name array is of type '".gettype($className)."'. String expected."
                 );
             }
         }
@@ -73,7 +73,7 @@ 
     {
         if (!is_string($className)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($className) . "' for argument 'className'."
+                "Invalid type '".gettype($className)."' for argument 'className'."
             );
         }
 

src/Source/Ini/BrowscapOrg.php

Spacing +5 added lines, -5 removed lines

@@ -42,7 +42,7 @@ 
     {
         if (!is_int($type)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($type) . "' for argument 'type'."
+                "Invalid type '".gettype($type)."' for argument 'type'."
             );
         }
         
@@ -58,7 +58,7 @@ 
      */
     public function getReleaseTime()
     {
-        $stream = $this->loadContent(self::BASE_URI . '/version');
+        $stream = $this->loadContent(self::BASE_URI.'/version');
 
         if (!$stream->isReadable()) {
             throw new SourceUnavailableException('Source stream is not readable.', 1459162265);
@@ -75,7 +75,7 @@ 
      */
     public function getVersion()
     {
-        $stream = $this->loadContent(self::BASE_URI . '/version-number');
+        $stream = $this->loadContent(self::BASE_URI.'/version-number');
 
         if (!$stream->isReadable()) {
             throw new SourceUnavailableException('Source stream is not readable.', 1459162266);
@@ -94,7 +94,7 @@ 
     {
         if (!is_int($type)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($type) . "' for argument 'type'."
+                "Invalid type '".gettype($type)."' for argument 'type'."
             );
         }
         
@@ -113,7 +113,7 @@ 
         }
 
         $this->type = $type;
-        $this->setSourceUri(self::BASE_URI . '/stream?q=' . $sourceType);
+        $this->setSourceUri(self::BASE_URI.'/stream?q='.$sourceType);
     }
 
     /**

src/Source/Ini/GetRegExpForPatternTrait.php

Spacing +2 added lines, -2 removed lines

@@ -22,7 +22,7 @@ 
     {
         if (!is_string($pattern)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($pattern) . "' for argument 'pattern'."
+                "Invalid type '".gettype($pattern)."' for argument 'pattern'."
             );
         }
 
@@ -30,6 +30,6 @@ 
         $patternReplaced = preg_quote($patternReplaced, '/');
         $patternReplaced = str_replace(["\nA\n", "\nQ\n"], ['.*', '.'], $patternReplaced);
 
-        return '/^' . $patternReplaced . '$/';
+        return '/^'.$patternReplaced.'$/';
     }
 }

src/Parser/Sqlite/DataDirectoryTrait.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     {
         if (!is_string($dataDirectory)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($dataDirectory) . "' for argument 'dataDirectory'."
+                "Invalid type '".gettype($dataDirectory)."' for argument 'dataDirectory'."
             );
         }
 

src/Parser/Sqlite/DataVersionHashTrait.php

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
     {
         if (!is_string($dataVersionHash)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($dataVersionHash) . "' for argument 'dataVersionHash'."
+                "Invalid type '".gettype($dataVersionHash)."' for argument 'dataVersionHash'."
             );
         }
 

src/Parser/Sqlite/Writer.php

Spacing +21 added lines, -21 removed lines

@@ -86,7 +86,7 @@ 
     {
         if (!is_string($dataDirectory)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($dataDirectory) . "' for argument 'dataDirectory'."
+                "Invalid type '".gettype($dataDirectory)."' for argument 'dataDirectory'."
             );
         }
 
@@ -116,8 +116,8 @@ 
     protected function getTemporaryFileName()
     {
         if ($this->temporaryFileName === null) {
-            $this->temporaryFileName = $this->getDataDirectory() . DIRECTORY_SEPARATOR .
-                'browscap_' . microtime(true) . '.sqlite';
+            $this->temporaryFileName = $this->getDataDirectory().DIRECTORY_SEPARATOR.
+                'browscap_'.microtime(true).'.sqlite';
         }
 
         return $this->temporaryFileName;
@@ -190,28 +190,28 @@ 
 
         // Create tables
         $adapter->exec(
-            'CREATE TABLE IF NOT EXISTS info (version_id INTEGER PRIMARY KEY ASC, release_time INTEGER NOT NULL, ' .
+            'CREATE TABLE IF NOT EXISTS info (version_id INTEGER PRIMARY KEY ASC, release_time INTEGER NOT NULL, '.
             'type_id INTEGER NOT NULL, data_hash TEXT NOT NULL)'
         );
         $adapter->exec(
-            'CREATE TABLE IF NOT EXISTS browser (browser_id INTEGER PRIMARY KEY ASC, browser_parent_id INTEGER, ' .
+            'CREATE TABLE IF NOT EXISTS browser (browser_id INTEGER PRIMARY KEY ASC, browser_parent_id INTEGER, '.
             'browser_pattern TEXT NOT NULL)'
         );
         $adapter->exec(
-            'CREATE TABLE IF NOT EXISTS search (browser_id INTEGER PRIMARY KEY ASC, ' .
+            'CREATE TABLE IF NOT EXISTS search (browser_id INTEGER PRIMARY KEY ASC, '.
             'browser_pattern_length INTEGER NOT NULL, browser_pattern TEXT NOT NULL)'
         );
 
         $adapter->exec(
-            'CREATE TABLE IF NOT EXISTS browser_property (browser_property_id INTEGER PRIMARY KEY ASC, ' .
+            'CREATE TABLE IF NOT EXISTS browser_property (browser_property_id INTEGER PRIMARY KEY ASC, '.
             'browser_id INTEGER NOT NULL, property_key_id INTEGER NOT NULL, property_value_id INTEGER NOT NULL)'
         );
         $adapter->exec(
-            'CREATE TABLE IF NOT EXISTS browser_property_key (property_key_id INTEGER PRIMARY KEY ASC, ' .
+            'CREATE TABLE IF NOT EXISTS browser_property_key (property_key_id INTEGER PRIMARY KEY ASC, '.
             'property_key TEXT NOT NULL)'
         );
         $adapter->exec(
-            'CREATE TABLE IF NOT EXISTS browser_property_value (property_value_id INTEGER PRIMARY KEY ASC, ' .
+            'CREATE TABLE IF NOT EXISTS browser_property_value (property_value_id INTEGER PRIMARY KEY ASC, '.
             'property_value TEXT NOT NULL)'
         );
 
@@ -238,7 +238,7 @@ 
     {
         if (!is_string($tableName)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($tableName) . "' for argument 'tableName'."
+                "Invalid type '".gettype($tableName)."' for argument 'tableName'."
             );
         }
 
@@ -358,12 +358,12 @@ 
     {
         if (!is_string($pattern)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($pattern) . "' for argument 'pattern'."
+                "Invalid type '".gettype($pattern)."' for argument 'pattern'."
             );
         }
         if (!is_int($browserId)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($browserId) . "' for argument 'browserId'."
+                "Invalid type '".gettype($browserId)."' for argument 'browserId'."
             );
         }
 
@@ -386,7 +386,7 @@ 
                 $parentId = $this->parentPatterns[$properties['Parent']];
                 unset($properties['Parent']);
             } else {
-                throw new ParserRuntimeException("Parent '" . $properties['Parent'] . "' not found.");
+                throw new ParserRuntimeException("Parent '".$properties['Parent']."' not found.");
             }
         }
 
@@ -445,7 +445,7 @@ 
     {
         if (!is_string($pattern)) {
             throw new InvalidArgumentException(
-                "Invalid type '" . gettype($pattern) . "' for argument 'pattern'."
+                "Invalid type '".gettype($pattern)."' for argument 'pattern'."
             );
         }
 
@@ -509,15 +509,15 @@ 
             // Do NOT use "CREATE TABLE ... AS" here, because this would automatically add an extra id column,
             // which requires additional space
             $adapter->exec(
-                'CREATE TABLE IF NOT EXISTS "search_' . $keywordValue . '" ' .
-                '(browser_id INTEGER PRIMARY KEY ASC, browser_pattern_length INTEGER NOT NULL, ' .
+                'CREATE TABLE IF NOT EXISTS "search_'.$keywordValue.'" '.
+                '(browser_id INTEGER PRIMARY KEY ASC, browser_pattern_length INTEGER NOT NULL, '.
                 'browser_pattern TEXT NOT NULL)'
             );
             /** @noinspection DisconnectedForeachInstructionInspection */
             $adapter->beginTransaction();
             $adapter->exec(
-                'INSERT INTO "search_' . $keywordValue . '" ' .
-                'SELECT browser_id, browser_pattern_length, browser_pattern ' .
+                'INSERT INTO "search_'.$keywordValue.'" '.
+                'SELECT browser_id, browser_pattern_length, browser_pattern '.
                 "FROM search WHERE browser_pattern GLOB '*$keywordValue*'"
             );
             $adapter->exec("INSERT INTO keyword VALUES ($keywordId, '$keywordValue')");
@@ -526,7 +526,7 @@ 
             $adapter->commitTransaction();
 
             $adapter->exec(
-                'CREATE INDEX IF NOT EXISTS i_se' . $keywordId . '_brpale ON "search_' . $keywordValue .
+                'CREATE INDEX IF NOT EXISTS i_se'.$keywordId.'_brpale ON "search_'.$keywordValue.
                 '"(browser_pattern_length)'
             );
 
@@ -558,7 +558,7 @@ 
     protected function cleanUp()
     {
         $currentDatabaseFile = basename($this->getTemporaryFileName());
-        foreach (glob($this->getDataDirectory() . DIRECTORY_SEPARATOR . 'browscap_*.sqlite') as $file) {
+        foreach (glob($this->getDataDirectory().DIRECTORY_SEPARATOR.'browscap_*.sqlite') as $file) {
             if (basename($file) !== $currentDatabaseFile) {
                 @unlink($file);
             }
@@ -570,6 +570,6 @@ 
      */
     protected function getLinkPath()
     {
-        return $this->getDataDirectory() . DIRECTORY_SEPARATOR . Parser::LINK_FILENAME;
+        return $this->getDataDirectory().DIRECTORY_SEPARATOR.Parser::LINK_FILENAME;
     }
 }

Doc Comments +1 added lines, -1 removed lines

@@ -373,7 +373,7 @@
     /**
      * @param array $properties
      *
-     * @return int|null
+     * @return string|null
      * @throws InvalidArgumentException
      * @throws ParserRuntimeException
      */