Completed
Pull Request — develop (#329)
by Carsten
07:08
created
module/Applications/src/Applications/Entity/Application.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -404,7 +404,7 @@
 block discarded – undo
404 404
     /**
405 405
      * {@inheritDoc}
406 406
      * @see \Applications\Entity\ApplicationInterface::getSummary()
407
-     * @return Application
407
+     * @return string
408 408
      */
409 409
     public function getSummary()
410 410
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -446,7 +446,7 @@
 block discarded – undo
446 446
     public function getCv()
447 447
     {
448 448
         if (is_null($this->cv)) {
449
-            $this->cv= new Cv();
449
+            $this->cv = new Cv();
450 450
         }
451 451
         return $this->cv;
452 452
     }
Please login to merge, or discard this patch.
module/Applications/src/Applications/Options/ModuleOptions.php 3 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     /**
122 122
      * Gets the the maximum number of allowed attachments
123 123
      *
124
-     * @return string
124
+     * @return integer
125 125
      */
126 126
     public function getAttachmentsCount()
127 127
     {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     /**
143 143
      * Gets the the maximum size of contact images in bytes
144 144
      *
145
-     * @return string
145
+     * @return integer
146 146
      */
147 147
     public function getContactImageMaxSize()
148 148
     {
Please login to merge, or discard this patch.
Indentation   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 
81 81
     protected $workflow = [
82 82
 
83
-      'recruiter',
83
+        'recruiter',
84 84
     ];
85 85
     
86 86
     /**
@@ -218,13 +218,13 @@  discard block
 block discarded – undo
218 218
     }
219 219
     
220 220
     /**
221
-	 * @return boolean
222
-	 * @since 0.27
223
-	 */
224
-	public function getAllowSubsequentAttachmentUpload()
225
-	{
226
-		return $this->allowSubsequentAttachmentUpload;
227
-	}
221
+     * @return boolean
222
+     * @since 0.27
223
+     */
224
+    public function getAllowSubsequentAttachmentUpload()
225
+    {
226
+        return $this->allowSubsequentAttachmentUpload;
227
+    }
228 228
 
229 229
     /**
230 230
      * @param boolean $allowSubsequentAttachmentUpload
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
      *
36 36
      * @var array $attachmentsMimeType
37 37
      */
38
-    protected $attachmentsMimeType = array('image','applications/pdf',
38
+    protected $attachmentsMimeType = array('image', 'applications/pdf',
39 39
         'application/x-pdf',
40 40
         'application/acrobat',
41 41
         'applications/vnd.pdf',
@@ -233,7 +233,7 @@  discard block
 block discarded – undo
233 233
      */
234 234
     public function setAllowSubsequentAttachmentUpload($allowSubsequentAttachmentUpload)
235 235
     {
236
-        $this->allowSubsequentAttachmentUpload = (bool)$allowSubsequentAttachmentUpload;
236
+        $this->allowSubsequentAttachmentUpload = (bool) $allowSubsequentAttachmentUpload;
237 237
         
238 238
         return $this;
239 239
     }
Please login to merge, or discard this patch.
src/Applications/Repository/Event/DeleteRemovedAttachmentsSubscriber.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,8 +35,8 @@
 block discarded – undo
35 35
     /**
36 36
      * Updates fiile permissions on Flush
37 37
      *
38
-     * @param OnFlushEventArgs $eventArgs
39
-     * @return boolean
38
+     * @param LifecycleEventArgs $eventArgs
39
+     * @return boolean|null
40 40
      */
41 41
     public function postRemoveEntity(LifecycleEventArgs $eventArgs)
42 42
     {
Please login to merge, or discard this patch.
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -51,14 +51,14 @@
 block discarded – undo
51 51
         $fileId = new \MongoId($file->id);
52 52
         
53 53
         $dm->createQueryBuilder('Applications\Entity\Application')
54
-           ->update()->multiple(true)
55
-           ->field('attachments')->equals($fileId)->pull($fileId)
56
-           ->getQuery()->execute();
54
+            ->update()->multiple(true)
55
+            ->field('attachments')->equals($fileId)->pull($fileId)
56
+            ->getQuery()->execute();
57 57
         
58 58
         
59 59
         $dm->createQueryBuilder('Applications\Entity\Application')
60
-           ->update()->multiple(true)
61
-           ->field('contact.image')->equals($fileId)->set(null)
62
-           ->getQuery()->execute();
60
+            ->update()->multiple(true)
61
+            ->field('contact.image')->equals($fileId)->set(null)
62
+            ->getQuery()->execute();
63 63
     }
64 64
 }
Please login to merge, or discard this patch.
src/Applications/Repository/Event/UpdateFilesPermissionsSubscriber.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@
 block discarded – undo
35 35
      * Updates fiile permissions on Flush
36 36
      *
37 37
      * @param OnFlushEventArgs $eventArgs
38
-     * @return boolean
38
+     * @return boolean|null
39 39
      */
40 40
     public function onFlush(OnFlushEventArgs $eventArgs)
41 41
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
         $dm  = $eventArgs->getDocumentManager();
43 43
         $uow = $dm->getUnitOfWork();
44 44
         
45
-        $filter = function ($element) {
45
+        $filter = function($element) {
46 46
             return $element instanceof ApplicationInterface
47 47
                    && $element->getPermissions()->hasChanged();
48 48
         };
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -56,8 +56,8 @@  discard block
 block discarded – undo
56 56
                
57 57
                 foreach ($document->getAttachments() as $attachment) {
58 58
                     $attachment->getPermissions()
59
-                               ->clear()
60
-                               ->inherit($permissions);
59
+                                ->clear()
60
+                                ->inherit($permissions);
61 61
                     if ($isUpdate) {
62 62
                         $uow->computeChangeSet(
63 63
                             $dm->getClassMetadata(get_class($attachment)),
@@ -68,8 +68,8 @@  discard block
 block discarded – undo
68 68
                 
69 69
                 if ($image = $document->contact->image) {
70 70
                     $image->getPermissions()
71
-                          ->clear()
72
-                          ->inherit($permissions);
71
+                            ->clear()
72
+                            ->inherit($permissions);
73 73
                     if ($isUpdate) {
74 74
                         $uow->computeChangeSet(
75 75
                             $dm->getClassMetadata(get_class($image)),
Please login to merge, or discard this patch.
Applications/src/Applications/Repository/Filter/PaginationQueryFactory.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      *
26 26
      * @see \Zend\ServiceManager\FactoryInterface::createService()
27 27
      * @param ServiceLocatorInterface $serviceLocator
28
-     * @return \Applications\Repository\Filter\PaginationQuery|mixed
28
+     * @return PaginationQuery
29 29
      */
30 30
     public function createService(ServiceLocatorInterface $serviceLocator)
31 31
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
33 33
     {
34
-        $auth  = $serviceLocator->getServiceLocator()->get('AuthenticationService');
34
+        $auth = $serviceLocator->getServiceLocator()->get('AuthenticationService');
35 35
         $filter = new PaginationQuery($auth);
36 36
         return $filter;
37 37
     }
Please login to merge, or discard this patch.
module/Auth/src/Acl/Factory/Service/AclFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
      * - injects the UserRepository fetched from the service manager.
22 22
      *
23 23
      * @param ServiceLocatorInterface $serviceLocator
24
-     * @return \Auth\Adapter\ExternalApplication
24
+     * @return \Zend\Permissions\Acl\AclInterface
25 25
      * @see \Zend\ServiceManager\FactoryInterface::createService()
26 26
      */
27 27
     public function createService(ServiceLocatorInterface $serviceLocator)
Please login to merge, or discard this patch.
module/Auth/src/Acl/Listener/CheckPermissionsListenerFactory.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -22,8 +22,7 @@
 block discarded – undo
22 22
      *
23 23
      * - Injects the AuthenticationService
24 24
      *
25
-     * @param ServiceLocatorInterface $helpers
26
-     * @return \Auth\View\Helper\Auth
25
+     * @return CheckPermissionsListener
27 26
      * @see \Zend\ServiceManager\FactoryInterface::createService()
28 27
      */
29 28
     public function createService(ServiceLocatorInterface $serviceLocator)
Please login to merge, or discard this patch.
module/Auth/src/Auth/Factory/Service/AuthenticationServiceFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      * - injects the UserMapper fetched from the service manager.
27 27
      *
28 28
      * @param ServiceLocatorInterface $serviceLocator
29
-     * @return \Auth\Adapter\HybridAuth
29
+     * @return AuthenticationService
30 30
      * @see \Zend\ServiceManager\FactoryInterface::createService()
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
Please login to merge, or discard this patch.
module/Auth/src/Auth/Factory/Service/GotoResetPasswordFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
      *
26 26
      * @param ServiceLocatorInterface $serviceLocator
27 27
      *
28
-     * @return ForgotPassword
28
+     * @return GotoResetPassword
29 29
      */
30 30
     public function createService(ServiceLocatorInterface $serviceLocator)
31 31
     {
Please login to merge, or discard this patch.