Completed
Pull Request — develop (#329)
by Carsten
07:08
created
module/Core/src/Core/Repository/Filter/AbstractPaginationQuery.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
 
32 32
     /**
33 33
      * @param mixed $value
34
-     * @param null $queryBuilder
34
+     * @param \Doctrine\ODM\MongoDB\Query\Builder $queryBuilder
35 35
      * @return mixed
36 36
      * @throws \DomainException
37 37
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
         
44 44
         if ($this->repositoryName) {
45 45
             $nameParts = explode('/', $this->repositoryName);
46
-            $entityClass = $nameParts[0] . '\\Entity\\' . $nameParts[1];
46
+            $entityClass = $nameParts[0].'\\Entity\\'.$nameParts[1];
47 47
             $queryBuilder->find($entityClass);
48 48
         }
49 49
         return $this->createQuery($value, $queryBuilder);
Please login to merge, or discard this patch.
module/Core/src/Core/Service/RestClient.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
 
89 89
     /**
90 90
      * @throws \RuntimeException
91
-     * @return mixed
91
+     * @return ZendClient
92 92
      */
93 93
     protected function authetificate()
94 94
     {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -92,8 +92,8 @@
 block discarded – undo
92 92
      */
93 93
     protected function authetificate()
94 94
     {
95
-        $auth = array_key_exists('user', $this->config)?$this->config['user']:'';
96
-        $pass = array_key_exists('pass', $this->config)?$this->config['pass']:'';
95
+        $auth = array_key_exists('user', $this->config) ? $this->config['user'] : '';
96
+        $pass = array_key_exists('pass', $this->config) ? $this->config['pass'] : '';
97 97
         return $this->setAuth($auth, $pass);
98 98
     }
99 99
 
Please login to merge, or discard this patch.
module/Core/src/Core/View/Helper/Alert.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -160,7 +160,7 @@
 block discarded – undo
160 160
     /**
161 161
      * Starts content capturing.
162 162
      *
163
-     * @param string|array $type
163
+     * @param string|null $type
164 164
      * @param array        $options see {@łink render()} for information.
165 165
      *
166 166
      * @return self
Please login to merge, or discard this patch.
Indentation   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -52,7 +52,6 @@  discard block
 block discarded – undo
52 52
  * @method warning()
53 53
  * @method success()
54 54
  * @method danger()
55
-
56 55
  *
57 56
 *@author Mathias Gelhausen <[email protected]>
58 57
  */
@@ -149,7 +148,7 @@  discard block
 block discarded – undo
149 148
         ) {
150 149
             $class .= ' alert-dismissable';
151 150
             $content = '<button type="button" class="close" data-dismiss="alert">&times;</button>'
152
-                     . '<span class="notification-content">' . $content . '</span>';
151
+                        . '<span class="notification-content">' . $content . '</span>';
153 152
         }
154 153
 
155 154
         $target = array_key_exists('target', $options)?' target="' . $options['target'] . '"':'';
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -142,18 +142,18 @@  discard block
 block discarded – undo
142 142
             return $this->start($type, $options);
143 143
         }
144 144
 
145
-        $id    = isset($options['id']) ? ' id="' . $options['id'] . '"' : '';
146
-        $class = isset($options['class']) ? ' ' . $options['class'] : '';
145
+        $id    = isset($options['id']) ? ' id="'.$options['id'].'"' : '';
146
+        $class = isset($options['class']) ? ' '.$options['class'] : '';
147 147
         if ((isset($options['dismissable']) && $options['dismissable'])
148 148
             || !isset($options['dismissable'])
149 149
         ) {
150 150
             $class .= ' alert-dismissable';
151 151
             $content = '<button type="button" class="close" data-dismiss="alert">&times;</button>'
152
-                     . '<span class="notification-content">' . $content . '</span>';
152
+                     . '<span class="notification-content">'.$content.'</span>';
153 153
         }
154 154
 
155
-        $target = array_key_exists('target', $options)?' target="' . $options['target'] . '"':'';
156
-        $markup = '<div ' . $id . ' class="alert alert-' . $type . $class . '" ' . $target . '>' . $content . '</div>' . PHP_EOL;
155
+        $target = array_key_exists('target', $options) ? ' target="'.$options['target'].'"' : '';
156
+        $markup = '<div '.$id.' class="alert alert-'.$type.$class.'" '.$target.'>'.$content.'</div>'.PHP_EOL;
157 157
         return $markup;
158 158
     }
159 159
 
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
     public function __call($method, $args)
192 192
     {
193 193
         if (!in_array($method, array(self::TYPE_INFO, self::TYPE_DANGER, self::TYPE_SUCCESS, self::TYPE_WARNING))) {
194
-            throw new \BadMethodCallException('Unknown method: ' . $method);
194
+            throw new \BadMethodCallException('Unknown method: '.$method);
195 195
         }
196 196
 
197 197
         // We know that $method is one of the valid types, so we can safely use it as "type"-parameter for the
Please login to merge, or discard this patch.
module/Core/src/Core/View/Helper/DateFormat.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,6 @@
 block discarded – undo
53 53
      *
54 54
      * @see \Zend\I18n\View\Helper\DateFormat::__invoke()
55 55
      *
56
-     * @param \DateTime $data|string
57 56
      * @param string $dateType
58 57
      * @return string
59 58
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
 {
41 41
     const FULL  = 'full';
42 42
     const LONG  = 'long';
43
-    const MEDIUM= 'medium';
43
+    const MEDIUM = 'medium';
44 44
     const SHORT = 'short';
45 45
     const NONE  = 'none';
46 46
 
Please login to merge, or discard this patch.
module/Core/src/Core/View/Helper/Params.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -171,7 +171,7 @@
 block discarded – undo
171 171
      * Return all event parameters or a single event parameter.
172 172
      *
173 173
      * @param string $param Parameter name to retrieve, or null to get all.
174
-     * @param mixed $efault Default value to use when the parameter is missing.
174
+     * @param mixed $default Default value to use when the parameter is missing.
175 175
      * @return mixed
176 176
      * @throws RuntimeException
177 177
      */
Please login to merge, or discard this patch.
module/Core/src/Core/View/Helper/Period.php 2 patches
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -17,8 +17,7 @@
 block discarded – undo
17 17
     /**
18 18
      * returns the number of years of the education or work experience
19 19
      *
20
-     * @param array $obj
21
-     * @return string
20
+     * @return double
22 21
      */
23 22
     public function __invoke($array)
24 23
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -25,13 +25,13 @@
 block discarded – undo
25 25
         // calculate EndDate - StartDate = X Years.
26 26
         // eg. 4.2 Years
27 27
         
28
-        $days=0;
28
+        $days = 0;
29 29
         foreach ($array as $obj) {
30 30
             $date1 = new \DateTime($obj->endDate);
31 31
             $date2 = new \DateTime($obj->startDate);
32 32
             $interval = $date1->diff($date2);
33
-            $days+=abs($interval->format('%R%a'));
33
+            $days += abs($interval->format('%R%a'));
34 34
         }
35
-        return round($days/365, 1);
35
+        return round($days / 365, 1);
36 36
     }
37 37
 }
Please login to merge, or discard this patch.
module/Core/src/Core/View/Helper/Service/DateFormatHelperFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@
 block discarded – undo
26 26
      * - injects the MvcEvent instance
27 27
      *
28 28
      * @param ServiceLocatorInterface $serviceLocator
29
-     * @return \Core\View\Helper\Params
29
+     * @return DateFormat
30 30
      * @see \Zend\ServiceManager\FactoryInterface::createService()
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Entity/JobSnapshot.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -673,7 +673,7 @@  discard block
 block discarded – undo
673 673
     /**
674 674
      * Gets locations of a job posting
675 675
      *
676
-     * @return string
676
+     * @return Collection
677 677
      */
678 678
     public function getLocations()
679 679
     {
@@ -715,7 +715,7 @@  discard block
 block discarded – undo
715 715
     /**
716 716
      * Gets applications for a job posting
717 717
      *
718
-     * @return string
718
+     * @return Status
719 719
      */
720 720
     public function getStatus()
721 721
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -286,14 +286,14 @@  discard block
 block discarded – undo
286 286
     {
287 287
         $methods = array_filter(
288 288
             get_class_methods($source),
289
-            function ($v) {
289
+            function($v) {
290 290
                 return 3 < strlen($v) && strpos($v, 'get') === 0;
291 291
             }
292 292
         );
293 293
         // these attributes don't need to get copied
294 294
         $methods = array_diff($methods, array('getId', 'getHydrator', 'getHiringOrganizations'));
295 295
         $methods = array_map(
296
-            function ($v) {
296
+            function($v) {
297 297
                 return lcfirst(substr($v, 3));
298 298
             },
299 299
             $methods
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
             $element = $source->$attribute;
303 303
             if (isset($element)) {
304 304
                 // when the parameter is rigid you can't assign an non-existing elements
305
-                if (method_exists($target, 'set' . lcfirst($attribute))) {
305
+                if (method_exists($target, 'set'.lcfirst($attribute))) {
306 306
                     $target->$attribute = $element;
307 307
                 }
308 308
             }
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Listener/MailSenderFactory.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,7 @@
 block discarded – undo
27 27
      *
28 28
      * @param ServiceLocatorInterface $serviceLocator
29 29
      *
30
-     * @return NewJobMailSender
30
+     * @return MailSender
31 31
      */
32 32
     public function createService(ServiceLocatorInterface $serviceLocator)
33 33
     {
Please login to merge, or discard this patch.