Inspection of "Merge branch 'feature/orders-store_invoice_address..." - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( b92fd0...28494b )

unknown

created 2016-03-30 13:48 UTC

Status

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * YAWIK
- *
- * @filesource
- * @license MIT
- * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
- */
+     * YAWIK
+     *
+     * @filesource
+     * @license MIT
+     * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
+     */
 return [
     'doctrine' => [
         'driver' => [
@@ -60,4 +60,4 @@  discard block
 block discarded – undo
         ],
     ],
 ];
-  
\ No newline at end of file
+    
\ No newline at end of file

Please login to merge, or discard this patch.

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -20,17 +20,17 @@  discard block
 block discarded – undo
 
     'event_manager' => [
 
-        'Jobs/Events' => [ 'listeners' => [
+        'Jobs/Events' => ['listeners' => [
             \Jobs\Listener\Events\JobEvent::EVENT_JOB_CREATED => [
                 'Orders/Listener/CreateJobOrder' => true,
             ],
         ]],
 
-        'Jobs/JobContainer/Events' => [ 'listeners' => [
+        'Jobs/JobContainer/Events' => ['listeners' => [
             \Core\Form\Event\FormEvent::EVENT_INIT => [
                 'Orders\Form\Listener\InjectInvoiceAddressInJobContainer',
             ],
-            'ValidateJob' => [ '\Orders\Form\Listener\ValidateJobInvoiceAddress' ],
+            'ValidateJob' => ['\Orders\Form\Listener\ValidateJobInvoiceAddress'],
         ]],
 
         'Orders/Form/InvoiceAddress/Events' => [
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
     'view_helper_config' => [
         'headscript' => [
             'lang/orders' => [
-                [ \Zend\View\Helper\HeadScript::FILE, 'Orders/js/list.index.js', 'PREPEND' ],
+                [\Zend\View\Helper\HeadScript::FILE, 'Orders/js/list.index.js', 'PREPEND'],
                 'js/bootstrap-dialog.min.js'
             ],
         ],

Please login to merge, or discard this patch.

module/Orders/src/Listener/CreateJobOrder.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -62,7 +62,7 @@
 block discarded – undo
         $this->priceFilter     = $priceFilter;
         $this->options         = $options;
         $this->providerOptions = $providerOptions;
-        $this->orderRepository      = $orderRepository;
+        $this->orderRepository = $orderRepository;
         $this->draftRepository = $draftRepository;
     }
 

Please login to merge, or discard this patch.

module/Orders/src/Form/InvoiceAddressFieldset.php 1 patch

Indentation +79 added lines, -79 removed lines patch added patch discarded remove patch

@@ -1,11 +1,11 @@  discard block
 block discarded – undo
 <?php
 /**
- * YAWIK
- *
- * @filesource
- * @license    MIT
- * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
- */
+     * YAWIK
+     *
+     * @filesource
+     * @license    MIT
+     * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
+     */
 
 /** */
 namespace Orders\Form;
@@ -27,78 +27,78 @@  discard block
 block discarded – undo
         $this->setName('invoiceAddress');
 
         $this->add([
-                       'type'       => 'text',
-                       'name'       => 'company',
-                       'options'    => [
-                           'label'       => /*@translate*/
-                               'Company',
-                           'description' => /*@translate*/
-                               'Enter the name of the company',
-                       ],
-                       'attributes' => [
-                           'required' => true, // marks the label as required.
-                       ]
-                   ]
+                        'type'       => 'text',
+                        'name'       => 'company',
+                        'options'    => [
+                            'label'       => /*@translate*/
+                                'Company',
+                            'description' => /*@translate*/
+                                'Enter the name of the company',
+                        ],
+                        'attributes' => [
+                            'required' => true, // marks the label as required.
+                        ]
+                    ]
         );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'street',
-                       'options' => [
-                           'label' => /*@translate*/
-                               'Street',
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'street',
+                        'options' => [
+                            'label' => /*@translate*/
+                                'Street',
+                        ],
+                    ]
         );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'zipCode',
-                       'options' => [
-                           'label' => /* @translate */
-                               'Postalcode'
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'zipCode',
+                        'options' => [
+                            'label' => /* @translate */
+                                'Postalcode'
+                        ],
+                    ]
         );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'city',
-                       'options' => [
-                           'label' => /*@translate*/
-                               'City',
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'city',
+                        'options' => [
+                            'label' => /*@translate*/
+                                'City',
+                        ],
+                    ]
         );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'region',
-                       'options' => [
-                           'label' => /*@translate*/
-                               'Region',
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'region',
+                        'options' => [
+                            'label' => /*@translate*/
+                                'Region',
+                        ],
+                    ]
         );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'country',
-                       'options' => [
-                           'label' => /*@translate*/
-                               'Country',
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'country',
+                        'options' => [
+                            'label' => /*@translate*/
+                                'Country',
+                        ],
+                    ]
         );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'vatIdNumber',
-                       'options' => [
-                           'label' => /*@translate*/
-                               'Value added tax ID',
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'vatIdNumber',
+                        'options' => [
+                            'label' => /*@translate*/
+                                'Value added tax ID',
+                        ],
+                    ]
         );
         $this->add(
             array(
@@ -133,28 +133,28 @@  discard block
 block discarded – undo
 //        );
 
         $this->add([
-                       'type'    => 'text',
-                       'name'    => 'name',
-                       'options' => [
-                           'label'       => /*@translate*/
-                               'Full name',
-                           'description' => /*@translate*/
-                               'Enter your full name (First, middle and last name)',
-                       ],
-                   ]
+                        'type'    => 'text',
+                        'name'    => 'name',
+                        'options' => [
+                            'label'       => /*@translate*/
+                                'Full name',
+                            'description' => /*@translate*/
+                                'Enter your full name (First, middle and last name)',
+                        ],
+                    ]
         );
 
         $this->add([
-                       'type'       => 'text',
-                       'name'       => 'email',
-                       'options'    => [
-                           'label' => /*@translate*/
-                               'Email address',
-                       ],
-                       'attributes' => [
-                           'required' => true, // marks the label as required.
-                       ]
-                   ]
+                        'type'       => 'text',
+                        'name'       => 'email',
+                        'options'    => [
+                            'label' => /*@translate*/
+                                'Email address',
+                        ],
+                        'attributes' => [
+                            'required' => true, // marks the label as required.
+                        ]
+                    ]
         );
     }
 

Please login to merge, or discard this patch.

module/Orders/src/Form/InvoiceAddress.php 1 patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -53,8 +53,8 @@  discard block
 block discarded – undo
     {
         parent::setParam($key, $value);
 
-        $events  = $this->getEventManager();
-        $events->trigger(FormEvent::EVENT_SET_PARAM, $this, [ 'param_name' => $key, 'param_value' => $value ]);
+        $events = $this->getEventManager();
+        $events->trigger(FormEvent::EVENT_SET_PARAM, $this, ['param_name' => $key, 'param_value' => $value]);
 
         return $this;
     }
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
         $valid = parent::isValid();
 
         $events = $this->getEventManager();
-        $events->trigger(FormEvent::EVENT_VALIDATE, $this, [ 'isValid' => $valid ]);
+        $events->trigger(FormEvent::EVENT_VALIDATE, $this, ['isValid' => $valid]);
 
         return $valid;
     }

Please login to merge, or discard this patch.

		@@ -53,8 +53,8 @@ discard block
		block discarded – undo
53	53	{
54	54	parent::setParam($key, $value);
55	55
56		- $events = $this->getEventManager();
57		- $events->trigger(FormEvent::EVENT_SET_PARAM, $this, [ 'param_name' => $key, 'param_value' => $value ]);
	56	+ $events = $this->getEventManager();
	57	+ $events->trigger(FormEvent::EVENT_SET_PARAM, $this, ['param_name' => $key, 'param_value' => $value]);
58	58
59	59	return $this;
60	60	}
		@@ -65,7 +65,7 @@ discard block
		block discarded – undo
65	65	$valid = parent::isValid();
66	66
67	67	$events = $this->getEventManager();
68		- $events->trigger(FormEvent::EVENT_VALIDATE, $this, [ 'isValid' => $valid ]);
	68	+ $events->trigger(FormEvent::EVENT_VALIDATE, $this, ['isValid' => $valid]);
69	69
70	70	return $valid;
71	71	}

		@@ -1,11 +1,11 @@ discard block
		block discarded – undo
1	1	<?php
2	2	/**
3		- * YAWIK
4		- *
5		- * @filesource
6		- * @license MIT
7		- * @copyright 2013 - 2016 Cross Solution <http://cross-solution.de>
8		- */
	3	+ * YAWIK
	4	+ *
	5	+ * @filesource
	6	+ * @license MIT
	7	+ * @copyright 2013 - 2016 Cross Solution <http://cross-solution.de>
	8	+ */
9	9	return [
10	10	'doctrine' => [
11	11	'driver' => [
		@@ -60,4 +60,4 @@ discard block
		block discarded – undo
60	60	],
61	61	],
62	62	];
63		-
64	63	\ No newline at end of file
	64	+
65	65	\ No newline at end of file

		@@ -20,17 +20,17 @@ discard block
		block discarded – undo
20	20
21	21	'event_manager' => [
22	22
23		- 'Jobs/Events' => [ 'listeners' => [
	23	+ 'Jobs/Events' => ['listeners' => [
24	24	\Jobs\Listener\Events\JobEvent::EVENT_JOB_CREATED => [
25	25	'Orders/Listener/CreateJobOrder' => true,
26	26	],
27	27	]],
28	28
29		- 'Jobs/JobContainer/Events' => [ 'listeners' => [
	29	+ 'Jobs/JobContainer/Events' => ['listeners' => [
30	30	\Core\Form\Event\FormEvent::EVENT_INIT => [
31	31	'Orders\Form\Listener\InjectInvoiceAddressInJobContainer',
32	32	],
33		- 'ValidateJob' => [ '\Orders\Form\Listener\ValidateJobInvoiceAddress' ],
	33	+ 'ValidateJob' => ['\Orders\Form\Listener\ValidateJobInvoiceAddress'],
34	34	]],
35	35
36	36	'Orders/Form/InvoiceAddress/Events' => [
		@@ -61,7 +61,7 @@ discard block
		block discarded – undo
61	61	'view_helper_config' => [
62	62	'headscript' => [
63	63	'lang/orders' => [
64		- [ \Zend\View\Helper\HeadScript::FILE, 'Orders/js/list.index.js', 'PREPEND' ],
	64	+ [\Zend\View\Helper\HeadScript::FILE, 'Orders/js/list.index.js', 'PREPEND'],
65	65	'js/bootstrap-dialog.min.js'
66	66	],
67	67	],

		@@ -62,7 +62,7 @@
		block discarded – undo
62	62	$this->priceFilter = $priceFilter;
63	63	$this->options = $options;
64	64	$this->providerOptions = $providerOptions;
65		- $this->orderRepository = $orderRepository;
	65	+ $this->orderRepository = $orderRepository;
66	66	$this->draftRepository = $draftRepository;
67	67	}
68	68

cross-solution / YAWIK

Push — develop ( b92fd0...28494b )

Status

Category

Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +4 added lines, -4 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +79 added lines, -79 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch