Completed
Pull Request — develop (#264)
by
unknown
27:31
created
module/Core/src/Core/Listener/LanguageRouteListener.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -215,8 +215,8 @@
 block discarded – undo
215 215
     }
216 216
 
217 217
     /**
218
-     * @param $response
219
-     * @param $uri
218
+     * @param \Zend\Stdlib\ResponseInterface $response
219
+     * @param string $uri
220 220
      *
221 221
      * @return mixed
222 222
      */
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -97,10 +97,10 @@  discard block
 block discarded – undo
97 97
         }
98 98
         
99 99
         $router = $e->getRouter();
100
-        $basePath=$router->getBaseUrl();
100
+        $basePath = $router->getBaseUrl();
101 101
         $match = [];
102 102
         
103
-        if (preg_match('~^' . $basePath . '/([a-z]{2})(?:/|$)~', $e->getRequest()->getRequestUri(), $match)) {
103
+        if (preg_match('~^'.$basePath.'/([a-z]{2})(?:/|$)~', $e->getRequest()->getRequestUri(), $match)) {
104 104
             /* It seems we have already a language in the URI
105 105
              * Now there are two possibilities:
106 106
              *
@@ -182,8 +182,8 @@  discard block
 block discarded – undo
182 182
         setlocale(
183 183
             LC_ALL,
184 184
             array(
185
-            $locale . ".utf8",
186
-            $locale . ".iso88591",
185
+            $locale.".utf8",
186
+            $locale.".iso88591",
187 187
             $locale,
188 188
             substr($locale, 0, 2),
189 189
             'de_DE.utf8',
Please login to merge, or discard this patch.
module/Core/src/Core/I18n/Locale.php 1 patch
Indentation   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -108,10 +108,10 @@
 block discarded – undo
108 108
     }
109 109
     
110 110
     /**
111
-	 * @return string
112
-	 */
113
-	public function getDefaultLanguage()
114
-	{
115
-		return $this->defaultLanguage;
116
-	}
111
+     * @return string
112
+     */
113
+    public function getDefaultLanguage()
114
+    {
115
+        return $this->defaultLanguage;
116
+    }
117 117
 }
Please login to merge, or discard this patch.
module/Auth/src/Auth/Controller/IndexController.php 1 patch
Spacing   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -31,8 +31,8 @@  discard block
 block discarded – undo
31 31
 class IndexController extends AbstractActionController
32 32
 {
33 33
 
34
-    const LOGIN='login';
35
-    const REGISTER='register';
34
+    const LOGIN = 'login';
35
+    const REGISTER = 'register';
36 36
 
37 37
     /**
38 38
      * @var AuthenticationService
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
         $registerForm = $this->forms[self::REGISTER];
89 89
 
90 90
         /* @var $request \Zend\Http\Request */
91
-        $request   = $this->getRequest();
91
+        $request = $this->getRequest();
92 92
 
93 93
         if ($request->isPost()) {
94 94
             $data                          = $this->params()->fromPost();
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
             if (array_key_exists('credentials', $data) &&
107 107
                 array_key_exists('login', $data['credentials']) &&
108 108
                 array_key_exists('credential', $data['credentials'])) {
109
-                $adapter->setIdentity($data['credentials']['login'] . $loginSuffix)
109
+                $adapter->setIdentity($data['credentials']['login'].$loginSuffix)
110 110
                     ->setCredential($data['credentials']['credential']);
111 111
             }
112 112
             
@@ -117,14 +117,14 @@  discard block
 block discarded – undo
117 117
             if ($result->isValid()) {
118 118
                 $user = $auth->getUser();
119 119
                 $language = $services->get('Core/Locale')->detectLanguage($request, $user);
120
-                $this->logger->info('User ' . $user->login . ' logged in');
120
+                $this->logger->info('User '.$user->login.' logged in');
121 121
                 
122 122
                 $ref = $this->params()->fromQuery('ref', false);
123 123
 
124 124
                 if ($ref) {
125 125
                     $ref = urldecode($ref);
126
-                    $url = preg_replace('~/[a-z]{2}(/|$)~', '/' . $language . '$1', $ref);
127
-                    $url = $request->getBasePath() . $url;
126
+                    $url = preg_replace('~/[a-z]{2}(/|$)~', '/'.$language.'$1', $ref);
127
+                    $url = $request->getBasePath().$url;
128 128
                 } else {
129 129
                     $urlHelper = $services->get('ViewHelperManager')->get('url');
130 130
                     $url = $urlHelper('lang', array('lang' => $language));
@@ -134,9 +134,9 @@  discard block
 block discarded – undo
134 134
             } else {
135 135
                 $loginName = $data['credentials']['login'];
136 136
                 if (!empty($loginSuffix)) {
137
-                    $loginName = $loginName . ' (' . $loginName . $loginSuffix . ')';
137
+                    $loginName = $loginName.' ('.$loginName.$loginSuffix.')';
138 138
                 }
139
-                $this->logger->info('Failed to authenticate User ' . $loginName);
139
+                $this->logger->info('Failed to authenticate User '.$loginName);
140 140
                 $this->notification()->danger(/*@translate*/ 'Authentication failed.');
141 141
             }
142 142
         }
@@ -195,11 +195,11 @@  discard block
 block discarded – undo
195 195
             try {
196 196
                 $user          = $auth->getUser();
197 197
                 $password      = substr(md5(uniqid()), 0, 6);
198
-                $login         = uniqid() . ($this->options->auth_suffix != "" ? '@' . $this->options->auth_suffix : '');
199
-                $externalLogin = isset($user->login)?$user->login:'-- not communicated --';
200
-                $this->logger->debug('first login via ' . $provider . ' as: ' . $externalLogin);
198
+                $login         = uniqid().($this->options->auth_suffix != "" ? '@'.$this->options->auth_suffix : '');
199
+                $externalLogin = isset($user->login) ? $user->login : '-- not communicated --';
200
+                $this->logger->debug('first login via '.$provider.' as: '.$externalLogin);
201 201
 
202
-                $user->login=$login;
202
+                $user->login = $login;
203 203
                 $user->setPassword($password);
204 204
                 $user->setRole($this->options->getRole());
205 205
 
@@ -216,11 +216,11 @@  discard block
 block discarded – undo
216 216
                 );
217 217
                 $mail->addTo($user->getInfo()->getEmail());
218 218
 
219
-                $loggerId = $login . ' (' . $provider . ': ' . $externalLogin . ')';
219
+                $loggerId = $login.' ('.$provider.': '.$externalLogin.')';
220 220
                 if (isset($mail) && $this->mailer($mail)) {
221
-                    $this->logger->info('Mail first-login for ' . $loggerId . ' sent to ' . $user->getInfo()->getEmail());
221
+                    $this->logger->info('Mail first-login for '.$loggerId.' sent to '.$user->getInfo()->getEmail());
222 222
                 } else {
223
-                    $this->logger->warn('No Mail was sent for ' . $loggerId);
223
+                    $this->logger->warn('No Mail was sent for '.$loggerId);
224 224
                 }
225 225
             } catch (\Exception $e) {
226 226
                 $this->logger->crit($e);
@@ -231,11 +231,11 @@  discard block
 block discarded – undo
231 231
         }
232 232
         
233 233
         $user = $auth->getUser();
234
-        $this->logger->info('User ' . $auth->getUser()->getInfo()->getDisplayName() . ' logged in via ' . $provider);
234
+        $this->logger->info('User '.$auth->getUser()->getInfo()->getDisplayName().' logged in via '.$provider);
235 235
         $settings = $user->getSettings('Core');
236 236
         if (null !== $settings->localization->language) {
237 237
             $basePath = $this->getRequest()->getBasePath();
238
-            $ref = preg_replace('~^'.$basePath . '/[a-z]{2}(/)?~', $basePath . '/' . $settings->localization->language . '$1', $ref);
238
+            $ref = preg_replace('~^'.$basePath.'/[a-z]{2}(/)?~', $basePath.'/'.$settings->localization->language.'$1', $ref);
239 239
         }
240 240
         return $this->redirect()->toUrl($ref);
241 241
     }
@@ -267,8 +267,8 @@  discard block
 block discarded – undo
267 267
         
268 268
         if ($result->isValid()) {
269 269
             $this->logger->info(
270
-                'User ' . $this->params()->fromPost('user') .
271
-                ' logged via ' . $appKey
270
+                'User '.$this->params()->fromPost('user').
271
+                ' logged via '.$appKey
272 272
             );
273 273
             
274 274
             // the external login may include some parameters for an update
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
             if (array_key_exists('firstLogin', $resultMessage) && $resultMessage['firstLogin'] === true) {
300 300
                 // first external Login
301 301
                 $userName = $this->params()->fromPost('user');
302
-                $this->logger->debug('first login for User: ' .  $userName);
302
+                $this->logger->debug('first login for User: '.$userName);
303 303
                 //
304 304
                 if (preg_match('/^(.*)@\w+$/', $userName, $realUserName)) {
305 305
                     $userName = $realUserName[1];
@@ -323,7 +323,7 @@  discard block
 block discarded – undo
323 323
 
324 324
                 try {
325 325
                     $this->mailer($mail);
326
-                    $this->logger->info('Mail first-login sent to ' . $userName);
326
+                    $this->logger->info('Mail first-login sent to '.$userName);
327 327
                 } catch (\Zend\Mail\Transport\Exception\ExceptionInterface $e) {
328 328
                     $this->logger->warn('No Mail was sent');
329 329
                     $this->logger->debug($e);
@@ -338,8 +338,8 @@  discard block
 block discarded – undo
338 338
             );
339 339
         } else {
340 340
             $this->logger->info(
341
-                'Failed to authenticate User ' . $this->params()->fromPost('user') .
342
-                ' via ' . $this->params()->fromPost('appKey')
341
+                'Failed to authenticate User '.$this->params()->fromPost('user').
342
+                ' via '.$this->params()->fromPost('appKey')
343 343
             );
344 344
             
345 345
             $this->getResponse()->setStatusCode(Response::STATUS_CODE_401);
@@ -364,8 +364,8 @@  discard block
 block discarded – undo
364 364
                 array(
365 365
                 'format' => 'json',
366 366
                     'group' => array(
367
-                        0 => 'testuser4711', 1 => 'flatscreen', 2 => 'flatscreen1', 3 => 'flatscreen2', 4 => 'flatscreen3',  5 => 'flatscreen4',
368
-                        6 => 'flatscreen5', 7 => 'flatscreen6', 8 => 'flatscreen7',  9 => 'flatscreen8', 10 => 'flatscreen9'
367
+                        0 => 'testuser4711', 1 => 'flatscreen', 2 => 'flatscreen1', 3 => 'flatscreen2', 4 => 'flatscreen3', 5 => 'flatscreen4',
368
+                        6 => 'flatscreen5', 7 => 'flatscreen6', 8 => 'flatscreen7', 9 => 'flatscreen8', 10 => 'flatscreen9'
369 369
                     ),
370 370
                     'name' => '(die) Rauscher – Unternehmensberatung & Consulting',
371 371
                 )
@@ -374,7 +374,7 @@  discard block
 block discarded – undo
374 374
         }
375 375
         $auth = $this->auth;
376 376
         $userGrpAdmin = $auth->getUser();
377
-        $this->logger->info('User ' . $auth->getUser()->getInfo()->getDisplayName());
377
+        $this->logger->info('User '.$auth->getUser()->getInfo()->getDisplayName());
378 378
         $grp = $this->params()->fromQuery('group');
379 379
         
380 380
         // if the request is made by an external host, add his identification-key to the name
@@ -395,16 +395,16 @@  discard block
 block discarded – undo
395 395
             foreach ($params->group as $grp_member) {
396 396
                 try
397 397
                 {
398
-                    $user = $users->findByLogin($grp_member . $loginSuffix);
398
+                    $user = $users->findByLogin($grp_member.$loginSuffix);
399 399
                     if (!empty($user)) {
400 400
                         $groupUserId[] = $user->id;
401 401
                     } else {
402
-                        $notFoundUsers[] = $grp_member . $loginSuffix;
402
+                        $notFoundUsers[] = $grp_member.$loginSuffix;
403 403
                     }
404 404
                 }
405 405
                 catch (\Auth\Exception\UserDeactivatedException $e)
406 406
                 {
407
-                    $notFoundUsers[] = $grp_member . $loginSuffix;
407
+                    $notFoundUsers[] = $grp_member.$loginSuffix;
408 408
                 }
409 409
             }
410 410
         }
@@ -414,9 +414,9 @@  discard block
 block discarded – undo
414 414
             $group->setUsers($groupUserId);
415 415
         }
416 416
         $this->logger->info(
417
-            'Update Group Name: ' . $name . PHP_EOL . str_repeat(' ', 36) . 'Group Owner: ' . $userGrpAdmin->getLogin() . PHP_EOL .
418
-            str_repeat(' ', 36) . 'Group Members Param: ' . implode(',', $params->group) . PHP_EOL .
419
-            str_repeat(' ', 36) . 'Group Members: ' . count($groupUserId) . PHP_EOL . str_repeat(' ', 36) . 'Group Members not found: ' . implode(',', $notFoundUsers)
417
+            'Update Group Name: '.$name.PHP_EOL.str_repeat(' ', 36).'Group Owner: '.$userGrpAdmin->getLogin().PHP_EOL.
418
+            str_repeat(' ', 36).'Group Members Param: '.implode(',', $params->group).PHP_EOL.
419
+            str_repeat(' ', 36).'Group Members: '.count($groupUserId).PHP_EOL.str_repeat(' ', 36).'Group Members not found: '.implode(',', $notFoundUsers)
420 420
         );
421 421
         
422 422
         return new JsonModel(
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
     public function logoutAction()
434 434
     {
435 435
         $auth = $this->auth;
436
-        $this->logger->info('User ' . ($auth->getUser()->login==''?$auth->getUser()->info->displayName:$auth->getUser()->login) . ' logged out');
436
+        $this->logger->info('User '.($auth->getUser()->login == '' ? $auth->getUser()->info->displayName : $auth->getUser()->login).' logged out');
437 437
         $auth->clearIdentity();
438 438
         unset($_SESSION['HA::STORE']);
439 439
 
Please login to merge, or discard this patch.