Completed
Push — develop ( 5260e4...ed74ca )
by
unknown
12:11
created
module/Jobs/src/Jobs/Controller/ManageController.php 2 patches
Doc Comments   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
     }
65 65
 
66 66
     /**
67
-     * @return $this|void
67
+     * @return ManageController
68 68
      */
69 69
     public function attachDefaultListeners()
70 70
     {
@@ -107,7 +107,7 @@  discard block
 block discarded – undo
107 107
     /**
108 108
      * @TODO edit-Action and save-Action are doing the same, one of them has to quit
109 109
      *
110
-     * @return null|ViewModel
110
+     * @return ViewModel
111 111
      */
112 112
     public function editAction()
113 113
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
     }
122 122
 
123 123
     /**
124
-     * @return null|ViewModel
124
+     * @return ViewModel
125 125
      */
126 126
     public function saveAction()
127 127
     {
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      * parameter are arbitrary elements for defaults or programming flow
137 137
      *
138 138
      * @param array $parameter
139
-     * @return null|ViewModel
139
+     * @return ViewModel
140 140
      * @throws \RuntimeException
141 141
      */
142 142
     protected function save($parameter = array())
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
 
345 345
     /**
346 346
      * @param $job
347
-     * @return mixed
347
+     * @return \Jobs\Form\Job
348 348
      */
349 349
     protected function getFormular($job)
350 350
     {
@@ -365,7 +365,7 @@  discard block
 block discarded – undo
365 365
     }
366 366
 
367 367
     /**
368
-     * @param $form
368
+     * @param \Jobs\Form\Job $form
369 369
      * @param array $params
370 370
      * @return ViewModel
371 371
      */
@@ -501,7 +501,7 @@  discard block
 block discarded – undo
501 501
     /**
502 502
      * Deactivate a job posting
503 503
      *
504
-     * @return null|ViewModel
504
+     * @return ViewModel
505 505
      */
506 506
     public function deactivateAction()
507 507
     {
@@ -538,7 +538,7 @@  discard block
 block discarded – undo
538 538
     }
539 539
 
540 540
     /**
541
-     * @param $script
541
+     * @param string $script
542 542
      * @param array $parameter
543 543
      * @return ViewModel
544 544
      */
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@  discard block
 block discarded – undo
146 146
         if (empty($user->info->email)) {
147 147
             return $this->getErrorViewModel('no-parent', array('cause' => 'noEmail'));
148 148
         }
149
-        $userOrg            = $user->getOrganization();
149
+        $userOrg = $user->getOrganization();
150 150
         if (!$userOrg->hasAssociation()) {
151 151
             return $this->getErrorViewModel('no-parent', array('cause' => 'noCompany'));
152 152
         }
@@ -160,7 +160,7 @@  discard block
 block discarded – undo
160 160
 
161 161
         $params             = $this->params();
162 162
         $formIdentifier     = $params->fromQuery('form');
163
-        $pageIdentifier     = (int) $params->fromQuery('page', array_key_exists('page', $parameter)?$parameter['page']:0);
163
+        $pageIdentifier     = (int) $params->fromQuery('page', array_key_exists('page', $parameter) ? $parameter['page'] : 0);
164 164
 
165 165
         $jobEntity = $this->initializeJob()->get($this->params(), true);
166 166
 
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
         $instanceForm       = null;
173 173
         $formErrorMessages = array();
174 174
 
175
-        if (isset($formIdentifier) &&  $request->isPost()) {
175
+        if (isset($formIdentifier) && $request->isPost()) {
176 176
             // at this point the form get instantiated and immediately accumulated
177 177
             $instanceForm = $form->getForm($formIdentifier);
178 178
             if (!isset($instanceForm)) {
@@ -237,7 +237,7 @@  discard block
 block discarded – undo
237 237
             } else {
238 238
                 $viewHelper = 'form';
239 239
             }
240
-            $viewHelperManager  = $serviceLocator->get('ViewHelperManager');
240
+            $viewHelperManager = $serviceLocator->get('ViewHelperManager');
241 241
             $content = $viewHelperManager->get($viewHelper)->__invoke($instanceForm);
242 242
             $viewModel = new JsonModel(
243 243
                 array(
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
                 );
291 291
             }
292 292
             if ($pageIdentifier < count($pageToForm) - 1) {
293
-                $pageLinkNext     = $this->url()->fromRoute(
293
+                $pageLinkNext = $this->url()->fromRoute(
294 294
                     'lang/jobs/manage',
295 295
                     [],
296 296
                     [
@@ -302,7 +302,7 @@  discard block
 block discarded – undo
302 302
             }
303 303
             $completionLink = $this->url()->fromRoute(
304 304
                 'lang/jobs/completion',
305
-                [ 'id' => $jobEntity->getId()]
305
+                ['id' => $jobEntity->getId()]
306 306
             );
307 307
 
308 308
             $viewModel = $this->getViewModel($form);
@@ -438,7 +438,7 @@  discard block
 block discarded – undo
438 438
         // array with differences between the last snapshot and the actual entity
439 439
         // is remains Null if there is no snapshot
440 440
         // it will be an empty array if the snapshot and the actual entity do not differ
441
-        $diff           = null;
441
+        $diff = null;
442 442
         // preliminary difference, contain all differences
443 443
         $prelDiff = $this->entitySnapshot()->diff($jobEntity);
444 444
         if (isset($prelDiff)) {
@@ -474,21 +474,21 @@  discard block
 block discarded – undo
474 474
             'lang/jobs/view',
475 475
             array(),
476 476
             array('query' =>
477
-                      array( 'id' => $jobEntity->getId()))
477
+                      array('id' => $jobEntity->getId()))
478 478
         );
479 479
 
480 480
         $approvalLink = $this->url()->fromRoute(
481 481
             'lang/jobs/approval',
482 482
             array('state' => 'approved'),
483 483
             array('query' =>
484
-                      array( 'id' => $jobEntity->getId()))
484
+                      array('id' => $jobEntity->getId()))
485 485
         );
486 486
 
487 487
         $declineLink = $this->url()->fromRoute(
488 488
             'lang/jobs/approval',
489 489
             array('state' => 'declined'),
490 490
             array('query' =>
491
-                      array( 'id' => $jobEntity->getId()))
491
+                      array('id' => $jobEntity->getId()))
492 492
         );
493 493
 
494 494
         return array('job' => $jobEntity,
@@ -505,7 +505,7 @@  discard block
 block discarded – undo
505 505
      */
506 506
     public function deactivateAction()
507 507
     {
508
-        $user           = $this->auth->getUser();
508
+        $user = $this->auth->getUser();
509 509
 
510 510
         $jobEntity = $this->initializeJob()->get($this->params());
511 511
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Factory/Controller/Plugin/InitializeJobFactory.php 1 patch
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2016 Cross Solution (http://cross-solution.de)
7
- * @author cbleek
8
- * @license   MIT
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2016 Cross Solution (http://cross-solution.de)
7
+     * @author cbleek
8
+     * @license   MIT
9
+     */
10 10
 
11 11
 namespace Core\Form\View\Helper;
12 12
 
Please login to merge, or discard this patch.
module/Jobs/src/Jobs/Controller/Plugin/InitializeJob.php 2 patches
Indentation   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -1,12 +1,12 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * YAWIK
4
- *
5
- * @filesource
6
- * @copyright (c) 2013-2016 Cross Solution (http://cross-solution.de)
7
- * @author cbleek
8
- * @license   MIT
9
- */
3
+     * YAWIK
4
+     *
5
+     * @filesource
6
+     * @copyright (c) 2013-2016 Cross Solution (http://cross-solution.de)
7
+     * @author cbleek
8
+     * @license   MIT
9
+     */
10 10
 
11 11
 namespace Core\Form\View\Helper;
12 12
 
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -38,10 +38,10 @@  discard block
 block discarded – undo
38 38
      */
39 39
     protected $acl;
40 40
 
41
-    public function __construct(RepositoryService $repositoryService,AuthenticationService $auth, Acl $acl) {
42
-        $this->repositoryService=$repositoryService;
43
-        $this->auth=$auth;
44
-        $this->acl=$acl;
41
+    public function __construct(RepositoryService $repositoryService, AuthenticationService $auth, Acl $acl) {
42
+        $this->repositoryService = $repositoryService;
43
+        $this->auth = $auth;
44
+        $this->acl = $acl;
45 45
     }
46 46
 
47 47
     public function __invoke()
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
      * @return \Jobs\Entity\Job|object
57 57
      * @throws \Doctrine\ODM\MongoDB\LockException
58 58
      */
59
-    public function get(Params $params,$allowDraft = false)
59
+    public function get(Params $params, $allowDraft = false)
60 60
     {
61 61
         /* @var \Jobs\Repository\Job $jobRepository */
62 62
         $jobRepository  = $this->repositoryService->get('Jobs/Job');
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
         $id_fromQuery   = $params->fromQuery('id', 0);
66 66
         $id_fromSubForm = $params->fromPost('job', 0);
67 67
 
68
-        $id = empty($id_fromRoute)? (empty($id_fromQuery)?$id_fromSubForm:$id_fromQuery) : $id_fromRoute;
68
+        $id = empty($id_fromRoute) ? (empty($id_fromQuery) ? $id_fromSubForm : $id_fromQuery) : $id_fromRoute;
69 69
 
70 70
         if (empty($id) && $allowDraft) {
71 71
             $this->acl->__invoke('Jobs/Manage', 'new');
Please login to merge, or discard this patch.