Jobs\Controller\JobboardController::indexAction()

Complexity

Conditions	10
Paths	20

Size

Total Lines	60
Code Lines	38

Duplication

Lines	13
Ratio	21.67 %

Importance

Changes	8
Bugs	0	Features	2

<?php
    public function indexAction()
    {
        /* @var \Zend\Http\Request $request */
        $request          = $this->getRequest();
        $params           = $request->getQuery();
        $jsonFormat       = 'json' == $request->getQuery()->get('format');
        $event            = $this->getEvent();
        $routeMatch       = $event->getRouteMatch();
        $matchedRouteName = $routeMatch->getMatchedRouteName();
        $url              = $this->url()->fromRoute($matchedRouteName, array(), array('force_canonical' => true));

        if (!$jsonFormat && !$request->isXmlHttpRequest()) {

This code seems to be duplicated across your project.

            $session = new Session('Jobs\Index');
            $sessionKey = $this->auth()->isLoggedIn() ? 'userParams' : 'guestParams';
            $sessionParams = $session[$sessionKey];
            if ($sessionParams) {
                foreach ($sessionParams as $key => $value) {
                    $params->set($key, $params->get($key, $value));
                }
            }
            $session[$sessionKey] = $params->toArray();

            $this->searchForm->bind($params);
        }

        $params = $params->get('params', []);

        if (isset($params['l']['data']) &&
            isset($params['l']['name']) &&
            !empty($params['l']['name'])) {
            /* @var \Geo\Form\GeoText $geoText */
            $geoText = $this->searchForm->get('params')->get('l');

It seems like you code against a concrete implementation and not the interface Zend\Form\ElementInterface as the method get() does only exist in the following implementations of said interface: Applications\Form\Apply, Applications\Form\Attributes, Applications\Form\Base, Applications\Form\BaseFieldset, Applications\Form\CarbonCopyFieldset, Applications\Form\CommentForm, Applications\Form\ContactContainer, Applications\Form\Facts, Applications\Form\FactsFieldset, Applications\Form\FilterApplication, Applications\Form\Mail, Applications\Form\SettingsFieldset, Auth\Form\ForgotPassword, Auth\Form\Group, Auth\Form\GroupFieldset, Auth\Form\GroupUsersCollection, Auth\Form\Login, Auth\Form\Register, Auth\Form\SocialProfiles, Auth\Form\SocialProfilesFieldset, Auth\Form\UserBase, Auth\Form\UserBaseFieldset, Auth\Form\UserInfo, Auth\Form\UserInfoContainer, Auth\Form\UserInfoFieldset, Auth\Form\UserPassword, Auth\Form\UserPasswordFieldset, Auth\Form\UserProfileContainer, Core\Form\BaseForm, Core\Form\ButtonsFieldset, Core\Form\Container, Core\Form\DefaultButtonsFieldset, Core\Form\Form, Core\Form\FormSubmitButtonsFieldset, Core\Form\ListFilterButtonsFieldset, Core\Form\LocalizationSettingsFieldset, Core\Form\PermissionsCollection, Core\Form\PermissionsFieldset, Core\Form\RatingFieldset, Core\Form\SummaryForm, Core\Form\SummaryFormButtonsFieldset, Core\Form\ViewPartialProviderAbstract, Cv\Form\Cv, Cv\Form\CvFieldset, Cv\Form\EducationFieldset, Cv\Form\EmploymentFieldset, Cv\Form\LanguageFieldset, Cv\Form\NativeLanguageFieldset, Cv\Form\SkillFieldset, Install\Form\Installation, Jobs\Form\AtsMode, Jobs\Form\AtsModeFieldset, Jobs\Form\Base, Jobs\Form\BaseFieldset, Jobs\Form\CompanyName, Jobs\Form\CompanyNameFieldset, Jobs\Form\Import, Jobs\Form\ImportFieldset, Jobs\Form\Job, Jobs\Form\JobDescription, Jobs\Form\JobDescriptionBenefits, Jobs\Form\JobDescriptionDescription, Jobs\Form\JobDescriptionFieldset, Jobs\Form\JobDescriptionQualifications, Jobs\Form\JobDescriptionRequirements, Jobs\Form\JobDescriptionTemplate, Jobs\Form\JobDescriptionTitle, Jobs\Form\ListFilter, Jobs\Form\ListFilterAdminFieldset, Jobs\Form\ListFilterBaseFieldset, Jobs\Form\ListFilterLocationFieldset, Jobs\Form\ListFilterPersonalFieldset, Jobs\Form\Multipost, Jobs\Form\MultipostButtonFieldset, Jobs\Form\MultipostFieldset, Jobs\Form\Preview, Jobs\Form\PreviewFieldset, Jobs\Form\TemplateLabelBenefits, Jobs\Form\TemplateLabelQualifications, Jobs\Form\TemplateLabelRequirements, Organizations\Form\EmployeeFieldset, Organizations\Form\Employees, Organizations\Form\EmployeesFieldset, Organizations\Form\Organizations, Organizations\Form\OrganizationsContactFieldset, Organizations\Form\OrganizationsContactForm, Organizations\Form\OrganizationsDescriptionFieldset, Organizations\Form\OrganizationsDescriptionForm, Organizations\Form\OrganizationsFieldset, Organizations\Form\OrganizationsNameFieldset, Organizations\Form\OrganizationsNameForm, Settings\Form\AbstractSettingsForm, Settings\Form\DisableElementsCapableFormSettingsFieldset, Settings\Form\FormAbstract, Settings\Form\Settings, Settings\Form\SettingsFieldset, Zend\Form\Element\Collection, Zend\Form\Fieldset, Zend\Form\Form, Zend\Form\InputFilterProviderFieldset.

            $geoText->setValue($params['l']);
            $params['location'] = $geoText->getValue('entity');
        }

        if (!isset($params['sort'])) {
            $params['sort']='-date';
        }

        $this->searchForm->setAttribute('action', $url);

        $params['by'] = "guest";

        $paginator = $this->paginatorService('Jobs/Board', $params);

The call to JobboardController::paginatorService() has too many arguments starting with 'Jobs/Board'.

        $options = $this->searchForm->getOptions();
        $options['showButtons'] = false;
        $this->searchForm->setOptions($options);
        
        $return = array(
            'by' => $params['by'],
            'jobs' => $paginator,
            'filterForm' => $this->searchForm
        );
        $model = new ViewModel($return);

        return $model;
    }
}