Jobs\Controller\JobboardController

Complexity

Total Complexity

12

Size/Duplication

Total Lines	105
Duplicated Lines	20.95 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	7
Bugs	0	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	attachDefaultListeners()	9	9	1
C	indexAction()	13	60	10

<?php
/**
 * YAWIK
 *
 * @filesource
 * @copyright (c) 2013-2015 Cross Solution (http://cross-solution.de)
 * @license   MIT
 */

/** ActionController of Jobs */
namespace Jobs\Controller;

use Jobs\Form\ListFilter;
use Zend\Mvc\Controller\AbstractActionController;
use Zend\Session\Container as Session;
use Jobs\Repository;
use Zend\View\Model\ViewModel;

/**
 * @method \Auth\Controller\Plugin\Auth auth()
 * @method \Core\Controller\Plugin\CreatePaginatorService paginatorService()
 *
 * Controller for jobboard actions
 */
class JobboardController extends AbstractActionController
{
    /**
     * @var Repository\Job $jobRepository
     */
    private $jobRepository;

    /**
     * Formular for searching job postings
     *
     * @var ListFilter $searchForm
     */
    private $searchForm;

    /**
     * Construct the jobboard controller
     *
     * @param Repository\Job $jobRepository
     * @param ListFilter $searchForm
     */
    public function __construct(Repository\Job $jobRepository, ListFilter $searchForm)
    {
        $this->jobRepository = $jobRepository;
        $this->searchForm = $searchForm;
    }
    /**
     * attaches further Listeners for generating / processing the output
     * @return $this
     */
    public function attachDefaultListeners()

This method seems to be duplicated in your project.

    {
        parent::attachDefaultListeners();
        $serviceLocator = $this->getServiceLocator();
        $defaultServices = $serviceLocator->get('DefaultListeners');
        $events          = $this->getEventManager();
        $events->attach($defaultServices);

$defaultServices is of type object|array, but the function expects a string.

        return $this;
    }

    /**
     * List jobs
     *
     * @return ViewModel
     */
    public function indexAction()
    {
        /* @var \Zend\Http\Request $request */
        $request          = $this->getRequest();
        $params           = $request->getQuery();
        $jsonFormat       = 'json' == $request->getQuery()->get('format');
        $event            = $this->getEvent();
        $routeMatch       = $event->getRouteMatch();
        $matchedRouteName = $routeMatch->getMatchedRouteName();
        $url              = $this->url()->fromRoute($matchedRouteName, array(), array('force_canonical' => true));

        if (!$jsonFormat && !$request->isXmlHttpRequest()) {

This code seems to be duplicated across your project.

            $session = new Session('Jobs\Index');
            $sessionKey = $this->auth()->isLoggedIn() ? 'userParams' : 'guestParams';
            $sessionParams = $session[$sessionKey];
            if ($sessionParams) {
                foreach ($sessionParams as $key => $value) {
                    $params->set($key, $params->get($key, $value));
                }
            }
            $session[$sessionKey] = $params->toArray();

            $this->searchForm->bind($params);
        }

        $params = $params->get('params', []);

        if (isset($params['l']['data']) &&
            isset($params['l']['name']) &&
            !empty($params['l']['name'])) {
            /* @var \Geo\Form\GeoText $geoText */
            $geoText = $this->searchForm->get('params')->get('l');

It seems like you code against a concrete implementation and not the interface Zend\Form\ElementInterface as the method get() does only exist in the following implementations of said interface: Applications\Form\Apply, Applications\Form\Attributes, Applications\Form\Base, Applications\Form\BaseFieldset, Applications\Form\CarbonCopyFieldset, Applications\Form\CommentForm, Applications\Form\ContactContainer, Applications\Form\Facts, Applications\Form\FactsFieldset, Applications\Form\FilterApplication, Applications\Form\Mail, Applications\Form\SettingsFieldset, Auth\Form\ForgotPassword, Auth\Form\Group, Auth\Form\GroupFieldset, Auth\Form\GroupUsersCollection, Auth\Form\Login, Auth\Form\Register, Auth\Form\SocialProfiles, Auth\Form\SocialProfilesFieldset, Auth\Form\UserBase, Auth\Form\UserBaseFieldset, Auth\Form\UserInfo, Auth\Form\UserInfoContainer, Auth\Form\UserInfoFieldset, Auth\Form\UserPassword, Auth\Form\UserPasswordFieldset, Auth\Form\UserProfileContainer, Core\Form\BaseForm, Core\Form\ButtonsFieldset, Core\Form\Container, Core\Form\DefaultButtonsFieldset, Core\Form\Form, Core\Form\FormSubmitButtonsFieldset, Core\Form\ListFilterButtonsFieldset, Core\Form\LocalizationSettingsFieldset, Core\Form\PermissionsCollection, Core\Form\PermissionsFieldset, Core\Form\RatingFieldset, Core\Form\SummaryForm, Core\Form\SummaryFormButtonsFieldset, Core\Form\ViewPartialProviderAbstract, Cv\Form\Cv, Cv\Form\CvFieldset, Cv\Form\EducationFieldset, Cv\Form\EmploymentFieldset, Cv\Form\LanguageFieldset, Cv\Form\NativeLanguageFieldset, Cv\Form\SkillFieldset, Install\Form\Installation, Jobs\Form\AtsMode, Jobs\Form\AtsModeFieldset, Jobs\Form\Base, Jobs\Form\BaseFieldset, Jobs\Form\CompanyName, Jobs\Form\CompanyNameFieldset, Jobs\Form\Import, Jobs\Form\ImportFieldset, Jobs\Form\Job, Jobs\Form\JobDescription, Jobs\Form\JobDescriptionBenefits, Jobs\Form\JobDescriptionDescription, Jobs\Form\JobDescriptionFieldset, Jobs\Form\JobDescriptionQualifications, Jobs\Form\JobDescriptionRequirements, Jobs\Form\JobDescriptionTemplate, Jobs\Form\JobDescriptionTitle, Jobs\Form\ListFilter, Jobs\Form\ListFilterAdminFieldset, Jobs\Form\ListFilterBaseFieldset, Jobs\Form\ListFilterLocationFieldset, Jobs\Form\ListFilterPersonalFieldset, Jobs\Form\Multipost, Jobs\Form\MultipostButtonFieldset, Jobs\Form\MultipostFieldset, Jobs\Form\Preview, Jobs\Form\PreviewFieldset, Jobs\Form\TemplateLabelBenefits, Jobs\Form\TemplateLabelQualifications, Jobs\Form\TemplateLabelRequirements, Organizations\Form\EmployeeFieldset, Organizations\Form\Employees, Organizations\Form\EmployeesFieldset, Organizations\Form\Organizations, Organizations\Form\OrganizationsContactFieldset, Organizations\Form\OrganizationsContactForm, Organizations\Form\OrganizationsDescriptionFieldset, Organizations\Form\OrganizationsDescriptionForm, Organizations\Form\OrganizationsFieldset, Organizations\Form\OrganizationsNameFieldset, Organizations\Form\OrganizationsNameForm, Settings\Form\AbstractSettingsForm, Settings\Form\DisableElementsCapableFormSettingsFieldset, Settings\Form\FormAbstract, Settings\Form\Settings, Settings\Form\SettingsFieldset, Zend\Form\Element\Collection, Zend\Form\Fieldset, Zend\Form\Form, Zend\Form\InputFilterProviderFieldset.

            $geoText->setValue($params['l']);
            $params['location'] = $geoText->getValue('entity');
        }

        if (!isset($params['sort'])) {
            $params['sort']='-date';
        }

        $this->searchForm->setAttribute('action', $url);

        $params['by'] = "guest";

        $paginator = $this->paginatorService('Jobs/Board', $params);

The call to JobboardController::paginatorService() has too many arguments starting with 'Jobs/Board'.

        $options = $this->searchForm->getOptions();
        $options['showButtons'] = false;
        $this->searchForm->setOptions($options);
        
        $return = array(
            'by' => $params['by'],
            'jobs' => $paginator,
            'filterForm' => $this->searchForm
        );
        $model = new ViewModel($return);

        return $model;
    }
}