EventManager::trigger() - Code Metrics - Inspection of "Fix unit tests" - cross-solution/YAWIK - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( e8d178...1ddd67 )

unknown

created 2017-03-10 16:48 UTC

EventManager::trigger() A

↳ Parent: EventManager

Complexity

Conditions	4
Paths	2

Size

Total Lines	17
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	17
rs	9.2
cc	4
eloc	7
nc	2
nop	4

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license MIT
 * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace Core\EventManager;

use Zend\EventManager\Event;
use Zend\EventManager\EventInterface;
use Zend\EventManager\EventManager as ZfEventManager;
use Zend\EventManager\Exception;

/**
 * EventPrototype Aware EventManager implementation.
 *
 * @internal
 *      Will be obsolete with ZF3 as ZF3s' EventManager implementation is
 *      already event prototype aware.
 * 
 * @author Mathias Gelhausen <[email protected]>
 * @since 0.25
 */
class EventManager extends ZfEventManager implements EventProviderInterface
{

    /**
     * The event prototype.
     *
     * @var EventInterface
     */
    protected $eventPrototype;

    public function setEventPrototype(EventInterface $event)
    {
        $this->eventPrototype = $event;
        $this->setEventClass(get_class($event));


        return $this;
    }

    public function getEvent($name = null, $target = null, $params = null)
    {
        if (!$this->eventPrototype) {
            $this->setEventPrototype(new Event());
        }

        $event = clone $this->eventPrototype;

        if (is_array($name)) {
            $params = $name;
            $name = null;

        } else if (is_array($target)) {
            $params = $target;
            $target = null;
        }

        if (!$name && isset($params['name'])) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $name = $params['name'];
            unset($params['name']);
        }

        if (!$target && isset($params['target'])) {

            $target = $params['target'];
            unset($params['target']);
        }

        $event->setName($name);
        if (null !== $target) { $event->setTarget($target); }
        if (null !== $params) { $event->setParams($params); }
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $event;
    }

    public function trigger($event, $target = null, $argv = [], $callback = null)
    {
        if (!$event instanceOf EventInterface
            && !$target instanceOf EventInterface
            && !$argv instanceOf EventInterface
        ) {
            /*
             * Create the event from the prototype, and not
             * from eventClass as the parent implementation does.
             */
            $e = $this->getEvent($event, $target, $argv);


            return parent::trigger($e, $callback);

        }

        return parent::trigger($event, $target, $argv, $callback);
    }


}

1		<?php
2		/**
3		* YAWIK
4		*
5		* @filesource
6		* @license MIT
7		* @copyright 2013 - 2016 Cross Solution <http://cross-solution.de>
8		*/
9
10		/** */
11		namespace Core\EventManager;
12
13		use Zend\EventManager\Event;
14		use Zend\EventManager\EventInterface;
15		use Zend\EventManager\EventManager as ZfEventManager;
16		use Zend\EventManager\Exception;
17
18		/**
19		* EventPrototype Aware EventManager implementation.
20		*
21		* @internal
22		* Will be obsolete with ZF3 as ZF3s' EventManager implementation is
23		* already event prototype aware.
24		*
25		* @author Mathias Gelhausen <[email protected]>
26		* @since 0.25
27		*/
28		class EventManager extends ZfEventManager implements EventProviderInterface
29		{
30
31		/**
32		* The event prototype.
33		*
34		* @var EventInterface
35		*/
36		protected $eventPrototype;
37
38		public function setEventPrototype(EventInterface $event)
39		{
40		$this->eventPrototype = $event;
41		$this->setEventClass(get_class($event));
		0 ignored issues – show Deprecated Code introduced 2016-04-07 17:16 UTC by Report Bug Copy Issue Report The method `Zend\EventManager\EventManager::setEventClass()` has been deprecated with message: This method is deprecated with 2.6.0, and will be removed in 3.0.0. See {@link https://github.com/zendframework/zend-eventmanager/blob/develop/doc/book/migration/removed.md} for details. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
42
43		return $this;
44		}
45
46		public function getEvent($name = null, $target = null, $params = null)
47		{
48		if (!$this->eventPrototype) {
49		$this->setEventPrototype(new Event());
50		}
51
52		$event = clone $this->eventPrototype;
53
54		if (is_array($name)) {
55		$params = $name;
56		$name = null;
57
58		} else if (is_array($target)) {
59		$params = $target;
60		$target = null;
61		}
62
63	View Code Duplication	if (!$name && isset($params['name'])) {
		0 ignored issues – show Bug Best Practice introduced 2016-04-07 17:16 UTC by Report Bug Copy Issue Report The expression `$name` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Duplication introduced 2016-04-07 17:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		$name = $params['name'];
65		unset($params['name']);
66		}
67
68	View Code Duplication	if (!$target && isset($params['target'])) {
		0 ignored issues – show Duplication introduced 2016-04-07 17:16 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
69		$target = $params['target'];
70		unset($params['target']);
71		}
72
73		$event->setName($name);
74		if (null !== $target) { $event->setTarget($target); }
75		if (null !== $params) { $event->setParams($params); }
		0 ignored issues – show Documentation introduced 2017-03-10 16:54 UTC by Report Bug Copy Issue Report `$params` is of type `array\|object<Traversable>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
76
77		return $event;
78		}
79
80		public function trigger($event, $target = null, $argv = [], $callback = null)
81		{
82		if (!$event instanceOf EventInterface
83		&& !$target instanceOf EventInterface
84		&& !$argv instanceOf EventInterface
85		) {
86		/*
87		* Create the event from the prototype, and not
88		* from eventClass as the parent implementation does.
89		*/
90		$e = $this->getEvent($event, $target, $argv);
		0 ignored issues – show Bug introduced 2016-04-28 12:00 UTC by Report Bug Copy Issue Report It seems like `$target` defined by parameter `$target` on line 80 can also be of type `string`; however, `Core\EventManager\EventManager::getEvent()` does only seem to accept `array\|object\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
91
92		return parent::trigger($e, $callback);
		0 ignored issues – show Bug introduced 2016-04-07 17:16 UTC by Report Bug Copy Issue Report It seems like `$callback` defined by parameter `$callback` on line 80 can also be of type `callable`; however, `Zend\EventManager\EventManager::trigger()` does only seem to accept `string\|object\|null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
93		}
94
95		return parent::trigger($event, $target, $argv, $callback);
96		}
97
98
99		}

cross-solution / YAWIK

Push — develop ( e8d178...1ddd67 )

EventManager::trigger() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like