Core\EventManager\EventManager

Complexity

Total Complexity

15

Size/Duplication

Total Lines	72
Duplicated Lines	11.11 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setEventPrototype()	0	7	1
A	trigger()	0	17	4
D	getEvent()	8	33	10

<?php
/**
 * YAWIK
 *
 * @filesource
 * @license MIT
 * @copyright  2013 - 2016 Cross Solution <http://cross-solution.de>
 */
  
/** */
namespace Core\EventManager;

use Zend\EventManager\Event;
use Zend\EventManager\EventInterface;
use Zend\EventManager\EventManager as ZfEventManager;
use Zend\EventManager\Exception;

/**
 * EventPrototype Aware EventManager implementation.
 *
 * @internal
 *      Will be obsolete with ZF3 as ZF3s' EventManager implementation is
 *      already event prototype aware.
 * 
 * @author Mathias Gelhausen <gelhausen@cross-solution.de>
 * @since 0.25
 */
class EventManager extends ZfEventManager implements EventProviderInterface
{

    /**
     * The event prototype.
     *
     * @var EventInterface
     */
    protected $eventPrototype;

    public function setEventPrototype(EventInterface $event)
    {
        $this->eventPrototype = $event;
        $this->setEventClass(get_class($event));

The method Zend\EventManager\EventManager::setEventClass() has been deprecated with message: This method is deprecated with 2.6.0, and will be removed in 3.0.0. See {@link https://github.com/zendframework/zend-eventmanager/blob/develop/doc/book/migration/removed.md} for details.

        return $this;
    }

    public function getEvent($name = null, $target = null, $params = null)
    {
        if (!$this->eventPrototype) {
            $this->setEventPrototype(new Event());
        }

        $event = clone $this->eventPrototype;

        if (is_array($name)) {
            $params = $name;
            $name = null;

        } else if (is_array($target)) {
            $params = $target;
            $target = null;
        }

        if (!$name && isset($params['name'])) {

The expression $name of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

This code seems to be duplicated across your project.

            $name = $params['name'];
            unset($params['name']);
        }

        if (!$target && isset($params['target'])) {

This code seems to be duplicated across your project.

            $target = $params['target'];
            unset($params['target']);
        }

        $event->setName($name);
        if (null !== $target) { $event->setTarget($target); }
        if (null !== $params) { $event->setParams($params); }

$params is of type array|object<Traversable>, but the function expects a string.

        return $event;
    }

    public function trigger($event, $target = null, $argv = [], $callback = null)
    {
        if (!$event instanceOf EventInterface
            && !$target instanceOf EventInterface
            && !$argv instanceOf EventInterface
        ) {
            /*
             * Create the event from the prototype, and not
             * from eventClass as the parent implementation does.
             */
            $e = $this->getEvent($event, $target, $argv);

It seems like $target defined by parameter $target on line 80 can also be of type string; however, Core\EventManager\EventManager::getEvent() does only seem to accept array|object|null, maybe add an additional type check?

            return parent::trigger($e, $callback);

It seems like $callback defined by parameter $callback on line 80 can also be of type callable; however, Zend\EventManager\EventManager::trigger() does only seem to accept string|object|null, maybe add an additional type check?

        }

        return parent::trigger($event, $target, $argv, $callback);
    }


}