Worker::doJob() - Code Metrics - cronario/messenger - Measure and Improve Code Quality continuously with Scrutinizer

Worker::doJob() C
last analyzed 2015-12-11 11:05 UTC

↳ Parent: Worker

Complexity

Conditions	10
Paths	24

Size

Total Lines	48
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	22
CRAP Score	10.3638

Importance

Changes	4
Bugs	2	Features	1

Metric	Value
c	4
b	2
f	1
dl	0
loc	48
ccs	22
cts	26
cp	0.8462
rs	5.3455
cc	10
eloc	25
nc	24
nop	1
crap	10.3638

How to fix Complexity

<?php

namespace Messenger\Curl;

use Cronario\AbstractJob;
use Cronario\AbstractWorker;
use Cronario\Logger;
use Messenger\CurlWrapper;
use Messenger\CurlWrapperCurlException;
use Messenger\CurlWrapperException;

/**
 * Class Worker
 *
 * @package Messenger\Curl
 */
class Worker extends AbstractWorker
{


    // region HELPERS ********************************************************

    /**
     * @param $what
     * @param $where
     *
     * @return bool
     */
    protected function isContain($what, $where)
    {
        if (empty($what)) {
            return true;
        }

        if (empty($where)) {
            return false;
        }

        if (strpos((string) $where, (string) $what) !== false) {
            return true;
        }

        return false;
    }

    // endregion *************************************************************

    /**
     * @param AbstractJob $job
     *
     * @throws ResultException
     */
    protected function doJob(AbstractJob $job)
    {
        /** @var $job Job */
        $resultData = null;

        try {
            $curl = new CurlWrapper();
            $curl->request($job->getUrl(), $job->getMethod(), $job->getRequestParams());

            $response['content'] = $curl->getResponse();
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $response['info'] = $curl->getTransferInfo();

        } catch (CurlWrapperCurlException $a) {
            $job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
            throw new ResultException(ResultException::ERROR_CURL);
        } catch (CurlWrapperException $a) {
            $job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
            throw new ResultException(ResultException::ERROR_CURL);
        } catch (\Exception $a) {
            $job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
            throw new ResultException(ResultException::ERROR_CURL);
        }

        /**
         * saving data
         */
        if ($job->getSaveContent()) {
            $resultData['content'] = $response['content'];
        }

        if ($job->getSaveInfo()) {
            $resultData['info'] = $response['info'];
        }

        /**
         * analise response
         */
        if ($job->getExpectCode() && $job->getExpectCode() != $response['info']['http_code']) {
            throw new ResultException(ResultException::RETRY_EXPECTED_HTTP_CODE, $resultData);

        } elseif ($job->getExpectContent() && !$this->isContain($job->getExpectContent(), $response['content'])) {
            throw new ResultException(ResultException::RETRY_EXPECTED_CONTENT, $resultData);
        }

        /**
         * success result
         */
        throw new ResultException(ResultException::R_SUCCESS, $resultData);
    }

}

1		<?php
2
3		namespace Messenger\Curl;
4
5		use Cronario\AbstractJob;
6		use Cronario\AbstractWorker;
7		use Cronario\Logger;
8		use Messenger\CurlWrapper;
9		use Messenger\CurlWrapperCurlException;
10		use Messenger\CurlWrapperException;
11
12		/**
13		* Class Worker
14		*
15		* @package Messenger\Curl
16		*/
17		class Worker extends AbstractWorker
18		{
19
20
21		// region HELPERS ********************************************************
22
23		/**
24		* @param $what
25		* @param $where
26		*
27		* @return bool
28		*/
29	1	protected function isContain($what, $where)
30		{
31	1	if (empty($what)) {
32		return true;
33		}
34
35	1	if (empty($where)) {
36		return false;
37		}
38
39	1	if (strpos((string) $where, (string) $what) !== false) {
40		return true;
41		}
42
43	1	return false;
44		}
45
46		// endregion *************************************************************
47
48		/**
49		* @param AbstractJob $job
50		*
51		* @throws ResultException
52		*/
53	5	protected function doJob(AbstractJob $job)
54		{
55		/** @var $job Job */
56	5	$resultData = null;
57
58		try {
59	5	$curl = new CurlWrapper();
60	5	$curl->request($job->getUrl(), $job->getMethod(), $job->getRequestParams());
		0 ignored issues – show Bug introduced 2015-12-10 09:29 UTC by Report Bug Copy Issue Report It seems like `$job->getRequestParams()` targeting `Messenger\Curl\Job::getRequestParams()` can also be of type `integer` or `string`; however, `CurlWrapper::request()` does only seem to accept `array\|null`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
61	3	$response['content'] = $curl->getResponse();
		0 ignored issues – show Coding Style Comprehensibility introduced 2015-12-10 09:29 UTC by Report Bug Copy Issue Report `$response` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$response = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
62	3	$response['info'] = $curl->getTransferInfo();
63
64	5	} catch (CurlWrapperCurlException $a) {
65		$job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
66		throw new ResultException(ResultException::ERROR_CURL);
67	2	} catch (CurlWrapperException $a) {
68		$job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
69		throw new ResultException(ResultException::ERROR_CURL);
70	2	} catch (\Exception $a) {
71	2	$job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
72	2	throw new ResultException(ResultException::ERROR_CURL);
73		}
74
75		/**
76		* saving data
77		*/
78	3	if ($job->getSaveContent()) {
79	1	$resultData['content'] = $response['content'];
80	1	}
81
82	3	if ($job->getSaveInfo()) {
83	1	$resultData['info'] = $response['info'];
84	1	}
85
86		/**
87		* analise response
88		*/
89	3	if ($job->getExpectCode() && $job->getExpectCode() != $response['info']['http_code']) {
90	1	throw new ResultException(ResultException::RETRY_EXPECTED_HTTP_CODE, $resultData);
91
92	2	} elseif ($job->getExpectContent() && !$this->isContain($job->getExpectContent(), $response['content'])) {
93	1	throw new ResultException(ResultException::RETRY_EXPECTED_CONTENT, $resultData);
94		}
95
96		/**
97		* success result
98		*/
99	1	throw new ResultException(ResultException::R_SUCCESS, $resultData);
100		}
101
102		}

cronario / messenger

Worker::doJob() C last analyzed 2015-12-11 11:05 UTC

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like

Worker::doJob() C
last analyzed 2015-12-11 11:05 UTC