Messenger\Curl\Worker

Complexity

Total Complexity

14

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Test Coverage

Coverage

79.41%

Importance

Changes	4
Bugs	2	Features	1

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isContain()	0	16	4
C	doJob()	0	48	10

<?php

namespace Messenger\Curl;

use Cronario\AbstractJob;
use Cronario\AbstractWorker;
use Cronario\Logger;
use Messenger\CurlWrapper;
use Messenger\CurlWrapperCurlException;
use Messenger\CurlWrapperException;

/**
 * Class Worker
 *
 * @package Messenger\Curl
 */
class Worker extends AbstractWorker
{


    // region HELPERS ********************************************************

    /**
     * @param $what
     * @param $where
     *
     * @return bool
     */
    protected function isContain($what, $where)
    {
        if (empty($what)) {
            return true;
        }

        if (empty($where)) {
            return false;
        }

        if (strpos((string) $where, (string) $what) !== false) {
            return true;
        }

        return false;
    }

    // endregion *************************************************************

    /**
     * @param AbstractJob $job
     *
     * @throws ResultException
     */
    protected function doJob(AbstractJob $job)
    {
        /** @var $job Job */
        $resultData = null;

        try {
            $curl = new CurlWrapper();
            $curl->request($job->getUrl(), $job->getMethod(), $job->getRequestParams());

It seems like $job->getRequestParams() targeting Messenger\Curl\Job::getRequestParams() can also be of type integer or string; however, CurlWrapper::request() does only seem to accept array|null, maybe add an additional type check?

            $response['content'] = $curl->getResponse();

$response was never initialized. Although not strictly required by PHP, it is generally a good practice to add $response = array(); before regardless.

            $response['info'] = $curl->getTransferInfo();

        } catch (CurlWrapperCurlException $a) {
            $job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
            throw new ResultException(ResultException::ERROR_CURL);
        } catch (CurlWrapperException $a) {
            $job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
            throw new ResultException(ResultException::ERROR_CURL);
        } catch (\Exception $a) {
            $job->addDebug(['CurlWrapperCurlException' => $a->getMessage()]);
            throw new ResultException(ResultException::ERROR_CURL);
        }

        /**
         * saving data
         */
        if ($job->getSaveContent()) {
            $resultData['content'] = $response['content'];
        }

        if ($job->getSaveInfo()) {
            $resultData['info'] = $response['info'];
        }

        /**
         * analise response
         */
        if ($job->getExpectCode() && $job->getExpectCode() != $response['info']['http_code']) {
            throw new ResultException(ResultException::RETRY_EXPECTED_HTTP_CODE, $resultData);

        } elseif ($job->getExpectContent() && !$this->isContain($job->getExpectContent(), $response['content'])) {
            throw new ResultException(ResultException::RETRY_EXPECTED_CONTENT, $resultData);
        }

        /**
         * success result
         */
        throw new ResultException(ResultException::R_SUCCESS, $resultData);
    }

}