contamobi / CmobiRabbitmqBundle

DependencyInjection/CmobiRabbitmqExtension.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Cmobi\RabbitmqBundle\DependencyInjection;
 
-use Cmobi\RabbitmqBundle\DependencyInjection\Compiler\ConfigCachePass;
 use Cmobi\RabbitmqBundle\DependencyInjection\Compiler\LogDispatcherPass;
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\ContainerBuilder;

Tests/Transport/Rpc/RpcClientTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -130,7 +130,7 @@
 
     /**
      * @param string $msg
-     * @param null $correlationId
+     * @param string $correlationId
      * @return CmobiAMQPMessage
      */
     protected function getCmobiAMQPMessage($msg = '', $correlationId = null)

Transport/PubSub/Publisher.php

Doc Comments +3 added lines

@@ -17,6 +17,9 @@
     private $exchange;
     private $exchangeType;
 
+    /**
+     * @param string $exchange
+     */
     public function __construct(
         $exchange,
         $exchangeType = ExchangeType::FANOUT,

Spacing +1 added lines, -1 removed lines

@@ -58,7 +58,7 @@
         /** @var CmobiAMQPConnectionInterface $connection */
         $connection = $this->connectionManager->getConnection();
 
-        if (! $connection->isConnected()) {
+        if (!$connection->isConnected()) {
             $connection->reconnect();
         }
         $this->channel = $connection->channel();

Transport/PubSub/SubscriberBuilder.php

Doc Comments +4 added lines, -1 removed lines

@@ -17,6 +17,9 @@ 
     private $logger;
     private $parameters;
 
+    /**
+     * @param string $exchangeName
+     */
     public function __construct(
         $exchangeName,
         $exchangeType = ExchangeType::FANOUT,
@@ -34,7 +37,7 @@ 
     }
 
     /**
-     * @param $queueName
+     * @param string $queueName
      * @param QueueServiceInterface $queueService
      *
      * @return Queue

Transport/Rpc/RpcClient.php

Doc Comments +7 added lines, -4 removed lines

@@ -18,6 +18,9 @@ 
     private $correlationId;
     private $callbackQueue;
 
+    /**
+     * @param string $queueName
+     */
     public function __construct($queueName, ConnectionManager $manager, $fromName = '')
     {
         $this->queueName = $queueName;
@@ -52,7 +55,7 @@ 
     }
 
     /**
-     * @param $data
+     * @param string $data
      * @param int $expire
      * @param int $priority
      */
@@ -118,7 +121,7 @@ 
     /**
      * @todo unecessary method set, its only exists to run tests whitout stay jailed in infinite while waiting response.
      *
-     * @param $content
+     * @param string $content
      */
     public function setResponse($content)
     {
@@ -148,7 +151,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchange()
     {
@@ -156,7 +159,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchangeType()
     {

Spacing +5 added lines, -5 removed lines

@@ -30,7 +30,7 @@ 
      */
     public function onResponse(AMQPMessage $rep)
     {
-        if($rep->get('correlation_id') === $this->correlationId) {
+        if ($rep->get('correlation_id') === $this->correlationId) {
             $this->response = $rep->getBody();
         }
     }
@@ -43,7 +43,7 @@ 
     {
         $connection = $this->connectionManager->getConnection();
 
-        if (! $connection->isConnected()) {
+        if (!$connection->isConnected()) {
             $connection->reconnect();
         }
         $this->channel = $connection->channel();
@@ -66,7 +66,7 @@ 
         $queueBag->setArguments([
             'x-expires' => ['I', $expire]
         ]);
-        list($callbackQueue, ,) = $this->getChannel()->queueDeclare($queueBag->getQueueDeclare());
+        list($callbackQueue,,) = $this->getChannel()->queueDeclare($queueBag->getQueueDeclare());
         $this->callbackQueue = $callbackQueue;
         $consumeQueueBag = new RpcQueueBag($callbackQueue);
 
@@ -84,7 +84,7 @@ 
         );
         $this->getChannel()->basic_publish($msg, '', $this->getQueueName());
 
-        while(! $this->response) {
+        while (!$this->response) {
             $this->getChannel()->wait(null, 0, ($expire / 1000));
         }
         $this->getChannel()->close();
@@ -136,7 +136,7 @@ 
     /** @return string */
     public function generateCorrelationId()
     {
-        return uniqid($this->getQueueName()) . microtime();
+        return uniqid($this->getQueueName()).microtime();
     }
 
     /**

Transport/Rpc/RpcQueueBag.php

Doc Comments +2 added lines, -2 removed lines

@@ -274,7 +274,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchange()
     {
@@ -282,7 +282,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getType()
     {

Transport/Rpc/RpcServerBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     }
 
     /**
-     * @param $queueName
+     * @param string $queueName
      * @param QueueServiceInterface $queueService
      *
      * @return Queue

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Cmobi\RabbitmqBundle\Transport\Rpc;
 
-use Cmobi\RabbitmqBundle\Connection\CmobiAMQPChannel;
-use Cmobi\RabbitmqBundle\Connection\CmobiAMQPConnectionInterface;
 use Cmobi\RabbitmqBundle\Connection\ConnectionManager;
 use Cmobi\RabbitmqBundle\Connection\Exception\InvalidAMQPChannelException;
 use Cmobi\RabbitmqBundle\Queue\Queue;

Transport/Worker/Task.php

Doc Comments +5 added lines, -2 removed lines

@@ -15,6 +15,9 @@ 
     private $fromName;
     private $queueName;
 
+    /**
+     * @param string $queueName
+     */
     public function __construct($queueName, ConnectionManager $manager, $fromName = '')
     {
         $this->queueName = $queueName;
@@ -87,7 +90,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchange()
     {
@@ -95,7 +98,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchangeType()
     {

Spacing +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
         /** @var CmobiAMQPConnectionInterface $connection */
         $connection = $this->connectionManager->getConnection();
 
-        if (! $connection->isConnected()) {
+        if (!$connection->isConnected()) {
             $connection->reconnect();
         }
         $this->channel = $connection->channel();

Transport/Worker/WorkerBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
     }
 
     /**
-     * @param $queueName
+     * @param string $queueName
      * @param QueueServiceInterface $queueService
      *
      * @return Queue

Unused Use Statements -2 removed lines

@@ -2,8 +2,6 @@
 
 namespace Cmobi\RabbitmqBundle\Transport\Worker;
 
-use Cmobi\RabbitmqBundle\Connection\CmobiAMQPChannel;
-use Cmobi\RabbitmqBundle\Connection\CmobiAMQPConnectionInterface;
 use Cmobi\RabbitmqBundle\Connection\ConnectionManager;
 use Cmobi\RabbitmqBundle\Connection\Exception\InvalidAMQPChannelException;
 use Cmobi\RabbitmqBundle\Queue\Queue;