contamobi / CmobiRabbitmqBundle

Transport/Rpc/RpcClient.php

Doc Comments +8 added lines, -4 removed lines

@@ -22,6 +22,10 @@ 
     private $correlationId;
     private $callbackQueue;
 
+    /**
+     * @param string $queueName
+     * @param string $fromName
+     */
     public function __construct($queueName, ConnectionManager $manager, $fromName, $connectionName = 'default')
     {
         $this->connectionName = $connectionName;
@@ -43,7 +47,7 @@ 
     }
 
     /**
-     * @param $data
+     * @param string $data
      * @param int $expire
      * @param int $priority
      * @throws QueueNotFoundException
@@ -133,7 +137,7 @@ 
     /**
      * @todo unecessary method set, its only exists to run tests whitout stay jailed in infinite while waiting response.
      *
-     * @param $content
+     * @param string $content
      */
     public function setResponse($content)
     {
@@ -163,7 +167,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchange()
     {
@@ -171,7 +175,7 @@ 
     }
 
     /**
-     * @return string
+     * @return boolean
      */
     public function getExchangeType()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Cmobi\RabbitmqBundle\Transport\Rpc;
 
 use Cmobi\RabbitmqBundle\Connection\CmobiAMQPChannel;
-use Cmobi\RabbitmqBundle\Connection\CmobiAMQPConnection;
 use Cmobi\RabbitmqBundle\Connection\ConnectionManager;
 use Cmobi\RabbitmqBundle\Queue\CmobiAMQPMessage;
 use Cmobi\RabbitmqBundle\Queue\QueueProducerInterface;

Spacing +4 added lines, -4 removed lines

@@ -55,7 +55,7 @@ 
         $connection = $this->connectionManager->getConnection($this->connectionName);
         $channel = $connection->channel();
 
-        if (! $this->queueHasExists($channel)) {
+        if (!$this->queueHasExists($channel)) {
             throw new QueueNotFoundException("Queue $this->queueName not declared.");
         }
         $this->correlationId = $this->generateCorrelationId();
@@ -80,7 +80,7 @@ 
             [$this, 'onResponse']
         );
         $msg = new CmobiAMQPMessage(
-            (string) $data,
+            (string)$data,
             [
                 'correlation_id' => $this->correlationId,
                 'reply_to' => $this->callbackQueue,
@@ -89,7 +89,7 @@ 
         );
         $channel->basic_publish($msg, '', $this->getQueueName());
 
-        while (! $this->response) {
+        while (!$this->response) {
             $channel->wait(null, 0, ($expire / 1000));
         }
         $channel->close();
@@ -151,7 +151,7 @@ 
     /** @return string */
     public function generateCorrelationId()
     {
-        return uniqid($this->getQueueName()) . Uuid::uuid4()->toString() . microtime();
+        return uniqid($this->getQueueName()).Uuid::uuid4()->toString().microtime();
     }
 
     /**

Queue/Queue.php

Spacing +3 added lines, -3 removed lines

@@ -143,17 +143,17 @@
         do {
             try {
                 $failed = false;
-                fwrite($this->logOutput, 'start Queue::forceReconnect() - trying connect...' . PHP_EOL);
+                fwrite($this->logOutput, 'start Queue::forceReconnect() - trying connect...'.PHP_EOL);
                 $this->connection = $this->getConnectionManager()->getConnection($this->connectionName);
                 $this->channel = $this->getConnection()->channel();
                 $this->createQueue();
             } catch (\Exception $e) {
                 $failed = true;
                 sleep(3);
-                fwrite($this->logOutput, 'failed Queue::forceReconnect() - ' . $e->getMessage() . PHP_EOL);
+                fwrite($this->logOutput, 'failed Queue::forceReconnect() - '.$e->getMessage().PHP_EOL);
             }
         } while ($failed);
-        fwrite($this->logOutput, 'Queue::forceReconnect() - connected!' . PHP_EOL);
+        fwrite($this->logOutput, 'Queue::forceReconnect() - connected!'.PHP_EOL);
 
         return $this->channel;
     }