View GitHub Repository CmobiRabbitmqBundle

Schedule Inspection
Subscribe
Completed
Push — master ( bf6474...78183b )
by Daniel
11:37
created
Status
Category
Toggle Patches
Transport/Rpc/RpcClient.php 2 patches
Doc Comments   +7 added lines, -4 removed lines patch added patch discarded remove patch 
@@ -19,6 +19,9 @@  discard block
 
 block discarded – undo
19 19 
     private $correlationId;
20 20 
     private $callbackQueue;
21 21
22 
+    /**
23 
+     * @param string $queueName
24 
+     */
22 25 
     public function __construct($queueName, ConnectionManager $manager, $fromName = '')
23 26 
     {
24 27 
         $this->queueName = $queueName;
 
@@ -54,7 +57,7 @@  discard block
 
 block discarded – undo
54 57 
     }
55 58
56 59 
     /**
57 
-     * @param $data
60 
+     * @param string $data
58 61 
      * @param int $expire
59 62 
      * @param int $priority
60 63 
      * @throws QueueNotFoundException
 
@@ -140,7 +143,7 @@  discard block
 
 block discarded – undo
140 143 
     /**
141 144 
      * @todo unecessary method set, its only exists to run tests whitout stay jailed in infinite while waiting response.
142 145 
      *
143 
-     * @param $content
146 
+     * @param string $content
144 147 
      */
145 148 
     public function setResponse($content)
146 149 
     {
 
@@ -170,7 +173,7 @@  discard block
 
 block discarded – undo
170 173 
     }
171 174
172 175 
     /**
173 
-     * @return string
176 
+     * @return boolean
174 177 
      */
175 178 
     public function getExchange()
176 179 
     {
 
@@ -178,7 +181,7 @@  discard block
 
 block discarded – undo
178 181 
     }
179 182
180 183 
     /**
181 
-     * @return string
184 
+     * @return boolean
182 185 
      */
183 186 
     public function getExchangeType()
184 187 
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch 
@@ -64,7 +64,7 @@  discard block
 
 block discarded – undo
64 64 
     {
65 65 
         $this->refreshChannel();
66 66
67 
-        if (! $this->queueHasExists()) {
67 
+        if (!$this->queueHasExists()) {
68 68 
             throw new QueueNotFoundException("Queue $this->queueName not declared.");
69 69 
         }
70 70 
         $this->correlationId = $this->generateCorrelationId();
 
@@ -83,7 +83,7 @@  discard block
 
 block discarded – undo
83 83 
             [$this, 'onResponse']
84 84 
         );
85 85 
         $msg = new CmobiAMQPMessage(
86 
-            (string) $data,
86 
+            (string)$data,
87 87 
             [
88 88 
                 'correlation_id' => $this->correlationId,
89 89 
                 'reply_to' => $this->callbackQueue,
 
@@ -92,7 +92,7 @@  discard block
 
 block discarded – undo
92 92 
         );
93 93 
         $this->getChannel()->basic_publish($msg, '', $this->getQueueName());
94 94
95 
-        while (! $this->response) {
95 
+        while (!$this->response) {
96 96 
             $this->getChannel()->wait(null, 0, ($expire / 1000));
97 97 
         }
98 98 
         $this->getChannel()->close();
Please login to merge, or discard this patch.
Transport/Worker/Task.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch 
@@ -34,13 +34,13 @@
 
 block discarded – undo
34 34 
     {
35 35 
         $this->refreshChannel();
36 36
37 
-        if (! $this->queueHasExists()) {
37 
+        if (!$this->queueHasExists()) {
38 38 
             throw new QueueNotFoundException("Queue $this->queueName not declared.");
39 39 
         }
40 40 
         $queueBag = new WorkerQueueBag($this->getQueueName());
41 41 
         $this->getChannel()->queueDeclare($queueBag->getQueueDeclare());
42 42 
         $msg = new CmobiAMQPMessage(
43 
-            (string) $data,
43 
+            (string)$data,
44 44 
             [
45 45 
                 'delivery_mode' => 2, // make message persistent
46 46 
                 'priority' => $priority,
Please login to merge, or discard this patch.