Completed
Pull Request — master (#19)
by Moshe
01:18
created
src/ProcessBase.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Consolidation\SiteProcess;
4 4
 
5
-use Drush\Drush;
6 5
 use Psr\Log\LoggerInterface;
7
-use Robo\Common\IO;
8 6
 use Symfony\Component\Console\Style\OutputStyle;
9 7
 use Symfony\Component\Process\Process;
10 8
 use Consolidation\SiteProcess\Util\RealtimeOutputHandler;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -50,6 +50,9 @@  discard block
 block discarded – undo
50 50
         return $this->output;
51 51
     }
52 52
 
53
+    /**
54
+     * @return \Symfony\Component\Console\Output\OutputInterface
55
+     */
53 56
     protected function realtimeStderr()
54 57
     {
55 58
         if ($this->stderr) {
@@ -165,7 +168,7 @@  discard block
 block discarded – undo
165 168
     /**
166 169
      * Return a realTime output object.
167 170
      *
168
-     * @return callable
171
+     * @return RealtimeOutputHandler
169 172
      */
170 173
     public function showRealtime()
171 174
     {
Please login to merge, or discard this patch.
src/SiteProcess.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,6 @@
 block discarded – undo
145 145
      * It is possible to use dot notation in the keys to access nested elements
146 146
      * within the site alias record.
147 147
      *
148
-     * @param AliasRecord $siteAlias
149 148
      * @param type $args
150 149
      * @return type
151 150
      */
Please login to merge, or discard this patch.
src/Transport/TransportInterface.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,6 +13,7 @@  discard block
 block discarded – undo
13 13
     /**
14 14
      * Configure ourselves based on the settings of the process object
15 15
      * (e.g. isTty()).
16
+     * @return void
16 17
      */
17 18
     public function configure(Process $process);
18 19
 
@@ -22,7 +23,6 @@  discard block
 block discarded – undo
22 23
      * alias points at a remote system, though, then the arguments are
23 24
      * escaped and wrapped in an appropriate ssh command.
24 25
      *
25
-     * @param AliasRecord $siteAlias alias record of target site.
26 26
      * @param array $args arguments provided by caller.
27 27
      * @return array command and arguments to execute.
28 28
      */
Please login to merge, or discard this patch.
src/Util/ArgumentProcessor.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 namespace Consolidation\SiteProcess\Util;
3 3
 
4 4
 use Consolidation\SiteAlias\AliasRecord;
5
-use Symfony\Component\Process\Process;
6
-use Consolidation\SiteProcess\Transport\TransportInterface;
7 5
 
8 6
 /**
9 7
  * ArgumentProcessor takes a set of arguments and options from the caller
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -18,10 +18,10 @@
 block discarded – undo
18 18
      * to be executed and orders them as needed.
19 19
      *
20 20
      * @param AliasRecord $siteAlias Description of
21
-     * @param array $args Command and arguments to execute (source)
22
-     * @param array $options key / value pair of option and value in include
21
+     * @param string[] $args Command and arguments to execute (source)
22
+     * @param string[] $options key / value pair of option and value in include
23 23
      *   in final arguments
24
-     * @param array $optionsPassedAsArgs key / value pair of option and value
24
+     * @param string[] $optionsPassedAsArgs key / value pair of option and value
25 25
      *   to include in final arguments after the '--' argument.
26 26
      * @return array Command and arguments to execute
27 27
      */
Please login to merge, or discard this patch.
src/Remo/RemoCommands.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace Consolidation\SiteProcess\Remo;
4 4
 
5 5
 use Consolidation\SiteProcess\SiteProcess;
6
-
7
-use Consolidation\SiteAlias\SiteAliasManagerAwareInterface;
8 6
 use Consolidation\SiteAlias\SiteAliasManagerAwareTrait;
9 7
 use Consolidation\SiteAlias\SiteAliasManager;
10 8
 
Please login to merge, or discard this patch.
src/Util/RealtimeOutputHandler.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -109,6 +109,8 @@
 block discarded – undo
109 109
 
110 110
     /**
111 111
      * Make sure that every line in $buffer begins with a MARKER_ERR.
112
+     * @param string $buffer
113
+     * @param string $marker
112 114
      */
113 115
     protected function addMarker($buffer, $marker)
114 116
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,9 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\SiteProcess\Util;
3 3
 
4
-use Consolidation\SiteAlias\AliasRecord;
5 4
 use Symfony\Component\Process\Process;
6
-use Consolidation\Config\Util\Interpolator;
7 5
 use Symfony\Component\Console\Output\OutputInterface;
8 6
 use Symfony\Component\Console\Output\NullOutput;
9 7
 
Please login to merge, or discard this patch.
src/Transport/DockerComposeTransport.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -50,6 +50,7 @@
 block discarded – undo
50 50
 
51 51
     /**
52 52
      * @inheritdoc
53
+     * @param string $cd
53 54
      */
54 55
     public function addChdir($cd, $args)
55 56
     {
Please login to merge, or discard this patch.
Unused Use Statements   -7 removed lines patch added patch discarded remove patch
@@ -2,14 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Consolidation\SiteProcess\Transport;
4 4
 
5
-use Drush\Drush;
6
-use Psr\Log\LoggerInterface;
7
-use Robo\Common\IO;
8
-use Symfony\Component\Console\Style\OutputStyle;
9 5
 use Symfony\Component\Process\Process;
10
-use Consolidation\SiteProcess\Util\RealtimeOutputHandler;
11
-use Consolidation\SiteProcess\Util\Escape;
12
-use Symfony\Component\Console\Output\ConsoleOutputInterface;
13 6
 use Consolidation\SiteAlias\AliasRecord;
14 7
 use Consolidation\SiteProcess\Util\Shell;
15 8
 
Please login to merge, or discard this patch.