consolidation / robo

src/Collection/Collection.php

Unused Use Statements -2 removed lines

@@ -2,7 +2,6 @@ 
 namespace Robo\Collection;
 
 use Robo\Result;
-use Robo\ResultData;
 use Psr\Log\LogLevel;
 use Robo\Contract\TaskInterface;
 use Robo\Task\StackBasedTask;
@@ -12,7 +11,6 @@ 
 use Robo\Exception\TaskException;
 use Robo\Exception\TaskExitException;
 use Robo\Contract\CommandInterface;
-
 use Robo\Contract\InflectionInterface;
 use Robo\State\StateAwareInterface;
 use Robo\State\StateAwareTrait;

src/Collection/CollectionBuilder.php

Doc Comments +4 added lines

@@ -76,6 +76,10 @@
         $this->resetState();
     }
 
+    /**
+     * @param \League\Container\ContainerInterface $container
+     * @param BuilderAwareInterface $commandFile
+     */
     public static function create($container, $commandFile)
     {
         $builder = new self($commandFile);

src/State/StateAwareTrait.php

Doc Comments +1 added lines

@@ -7,6 +7,7 @@
 {
     /**
      * {@inheritdoc}
+     * @return ResultData
      */
     public function getState()
     {

tests/unit/Task/CollectionTest.php

Doc Comments +8 added lines

@@ -191,6 +191,10 @@ 
     protected $key;
     protected $value;
 
+    /**
+     * @param string $key
+     * @param string $value
+     */
     public function __construct($key, $value)
     {
         $this->key = $key;
@@ -237,6 +241,10 @@ 
         return Result::success($this, '', $this->data);
     }
 
+    /**
+     * @param string $key
+     * @param string $value
+     */
     public function provideData($key, $value)
     {
         $this->data[$key] = $value;

Spacing +6 added lines, -6 removed lines

@@ -102,11 +102,11 @@ 
             ->completion($completion1)
             ->rollbackCode(function() use($rollback1) { $rollback1->run(); } )
             ->completionCode(function() use($completion1) { $completion1->run(); } )
-            ->addCode(function () { return 42; })
+            ->addCode(function() { return 42; })
             ->progressMessage("not reached")
             ->rollback($rollback2)
             ->completion($completion2)
-            ->addCode(function () { return 13; });
+            ->addCode(function() { return 13; });
 
         $collection->setLogger($this->guy->logger());
 
@@ -128,15 +128,15 @@ 
 
         $result = $collection
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['one'] = 'first';
                 })
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['two'] = 'second';
                 })
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -159,7 +159,7 @@ 
             ->add($first)
             ->add($second)
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();

tests/unit/Common/ResultDataTest.php

Spacing +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
         $a = new ResultData(ResultData::EXITCODE_OK, '', ['one' => 'first', 'two' => 'second']);
 
         $to_be_merged = [
-            ['one' => 'ignored',],
-            ['three' => 'new',],
+            ['one' => 'ignored', ],
+            ['three' => 'new', ],
         ];
 
         foreach ($to_be_merged as $mergeThis) {