consolidation / robo

src/Collection/Collection.php

Unused Use Statements -2 removed lines

@@ -2,7 +2,6 @@ 
 namespace Robo\Collection;
 
 use Robo\Result;
-use Robo\ResultData;
 use Psr\Log\LogLevel;
 use Robo\Contract\TaskInterface;
 use Robo\Task\StackBasedTask;
@@ -12,7 +11,6 @@ 
 use Robo\Exception\TaskException;
 use Robo\Exception\TaskExitException;
 use Robo\Contract\CommandInterface;
-
 use Robo\Contract\InflectionInterface;
 use Robo\State\StateAwareInterface;
 use Robo\State\StateAwareTrait;

Doc Comments +6 added lines, -5 removed lines

@@ -207,7 +207,7 @@ 
      *
      * @param string $method
      * @param string $name
-     * @param callable|TaskInterface $task
+     * @param callable $task
      * @param string $nameOfTaskToAdd
      *
      * @return $this
@@ -276,7 +276,7 @@ 
     /**
      * Return the list of task names added to this collection.
      *
-     * @return array
+     * @return integer[]
      */
     public function taskNames()
     {
@@ -349,7 +349,7 @@ 
     }
 
     /**
-     * @param int|string $name
+     * @param string $name
      * @param \Robo\Collection\Element $taskGroup
      *
      * @return $this
@@ -635,7 +635,7 @@ 
     }
 
     /**
-     * @param TaskInterface|NestedCollectionInterface|WrappedTaskInterface $task
+     * @param TaskInterface $task
      *
      * @return \Robo\Result
      */
@@ -689,6 +689,7 @@ 
      * runs. Use this time to provide more settings for the task, e.g. from
      * the collection's shared state, which is populated with the results
      * of previous test runs.
+     * @param \Closure $callback
      */
     public function defer($task, $callback)
     {
@@ -711,7 +712,7 @@ 
 
     /**
      * @param TaskInterface|NestedCollectionInterface|WrappedTaskInterface $task
-     * @param $parentCollection
+     * @param CollectionInterface $parentCollection
      */
     protected function setParentCollectionForTask($task, $parentCollection)
     {

Spacing +5 added lines, -5 removed lines

@@ -135,7 +135,7 @@ 
     {
         $collection = $this;
         $completionRegistrationTask = new CallableTask(
-            function () use ($collection, $completionTask) {
+            function() use ($collection, $completionTask) {
 
                 $collection->registerCompletion($completionTask);
             },
@@ -178,7 +178,7 @@ 
         $context += ['name' => 'Progress'];
         $context += TaskInfo::getTaskContext($this);
         return $this->addCode(
-            function () use ($level, $text, $context) {
+            function() use ($level, $text, $context) {
                 $this->printTaskOutput($level, $text, $context);
             }
         );
@@ -193,7 +193,7 @@ 
     {
         $collection = $this;
         $rollbackRegistrationTask = new CallableTask(
-            function () use ($collection, $rollbackTask) {
+            function() use ($collection, $rollbackTask) {
                 $collection->registerRollback($rollbackTask);
             },
             $this
@@ -246,7 +246,7 @@ 
         if ($task instanceof StackBasedTask) {
             $task->stopOnFail(false);
         }
-        $ignoreErrorsInTask = function () use ($task) {
+        $ignoreErrorsInTask = function() use ($task) {
             $data = [];
             try {
                 $result = $this->runSubtask($task);
@@ -676,7 +676,7 @@ 
     {
         return $this->defer(
             $task,
-            function ($task, $state) use ($functionName, $stateKey) {
+            function($task, $state) use ($functionName, $stateKey) {
                 $fn = [$task, $functionName];
                 $value = $state[$stateKey];
                 $fn($value);

tests/unit/Common/ResultDataTest.php

Spacing +2 added lines, -2 removed lines

@@ -33,8 +33,8 @@
         $a = new ResultData(ResultData::EXITCODE_OK, '', ['one' => 'first', 'two' => 'second']);
 
         $to_be_merged = [
-            ['one' => 'ignored',],
-            ['three' => 'new',],
+            ['one' => 'ignored', ],
+            ['three' => 'new', ],
         ];
 
         foreach ($to_be_merged as $mergeThis) {

tests/unit/Task/CollectionTest.php

Spacing +8 added lines, -8 removed lines

@@ -102,11 +102,11 @@ 
             ->completion($completion1)
             ->rollbackCode(function() use($rollback1) { $rollback1->run(); } )
             ->completionCode(function() use($completion1) { $completion1->run(); } )
-            ->addCode(function () { return 42; })
+            ->addCode(function() { return 42; })
             ->progressMessage("not reached")
             ->rollback($rollback2)
             ->completion($completion2)
-            ->addCode(function () { return 13; });
+            ->addCode(function() { return 13; });
 
         $collection->setLogger($this->guy->logger());
 
@@ -128,15 +128,15 @@ 
 
         $result = $collection
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['one'] = 'first';
                 })
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['two'] = 'second';
                 })
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -159,7 +159,7 @@ 
             ->add($first)
             ->add($second)
             ->addCode(
-                function (ResultData $state) {
+                function(ResultData $state) {
                     $state['three'] = "{$state['one']} and {$state['two']}";
                 })
             ->run();
@@ -187,7 +187,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )
@@ -218,7 +218,7 @@ 
             ->add($third)
                 ->defer(
                     $third,
-                    function ($task, $state) {
+                    function($task, $state) {
                         $task->provideData('three', "{$state['one']} and {$state['two']}");
                     }
                 )

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 
 use Robo\Result;
 use Robo\ResultData;
-use Robo\Task\BaseTask;
 use Robo\Collection\Collection;
 use Robo\Task\ValueProviderTask;
 use Robo\Task\CollectionTestTask;

src/Collection/CollectionBuilder.php

Doc Comments +7 added lines

@@ -76,6 +76,10 @@ 
         $this->resetState();
     }
 
+    /**
+     * @param \League\Container\ContainerInterface $container
+     * @param BuilderAwareInterface $commandFile
+     */
     public static function create($container, $commandFile)
     {
         $builder = new self($commandFile);
@@ -284,6 +288,9 @@ 
         return $this->callCollectionStateFuntion(__FUNCTION__, func_get_args());
     }
 
+    /**
+     * @param string $functionName
+     */
     protected function callCollectionStateFuntion($functionName, $args)
     {
         $currentTask = ($this->currentTask instanceof WrappedTaskInterface) ? $this->currentTask->original() : $this->currentTask;

tests/_helpers/CliHelper.php

Unused Use Statements -3 removed lines

@@ -3,10 +3,7 @@
 
 use Robo\Robo;
 use Robo\Collection\CollectionBuilder;
-use Robo\Task\ValueProviderTask;
-
 use Symfony\Component\Console\Output\ConsoleOutput;
-
 use League\Container\ContainerAwareInterface;
 use League\Container\ContainerAwareTrait;