consolidation / robo

src/Runner.php

Doc Comments +5 added lines, -2 removed lines

@@ -63,6 +63,9 @@ 
         $this->dir = getcwd();
     }
 
+    /**
+     * @param string $errorType
+     */
     protected function errorCondtion($msg, $errorType)
     {
         $this->errorConditions[$msg] = $errorType;
@@ -110,7 +113,7 @@ 
     }
 
     /**
-     * @param array $argv
+     * @param string[] $argv
      * @param null|string $appName
      * @param null|string $appVersion
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
@@ -133,7 +136,7 @@ 
      * @param null|\Symfony\Component\Console\Input\InputInterface $input
      * @param null|\Symfony\Component\Console\Output\OutputInterface $output
      * @param null|\Robo\Application $app
-     * @param array[] $commandFiles
+     * @param null|string $commandFiles
      * @param null|ClassLoader $classLoader
      *
      * @return int

src/ClassDiscovery/RelativeNamespaceDiscovery.php

Indentation +2 added lines, -2 removed lines

@@ -91,8 +91,8 @@
     {
         $finder = new Finder();
         $finder->files()
-          ->name($pattern)
-          ->in($directories);
+            ->name($pattern)
+            ->in($directories);
 
         return $finder;
     }

Doc Comments +5 added lines, -3 removed lines

@@ -62,6 +62,7 @@ 
 
     /**
      * {@inheritdoc}
+     * @param string $class
      */
     public function getFile($class)
     {
@@ -70,7 +71,7 @@ 
 
     /**
      * @param $directories
-     * @param $pattern
+     * @param string $pattern
      *
      * @return \Symfony\Component\Finder\Finder
      */
@@ -85,9 +86,9 @@ 
     }
 
     /**
-     * @param $path
+     * @param string $path
      *
-     * @return mixed
+     * @return string
      */
     protected function convertPathToNamespace($path)
     {
@@ -95,6 +96,7 @@ 
     }
 
     /**
+     * @param string $namespace
      * @return string
      */
     public function convertNamespaceToPath($namespace)

Spacing +5 added lines, -5 removed lines

@@ -41,18 +41,18 @@ 
         $relativePath = $this->convertNamespaceToPath($this->relativeNamespace);
 
         foreach ($this->getClassLoader()->getPrefixesPsr4() as $baseNamespace => $directories) {
-            $directories = array_map(function ($directory) use ($relativePath) {
-                return $directory.$relativePath;
+            $directories = array_map(function($directory) use ($relativePath) {
+                return $directory . $relativePath;
             }, $directories);
 
-            $directories = array_filter($directories, function ($path) {
+            $directories = array_filter($directories, function($path) {
                 return is_dir($path);
             });
 
             if ($directories) {
                 foreach ($this->search($directories, $this->searchPattern) as $file) {
                     $relativePathName = $file->getRelativePathname();
-                    $classes[] = $baseNamespace.$this->convertPathToNamespace($relativePath.DIRECTORY_SEPARATOR.$relativePathName);
+                    $classes[] = $baseNamespace . $this->convertPathToNamespace($relativePath . DIRECTORY_SEPARATOR . $relativePathName);
                 }
             }
         }
@@ -99,6 +99,6 @@ 
      */
     public function convertNamespaceToPath($namespace)
     {
-        return DIRECTORY_SEPARATOR.str_replace("\\", DIRECTORY_SEPARATOR, trim($namespace, '\\'));
+        return DIRECTORY_SEPARATOR . str_replace("\\", DIRECTORY_SEPARATOR, trim($namespace, '\\'));
     }
 }

tests/unit/ClassDiscovery/RelativeNamespaceDiscoveryTest.php

Indentation +7 added lines, -7 removed lines

@@ -38,10 +38,10 @@ 
     public function testConvertPathToNamespaceData()
     {
         return [
-          ['/A/B/C', 'A\B\C'],
-          ['A/B/C', 'A\B\C'],
-          ['A/B/C', 'A\B\C'],
-          ['A/B/C.php', 'A\B\C'],
+            ['/A/B/C', 'A\B\C'],
+            ['A/B/C', 'A\B\C'],
+            ['A/B/C', 'A\B\C'],
+            ['A/B/C.php', 'A\B\C'],
         ];
     }
 
@@ -61,9 +61,9 @@ 
     public function testConvertNamespaceToPathData()
     {
         return [
-          ['A\B\C', '/A/B/C'],
-          ['\A\B\C\\', '/A/B/C'],
-          ['A\B\C\\', '/A/B/C'],
+            ['A\B\C', '/A/B/C'],
+            ['\A\B\C\\', '/A/B/C'],
+            ['A\B\C\\', '/A/B/C'],
         ];
     }
 

Spacing +2 added lines, -2 removed lines

@@ -11,7 +11,7 @@ 
     public function testGetClasses()
     {
         $service = $this->getServiceInstance('\Commands');
-        $service->getClassLoader()->addPsr4('\\Robo\\', [realpath(__DIR__.'/../../src')]);
+        $service->getClassLoader()->addPsr4('\\Robo\\', [realpath(__DIR__ . '/../../src')]);
 
         $classes = $service->getClasses();
 
@@ -22,7 +22,7 @@ 
     public function testGetFile()
     {
         $service = $this->getServiceInstance('\Commands');
-        $service->getClassLoader()->addPsr4('\\Robo\\', [realpath(__DIR__.'/../../src')]);
+        $service->getClassLoader()->addPsr4('\\Robo\\', [realpath(__DIR__ . '/../../src')]);
 
         $actual = $service->getFile('\Robo\Commands\FirstCustomCommands');
         $this->assertStringEndsWith('tests/src/Commands/FirstCustomCommands.php', $actual);

Doc Comments +5 added lines, -1 removed lines

@@ -77,7 +77,7 @@ 
     }
 
     /**
-     * @param $relativeNamespace
+     * @param string $relativeNamespace
      *
      * @return \Robo\ClassDiscovery\RelativeNamespaceDiscovery
      */
@@ -88,6 +88,10 @@ 
             ->setClassLoader(new ClassLoader());
     }
 
+    /**
+     * @param RelativeNamespaceDiscovery $object
+     * @param string $method
+     */
     protected function callProtected($object, $method, $args = [])
     {
         $r = new \ReflectionMethod($object, $method);