Completed
Push — master ( 37fd48...ab1e9d )
by Greg
01:22
created
src/LogicalOpFactory.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      * @param Operator|false $lhs Left-hand-side operator
95 95
      * @param string $logicOp '&' or '|'
96 96
      * @param OperatorInterface $rhs Right-hand-side operator
97
-     * @return Operator
97
+     * @return OperatorInterface
98 98
      */
99 99
     protected function combineUsingLogicalOp($lhs, $logicOp, OperatorInterface $rhs)
100 100
     {
@@ -113,7 +113,7 @@  discard block
 block discarded – undo
113 113
      * string expression, create the right-hand-side operator and combine
114 114
      * it with the provided lhs operator.
115 115
      *
116
-     * @param Operator|false $lhs Left-hand-side operator
116
+     * @param OperatorInterface $lhs Left-hand-side operator
117 117
      * @param string $logicOp '&' or '|'
118 118
      * @param OperatorInterface $rhs Right-hand-side operator
119 119
      * @return Operator
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\Filter;
3 3
 
4
-use Dflydev\DotAccessData\Data;
5
-
6 4
 use Consolidation\Filter\Operators\LogicalAndOp;
7 5
 use Consolidation\Filter\Operators\LogicalOrOp;
8 6
 
Please login to merge, or discard this patch.
src/OperatorInterface.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
     /**
18 18
      * Test the provided value to see if it matches our criteria.
19 19
      *
20
-     * @param mixed $value
21 20
      * @return bool
22 21
      */
23 22
     public function test(Data $row);
Please login to merge, or discard this patch.
src/Operators/ContainsOp.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
     /**
22 22
      * Test the provided value to see if it matches our criteria.
23 23
      *
24
-     * @param mixed $value
25 24
      * @return bool
26 25
      */
27 26
     public function test(Data $row)
Please login to merge, or discard this patch.
src/Operators/LogicalAndOp.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,6 +12,10 @@  discard block
 block discarded – undo
12 12
     protected $lhs;
13 13
     protected $rhs;
14 14
 
15
+    /**
16
+     * @param OperatorInterface $lhs
17
+     * @param OperatorInterface $rhs
18
+     */
15 19
     public function __construct($lhs, $rhs)
16 20
     {
17 21
         $this->lhs = $lhs;
@@ -21,7 +25,6 @@  discard block
 block discarded – undo
21 25
     /**
22 26
      * Test the provided value to see if it matches our criteria.
23 27
      *
24
-     * @param mixed $value
25 28
      * @return bool
26 29
      */
27 30
     public function test(Data $row)
Please login to merge, or discard this patch.
src/Operators/RegexOp.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -21,8 +21,7 @@
 block discarded – undo
21 21
     /**
22 22
      * Test the provided value to see if it matches our criteria.
23 23
      *
24
-     * @param mixed $value
25
-     * @return bool
24
+     * @return integer
26 25
      */
27 26
     public function test(Data $row)
28 27
     {
Please login to merge, or discard this patch.
src/Operators/EqualsOp.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
     /**
22 22
      * Test the provided value to see if it matches our criteria.
23 23
      *
24
-     * @param mixed $value
25 24
      * @return bool
26 25
      */
27 26
     public function test(Data $row)
Please login to merge, or discard this patch.
src/Operators/LogicalOrOp.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,6 +12,10 @@  discard block
 block discarded – undo
12 12
     protected $lhs;
13 13
     protected $rhs;
14 14
 
15
+    /**
16
+     * @param OperatorInterface $lhs
17
+     * @param OperatorInterface $rhs
18
+     */
15 19
     public function __construct($lhs, $rhs)
16 20
     {
17 21
         $this->lhs = $lhs;
@@ -21,7 +25,6 @@  discard block
 block discarded – undo
21 25
     /**
22 26
      * Test the provided value to see if it matches our criteria.
23 27
      *
24
-     * @param mixed $value
25 28
      * @return bool
26 29
      */
27 30
     public function test(Data $row)
Please login to merge, or discard this patch.
src/Operators/NotOp.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,6 @@
 block discarded – undo
21 21
     /**
22 22
      * Test the provided value to see if it matches our criteria.
23 23
      *
24
-     * @param mixed $value
25 24
      * @return bool
26 25
      */
27 26
     public function test(Data $row)
Please login to merge, or discard this patch.