Completed
Pull Request — master (#130)
by Greg
04:26
created
src/Parser/Internal/BespokeDocBlockParser.php 3 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -146,6 +146,9 @@  discard block
 block discarded – undo
146 146
         $this->commandInfo->setReturnType($returnType);
147 147
     }
148 148
 
149
+    /**
150
+     * @param string $doc
151
+     */
149 152
     private function parseDocBlock($doc)
150 153
     {
151 154
         if (empty($doc)) {
@@ -198,6 +201,9 @@  discard block
 block discarded – undo
198 201
         $this->commandInfo->setHelp($help);
199 202
     }
200 203
 
204
+    /**
205
+     * @param DocblockTag[] $tags
206
+     */
201 207
     protected function processAllTags($tags)
202 208
     {
203 209
         // Iterate over all of the tags, and process them as necessary.
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\AnnotatedCommand\Parser\Internal;
3 3
 
4
-use Consolidation\AnnotatedCommand\Parser\CommandInfo;
5 4
 use Consolidation\AnnotatedCommand\Parser\DefaultsWithDescriptions;
6 5
 
7 6
 /**
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
     protected function processCommandTag($tag)
37 37
     {
38 38
         if (!$tag->hasWordAndDescription($matches)) {
39
-            throw new \Exception('Could not determine command name from tag ' . (string)$tag);
39
+            throw new \Exception('Could not determine command name from tag '.(string)$tag);
40 40
         }
41 41
         $commandName = $matches['word'];
42 42
         $this->commandInfo->setName($commandName);
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
     {
119 119
         $lines = explode("\n", $tag->getContent());
120 120
         $usage = trim(array_shift($lines));
121
-        $description = static::removeLineBreaks(implode("\n", array_map(function ($line) {
121
+        $description = static::removeLineBreaks(implode("\n", array_map(function($line) {
122 122
             return trim($line);
123 123
         }, $lines)));
124 124
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
     protected function processReturnTag($tag)
140 140
     {
141 141
         if (!$tag->hasWordAndDescription($matches)) {
142
-            throw new \Exception('Could not determine return type from tag ' . (string)$tag);
142
+            throw new \Exception('Could not determine return type from tag '.(string)$tag);
143 143
         }
144 144
         // TODO: look at namespace and `use` statments to make returnType a fqdn
145 145
         $returnType = $matches['word'];
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
         // Trim all of the lines individually.
180 180
         $lines =
181 181
             array_map(
182
-                function ($line) {
182
+                function($line) {
183 183
                     return trim($line);
184 184
                 },
185 185
                 $lines
@@ -188,7 +188,7 @@  discard block
 block discarded – undo
188 188
         // Everything up to the first blank line goes in the description.
189 189
         $description = array_shift($lines);
190 190
         while (!empty($lines) && !empty(trim($lines[0]))) {
191
-            $description .= ' ' . array_shift($lines);
191
+            $description .= ' '.array_shift($lines);
192 192
         }
193 193
 
194 194
         // Everything else goes in the help.
Please login to merge, or discard this patch.
src/Parser/Internal/DocblockTag.php 2 patches
Doc Comments   +5 added lines, -9 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     /**
30 30
      * Check if the provided string begins with a tag
31 31
      * @param string $subject
32
-     * @return bool
32
+     * @return integer
33 33
      */
34 34
     public static function isTag($subject)
35 35
     {
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
      *
42 42
      * @param string $subject
43 43
      * @param string[] &$matches Sets $matches['tag'] and $matches['description']
44
-     * @return bool
44
+     * @return integer
45 45
      */
46 46
     public static function splitTagAndContent($subject, &$matches)
47 47
     {
@@ -101,7 +101,6 @@  discard block
 block discarded – undo
101 101
      * - "@tag $variable description"
102 102
      * - "@tag type $variable description"
103 103
      *
104
-     * @param string $subject
105 104
      * @param string[] &$matches Sets $matches['variable'] and
106 105
      *   $matches['description']; might set $matches['type'].
107 106
      * @return bool
@@ -115,10 +114,9 @@  discard block
 block discarded – undo
115 114
 
116 115
     /**
117 116
      * Determine if tag is "@tag $variable description"
118
-     * @param string $subject
119 117
      * @param string[] &$matches Sets $matches['variable'] and
120 118
      *   $matches['description']
121
-     * @return bool
119
+     * @return integer
122 120
      */
123 121
     public function hasVariableAndDescription(&$matches)
124 122
     {
@@ -129,10 +127,9 @@  discard block
 block discarded – undo
129 127
     /**
130 128
      * Determine if tag is "@tag type $variable description"
131 129
      *
132
-     * @param string $subject
133 130
      * @param string[] &$matches Sets $matches['variable'],
134 131
      *   $matches['description'] and $matches['type'].
135
-     * @return bool
132
+     * @return integer
136 133
      */
137 134
     public function hasTypeVariableAndDescription(&$matches)
138 135
     {
@@ -142,10 +139,9 @@  discard block
 block discarded – undo
142 139
 
143 140
     /**
144 141
      * Determine if tag is "@tag word description"
145
-     * @param string $subject
146 142
      * @param string[] &$matches Sets $matches['word'] and
147 143
      *   $matches['description']
148
-     * @return bool
144
+     * @return integer
149 145
      */
150 146
     public function hasWordAndDescription(&$matches)
151 147
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
45 45
      */
46 46
     public static function splitTagAndContent($subject, &$matches)
47 47
     {
48
-        $regex = '/' . self::TAG_REGEX . self::DESCRIPTION_REGEX . '/';
48
+        $regex = '/'.self::TAG_REGEX.self::DESCRIPTION_REGEX.'/';
49 49
         return preg_match($regex, $subject, $matches);
50 50
     }
51 51
 
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
      */
93 93
     public function __toString()
94 94
     {
95
-        return '@' . $this->getTag() . ' ' . $this->getContent();
95
+        return '@'.$this->getTag().' '.$this->getContent();
96 96
     }
97 97
 
98 98
     /**
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      */
123 123
     public function hasVariableAndDescription(&$matches)
124 124
     {
125
-        $regex = '/' . self::VARIABLE_OR_WORD_REGEX . self::DESCRIPTION_REGEX . '/';
125
+        $regex = '/'.self::VARIABLE_OR_WORD_REGEX.self::DESCRIPTION_REGEX.'/';
126 126
         return preg_match($regex, $this->getContent(), $matches);
127 127
     }
128 128
 
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
      */
137 137
     public function hasTypeVariableAndDescription(&$matches)
138 138
     {
139
-        $regex = '/' . self::TYPE_REGEX . self::VARIABLE_REGEX . self::DESCRIPTION_REGEX . '/';
139
+        $regex = '/'.self::TYPE_REGEX.self::VARIABLE_REGEX.self::DESCRIPTION_REGEX.'/';
140 140
         return preg_match($regex, $this->getContent(), $matches);
141 141
     }
142 142
 
@@ -149,7 +149,7 @@  discard block
 block discarded – undo
149 149
      */
150 150
     public function hasWordAndDescription(&$matches)
151 151
     {
152
-        $regex = '/' . self::WORD_REGEX . self::DESCRIPTION_REGEX . '/';
152
+        $regex = '/'.self::WORD_REGEX.self::DESCRIPTION_REGEX.'/';
153 153
         return preg_match($regex, $this->getContent(), $matches);
154 154
     }
155 155
 }
Please login to merge, or discard this patch.
src/Parser/Internal/TagFactory.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -21,6 +21,9 @@
 block discarded – undo
21 21
         $this->tags = [];
22 22
     }
23 23
 
24
+    /**
25
+     * @param string $line
26
+     */
24 27
     public function parseLine($line)
25 28
     {
26 29
         if (DocblockTag::isTag($line)) {
Please login to merge, or discard this patch.