Completed
Push — master ( 1f26dc...76a15b )
by Greg
02:28
created
src/Parser/CommandInfo.php 2 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * @var boolean
21 21
      * @var string
22
-    */
22
+     */
23 23
     protected $docBlockIsParsed;
24 24
 
25 25
     /**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -254,8 +254,8 @@
 block discarded – undo
254 254
 
255 255
     protected function convertName($camel)
256 256
     {
257
-        $splitter="-";
258
-        $camel=preg_replace('/(?!^)[[:upper:]][[:lower:]]/', '$0', preg_replace('/(?!^)[[:upper:]]+/', $splitter.'$0', $camel));
257
+        $splitter = "-";
258
+        $camel = preg_replace('/(?!^)[[:upper:]][[:lower:]]/', '$0', preg_replace('/(?!^)[[:upper:]]+/', $splitter.'$0', $camel));
259 259
         $camel = preg_replace("/$splitter/", ':', $camel, 1);
260 260
         return strtolower($camel);
261 261
     }
Please login to merge, or discard this patch.
src/AnnotatedCommandFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         // set or setup.
76 76
         $commandMethodNames = array_filter(
77 77
             get_class_methods($classNameOrInstance) ?: [],
78
-            function ($m) {
78
+            function($m) {
79 79
                 return !preg_match('#^(_|get[A-Z]|set[A-Z])#', $m);
80 80
             }
81 81
         );
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         return $this->createSelectedCommandsFromClassInfo(
98 98
             $commandInfoList,
99 99
             $commandFileInstance,
100
-            function ($commandInfo) use ($includeAllPublicMethods) {
100
+            function($commandInfo) use ($includeAllPublicMethods) {
101 101
                 return $includeAllPublicMethods || static::isCommandMethod($commandInfo);
102 102
             }
103 103
         );
Please login to merge, or discard this patch.
src/Parser/Internal/CommandDocBlockParser2.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,8 +4,6 @@
 block discarded – undo
4 4
 use phpDocumentor\Reflection\DocBlock;
5 5
 use phpDocumentor\Reflection\DocBlock\Tag\ParamTag;
6 6
 use phpDocumentor\Reflection\DocBlock\Tag\ReturnTag;
7
-use Consolidation\AnnotatedCommand\Parser\CommandInfo;
8
-use Consolidation\AnnotatedCommand\Parser\DefaultsWithDescriptions;
9 7
 
10 8
 /**
11 9
  * Given a class and method name, parse the annotations in the
Please login to merge, or discard this patch.
src/CommandFileDiscovery.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
      */
248 248
     protected function getSearchDepth()
249 249
     {
250
-        return $this->searchDepth <= 0 ? '== 0' : '<= ' . $this->searchDepth;
250
+        return $this->searchDepth <= 0 ? '== 0' : '<= '.$this->searchDepth;
251 251
     }
252 252
 
253 253
     /**
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
         return $this->joinParts(
342 342
             '\\',
343 343
             $namespaceParts,
344
-            function ($item) {
344
+            function($item) {
345 345
                 return !is_numeric($item) && !empty($item);
346 346
             }
347 347
         );
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
         return $this->joinParts(
361 361
             '/',
362 362
             $pathParts,
363
-            function ($item) {
363
+            function($item) {
364 364
                 return !empty($item);
365 365
             }
366 366
         );
Please login to merge, or discard this patch.
src/CommandProcessor.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,11 +1,9 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\AnnotatedCommand;
3 3
 
4
-use Symfony\Component\Console\Command\Command;
5 4
 use Symfony\Component\Console\Input\InputInterface;
6 5
 use Symfony\Component\Console\Output\OutputInterface;
7 6
 use Symfony\Component\Console\Output\ConsoleOutputInterface;
8
-
9 7
 use Consolidation\OutputFormatters\FormatterManager;
10 8
 use Consolidation\OutputFormatters\FormatterOptions;
11 9
 use Consolidation\AnnotatedCommand\Hooks\HookManager;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,6 +120,9 @@  discard block
 block discarded – undo
120 120
         return $this->processResults($names, $result, $args, $annotationData);
121 121
     }
122 122
 
123
+    /**
124
+     * @param AnnotationData $annotationData
125
+     */
123 126
     public function processResults($names, $result, $args, $annotationData)
124 127
     {
125 128
         return $this->hookManager()->alterResult($names, $result, $args, $annotationData);
@@ -250,7 +253,7 @@  discard block
 block discarded – undo
250 253
      * @param int $status
251 254
      * @param string $structuredOutput
252 255
      * @param mixed $originalResult
253
-     * @return type
256
+     * @return integer
254 257
      */
255 258
     protected function writeErrorMessage($output, $status, $structuredOutput, $originalResult)
256 259
     {
Please login to merge, or discard this patch.
src/Hooks/HookManager.php 3 patches
Doc Comments   +26 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     /**
57 57
      * Add a hook
58 58
      *
59
-     * @param mixed $callback The callback function to call
59
+     * @param callable $callback The callback function to call
60 60
      * @param string   $hook     The name of the hook to add
61 61
      * @param string   $name     The name of the command to hook
62 62
      *   ('*' for all)
@@ -329,6 +329,9 @@  discard block
 block discarded – undo
329 329
         return $result;
330 330
     }
331 331
 
332
+    /**
333
+     * @param string[] $names
334
+     */
332 335
     protected function getCommandEventHooks($names)
333 336
     {
334 337
         return $this->getHooks($names, self::COMMAND_EVENT);
@@ -384,6 +387,7 @@  discard block
 block discarded – undo
384 387
      * @param string|array $names The name of the function being hooked.
385 388
      * @param string $hook The specific hook name (e.g. alter)
386 389
      * @param string[] $stages The stages to apply hooks at (e.g. pre, post)
390
+     * @param AnnotationData $annotationData
387 391
      *
388 392
      * @return callable[]
389 393
      */
@@ -434,6 +438,10 @@  discard block
 block discarded – undo
434 438
         return [];
435 439
     }
436 440
 
441
+    /**
442
+     * @param callable $provider
443
+     * @param InputInterface $input
444
+     */
437 445
     protected function callInjectConfigurationHook($provider, $input, AnnotationData $annotationData)
438 446
     {
439 447
         if ($provider instanceof InitializeHookInterface) {
@@ -444,6 +452,11 @@  discard block
 block discarded – undo
444 452
         }
445 453
     }
446 454
 
455
+    /**
456
+     * @param callable $interactor
457
+     * @param InputInterface $input
458
+     * @param OutputInterface $output
459
+     */
447 460
     protected function callInteractor($interactor, $input, $output, AnnotationData $annotationData)
448 461
     {
449 462
         if ($interactor instanceof InteractorInterface) {
@@ -454,6 +467,9 @@  discard block
 block discarded – undo
454 467
         }
455 468
     }
456 469
 
470
+    /**
471
+     * @param callable $validator
472
+     */
457 473
     protected function callValidator($validator, $args, AnnotationData $annotationData)
458 474
     {
459 475
         // TODO: Adding AnnotationData to ValidatorInterface would be
@@ -467,6 +483,9 @@  discard block
 block discarded – undo
467 483
         }
468 484
     }
469 485
 
486
+    /**
487
+     * @param callable $processor
488
+     */
470 489
     protected function callProcessor($processor, $result, $args, AnnotationData $annotationData)
471 490
     {
472 491
         $processed = null;
@@ -485,6 +504,9 @@  discard block
 block discarded – undo
485 504
         return $result;
486 505
     }
487 506
 
507
+    /**
508
+     * @param callable $determiner
509
+     */
488 510
     protected function callDeterminer($determiner, $result)
489 511
     {
490 512
         if ($determiner instanceof StatusDeterminerInterface) {
@@ -495,6 +517,9 @@  discard block
 block discarded – undo
495 517
         }
496 518
     }
497 519
 
520
+    /**
521
+     * @param callable $extractor
522
+     */
498 523
     protected function callExtractor($extractor, $result)
499 524
     {
500 525
         if ($extractor instanceof ExtractOutputInterface) {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,11 +4,9 @@
 block discarded – undo
4 4
 use Symfony\Component\Console\Command\Command;
5 5
 use Symfony\Component\Console\Input\InputInterface;
6 6
 use Symfony\Component\Console\Output\OutputInterface;
7
-
8 7
 use Symfony\Component\Console\ConsoleEvents;
9 8
 use Symfony\Component\Console\Event\ConsoleCommandEvent;
10 9
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
11
-
12 10
 use Consolidation\AnnotatedCommand\ExitCodeInterface;
13 11
 use Consolidation\AnnotatedCommand\OutputDataInterface;
14 12
 use Consolidation\AnnotatedCommand\AnnotationData;
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -391,7 +391,7 @@  discard block
 block discarded – undo
391 391
     {
392 392
         $names = array_merge(
393 393
             (array)$names,
394
-            ($annotationData == null) ? [] : array_map(function ($item) {
394
+            ($annotationData == null) ? [] : array_map(function($item) {
395 395
                 return "@$item";
396 396
             }, $annotationData->keys())
397 397
         );
@@ -412,7 +412,7 @@  discard block
 block discarded – undo
412 412
         $hooks = [];
413 413
         foreach ($stages as $stage) {
414 414
             foreach ((array)$names as $name) {
415
-                $hooks = array_merge($hooks, $this->getHook($name, $stage . $hook));
415
+                $hooks = array_merge($hooks, $this->getHook($name, $stage.$hook));
416 416
             }
417 417
         }
418 418
         return $hooks;
Please login to merge, or discard this patch.