Completed
Pull Request — master (#34)
by Greg
02:55
created
src/Parser/CommandInfo.php 4 patches
Indentation   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -19,7 +19,7 @@
 block discarded – undo
19 19
     /**
20 20
      * @var boolean
21 21
      * @var string
22
-    */
22
+     */
23 23
     protected $docBlockIsParsed;
24 24
 
25 25
     /**
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -254,8 +254,8 @@
 block discarded – undo
254 254
 
255 255
     protected function convertName($camel)
256 256
     {
257
-        $splitter="-";
258
-        $camel=preg_replace('/(?!^)[[:upper:]][[:lower:]]/', '$0', preg_replace('/(?!^)[[:upper:]]+/', $splitter.'$0', $camel));
257
+        $splitter = "-";
258
+        $camel = preg_replace('/(?!^)[[:upper:]][[:lower:]]/', '$0', preg_replace('/(?!^)[[:upper:]]+/', $splitter.'$0', $camel));
259 259
         $camel = preg_replace("/$splitter/", ':', $camel, 1);
260 260
         return strtolower($camel);
261 261
     }
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
     /**
246 246
      * Set aliases that can be used in place of the command's primary name.
247 247
      *
248
-     * @param string|string[] $aliases
248
+     * @param string $aliases
249 249
      */
250 250
     public function setAliases($aliases)
251 251
     {
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
     /**
284 284
      * Return the list of refleaction parameters.
285 285
      *
286
-     * @return ReflectionParameter[]
286
+     * @return \ReflectionParameter[]
287 287
      */
288 288
     public function getParameters()
289 289
     {
@@ -381,7 +381,7 @@  discard block
 block discarded – undo
381 381
      * Examine the parameters of the method for this command, and
382 382
      * build a list of commandline arguements for them.
383 383
      *
384
-     * @return array
384
+     * @return DefaultsWithDescriptions
385 385
      */
386 386
     protected function determineAgumentClassifications()
387 387
     {
@@ -401,6 +401,7 @@  discard block
 block discarded – undo
401 401
      * Examine the provided parameter, and determine whether it
402 402
      * is a parameter that will be filled in with a positional
403 403
      * commandline argument.
404
+     * @param DefaultsWithDescriptions $result
404 405
      */
405 406
     protected function addParameterToResult($result, $param)
406 407
     {
@@ -501,6 +502,8 @@  discard block
 block discarded – undo
501 502
     /**
502 503
      * Given a list that might be 'a b c' or 'a, b, c' or 'a,b,c',
503 504
      * convert the data into the last of these forms.
505
+     * @param string $text
506
+     * @return string
504 507
      */
505 508
     protected static function convertListToCommaSeparated($text)
506 509
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -1,7 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\AnnotatedCommand\Parser;
3 3
 
4
-use Consolidation\AnnotatedCommand\Parser\Internal\CommandDocBlockParser;
5 4
 use Consolidation\AnnotatedCommand\Parser\Internal\CommandDocBlockParserFactory;
6 5
 use Consolidation\AnnotatedCommand\AnnotationData;
7 6
 
Please login to merge, or discard this patch.
src/CommandProcessor.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -1,11 +1,8 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Consolidation\AnnotatedCommand;
3 3
 
4
-use Symfony\Component\Console\Command\Command;
5
-use Symfony\Component\Console\Input\InputInterface;
6 4
 use Symfony\Component\Console\Output\OutputInterface;
7 5
 use Symfony\Component\Console\Output\ConsoleOutputInterface;
8
-
9 6
 use Consolidation\OutputFormatters\FormatterManager;
10 7
 use Consolidation\OutputFormatters\FormatterOptions;
11 8
 use Consolidation\AnnotatedCommand\Hooks\HookManager;
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@  discard block
 block discarded – undo
96 96
         return $this->processResults($names, $result, $args, $annotationData);
97 97
     }
98 98
 
99
+    /**
100
+     * @param AnnotationData $annotationData
101
+     */
99 102
     public function processResults($names, $result, $args, $annotationData)
100 103
     {
101 104
         return $this->hookManager()->alterResult($names, $result, $args, $annotationData);
@@ -152,7 +155,7 @@  discard block
 block discarded – undo
152 155
      * should select the output format that is most appropriate
153 156
      * for use in scripts (e.g. to pipe to another command).
154 157
      *
155
-     * @return string
158
+     * @return boolean
156 159
      */
157 160
     protected function getFormat($options)
158 161
     {
Please login to merge, or discard this patch.
src/AnnotatedCommandFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
         // set or setup.
76 76
         $commandMethodNames = array_filter(
77 77
             get_class_methods($classNameOrInstance) ?: [],
78
-            function ($m) {
78
+            function($m) {
79 79
                 return !preg_match('#^(_|get[A-Z]|set[A-Z])#', $m);
80 80
             }
81 81
         );
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
         return $this->createSelectedCommandsFromClassInfo(
98 98
             $commandInfoList,
99 99
             $commandFileInstance,
100
-            function ($commandInfo) use ($includeAllPublicMethods) {
100
+            function($commandInfo) use ($includeAllPublicMethods) {
101 101
                 return $includeAllPublicMethods || static::isCommandMethod($commandInfo);
102 102
             }
103 103
         );
Please login to merge, or discard this patch.
src/Parser/Internal/CommandDocBlockParser2.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,8 +4,6 @@
 block discarded – undo
4 4
 use phpDocumentor\Reflection\DocBlock;
5 5
 use phpDocumentor\Reflection\DocBlock\Tag\ParamTag;
6 6
 use phpDocumentor\Reflection\DocBlock\Tag\ReturnTag;
7
-use Consolidation\AnnotatedCommand\Parser\CommandInfo;
8
-use Consolidation\AnnotatedCommand\Parser\DefaultsWithDescriptions;
9 7
 
10 8
 /**
11 9
  * Given a class and method name, parse the annotations in the
Please login to merge, or discard this patch.
src/CommandFileDiscovery.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
      */
248 248
     protected function getSearchDepth()
249 249
     {
250
-        return $this->searchDepth <= 0 ? '== 0' : '<= ' . $this->searchDepth;
250
+        return $this->searchDepth <= 0 ? '== 0' : '<= '.$this->searchDepth;
251 251
     }
252 252
 
253 253
     /**
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
         return $this->joinParts(
342 342
             '\\',
343 343
             $namespaceParts,
344
-            function ($item) {
344
+            function($item) {
345 345
                 return !is_numeric($item) && !empty($item);
346 346
             }
347 347
         );
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
         return $this->joinParts(
361 361
             '/',
362 362
             $pathParts,
363
-            function ($item) {
363
+            function($item) {
364 364
                 return !empty($item);
365 365
             }
366 366
         );
Please login to merge, or discard this patch.
src/Hooks/HookManager.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -255,7 +255,7 @@
 block discarded – undo
255 255
     {
256 256
         $names = array_merge(
257 257
             (array)$names,
258
-            ($annotationData == null) ? [] : array_map(function ($item) { return "@$item"; }, $annotationData->array_keys())
258
+            ($annotationData == null) ? [] : array_map(function($item) { return "@$item"; }, $annotationData->array_keys())
259 259
         );
260 260
         $names[] = '*';
261 261
         return array_merge(
Please login to merge, or discard this patch.