ByDate::filter() - Code Metrics - Inspection of "Discount availability by date" - conferencetools/tickets-module - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#82)

by Chris

created 2017-12-11 09:21 UTC

ByDate::filter() A

↳ Parent: ByDate

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	6
nc	1
nop	1
dl	11
loc	11
ccs	7
cts	7
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php
/**
 * Created by PhpStorm.
 * User: imhotek
 * Date: 15/11/17
 * Time: 16:57
 */

namespace ConferenceTools\Tickets\Domain\Service\Availability\Filters;


use ConferenceTools\Tickets\Domain\ReadModel\TicketCounts\TicketCounter;
use ConferenceTools\Tickets\Domain\Service\Configuration;
use Doctrine\Common\Collections\Collection;

class ByDate implements FilterInterface

{
    /**
     * @var Configuration
     */
    private $configuration;

    public function __construct(Configuration $configuration)
    {
        $this->configuration = $configuration;
    }

    public function filter(Collection $tickets): Collection
    {
        $configuration = $this->configuration;
        $today = new \DateTime();

        $p = function (TicketCounter $ticket) use ($configuration, $today) {
            $metadata = $configuration->getTicketMetadata($ticket->getTicketType()->getIdentifier());
            return $metadata->isAvailableOn($today);
        };

        return $tickets->filter($p);
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: imhotek
5			* Date: 15/11/17
6			* Time: 16:57
7			*/
8
9			namespace ConferenceTools\Tickets\Domain\Service\Availability\Filters;
10
11
12			use ConferenceTools\Tickets\Domain\ReadModel\TicketCounts\TicketCounter;
13			use ConferenceTools\Tickets\Domain\Service\Configuration;
14			use Doctrine\Common\Collections\Collection;
15
16		View Code Duplication	class ByDate implements FilterInterface
			0 ignored issues – show Duplication introduced 2017-11-22 08:28 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
17			{
18			/**
19			* @var Configuration
20			*/
21			private $configuration;
22
23			public function __construct(Configuration $configuration)
24			{
25			$this->configuration = $configuration;
26			}
27
28	4		public function filter(Collection $tickets): Collection
29			{
30	4		$configuration = $this->configuration;
31	4		$today = new \DateTime();
32
33	4		$p = function (TicketCounter $ticket) use ($configuration, $today) {
34	4		$metadata = $configuration->getTicketMetadata($ticket->getTicketType()->getIdentifier());
35	4		return $metadata->isAvailableOn($today);
36	4		};
37
38			return $tickets->filter($p);
39			}
40			}

conferencetools / tickets-module

Pull Request — master (#82)

ByDate::filter() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like