Passed
Pull Request — master (#82)
by Chris
06:20 queued 02:55
created

ByDate   A

Complexity

Total Complexity 2

Size/Duplication

Total Lines 23
Duplicated Lines 100 %

Test Coverage

Coverage 70%

Importance

Changes 0
Metric Value
dl 23
loc 23
ccs 7
cts 10
cp 0.7
rs 10
c 0
b 0
f 0
wmc 2

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 3 3 1
A filter() 11 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
/**
3
 * Created by PhpStorm.
4
 * User: imhotek
5
 * Date: 15/11/17
6
 * Time: 16:57
7
 */
8
9
namespace ConferenceTools\Tickets\Domain\Service\Availability\Filters;
10
11
12
use ConferenceTools\Tickets\Domain\ReadModel\TicketCounts\TicketCounter;
13
use ConferenceTools\Tickets\Domain\Service\Configuration;
14
use Doctrine\Common\Collections\Collection;
15
16 View Code Duplication
class ByDate implements FilterInterface
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
17
{
18
    /**
19
     * @var Configuration
20
     */
21
    private $configuration;
22
23
    public function __construct(Configuration $configuration)
24
    {
25
        $this->configuration = $configuration;
26
    }
27
28 4
    public function filter(Collection $tickets): Collection
29
    {
30 4
        $configuration = $this->configuration;
31 4
        $today = new \DateTime();
32
33 4
        $p = function (TicketCounter $ticket) use ($configuration, $today) {
34 4
            $metadata = $configuration->getTicketMetadata($ticket->getTicketType()->getIdentifier());
35 4
            return $metadata->isAvailableOn($today);
36 4
        };
37
38
        return $tickets->filter($p);
39
    }
40
}