Silverback\ApiComponentBundle\Serializer\RequestFormatResolver

Complexity

Total Complexity

4

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getFormat()	0	8	2
A	getFormatFromRequest()	0	3	1

<?php

/*
 * This file is part of the Silverback API Component Bundle Project
 *
 * (c) Daniel West <daniel@silverback.is>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Silverback\ApiComponentBundle\Serializer;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * @author Daniel West <daniel@silverback.is>
 */
final class RequestFormatResolver
{
    private RequestStack $requestStack;
    private string $defaultFormat;

    public function __construct(RequestStack $requestStack, string $defaultFormat = 'jsonld')
    {
        $this->requestStack = $requestStack;
        $this->defaultFormat = $defaultFormat;
    }

    public function getFormat(): string
    {
        $request = $this->requestStack->getMasterRequest();
        if (!$request) {
            return $this->defaultFormat;
        }

        return $this->getFormatFromRequest($request);
    }

    public function getFormatFromRequest(Request $request): string
    {
        return $request->getRequestFormat($this->defaultFormat);

The expression return $request->getRequestFormat($this->defaultFormat) could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

        // return $request->attributes->get('_format') ?: $request->getFormat($request->headers->get('CONTENT_TYPE')) ?: $this->defaultFormat;
    }
}