RequestFormatResolver::getFormatFromRequest() - Code Metrics - Inspection of "Handle request formats other than json in custom a..." - components-web-app/api-components-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — v2 ( 9b853e...868892 )

by Daniel

created 2020-04-02 11:41 UTC

RequestFormatResolver::getFormatFromRequest() A

↳ Parent: RequestFormatResolver

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	2
cp	0
crap	2
rs	10
c	1
b	0
f	0

<?php

/*
 * This file is part of the Silverback API Component Bundle Project
 *
 * (c) Daniel West <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Silverback\ApiComponentBundle\Serializer;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;

/**
 * @author Daniel West <[email protected]>
 */
final class RequestFormatResolver
{
    private RequestStack $requestStack;
    private string $defaultFormat;

    public function __construct(RequestStack $requestStack, string $defaultFormat = 'jsonld')
    {
        $this->requestStack = $requestStack;
        $this->defaultFormat = $defaultFormat;
    }

    public function getFormat(): string
    {
        $request = $this->requestStack->getMasterRequest();
        if (!$request) {
            return $this->defaultFormat;
        }

        return $this->getFormatFromRequest($request);
    }

    public function getFormatFromRequest(Request $request): string
    {
        return $request->getRequestFormat($this->defaultFormat);

        // return $request->attributes->get('_format') ?: $request->getFormat($request->headers->get('CONTENT_TYPE')) ?: $this->defaultFormat;
    }
}


1			<?php
2
3			/*
4			* This file is part of the Silverback API Component Bundle Project
5			*
6			* (c) Daniel West <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Silverback\ApiComponentBundle\Serializer;
15
16			use Symfony\Component\HttpFoundation\Request;
17			use Symfony\Component\HttpFoundation\RequestStack;
18
19			/**
20			* @author Daniel West <[email protected]>
21			*/
22			final class RequestFormatResolver
23			{
24			private RequestStack $requestStack;
25			private string $defaultFormat;
26
27			public function __construct(RequestStack $requestStack, string $defaultFormat = 'jsonld')
28			{
29			$this->requestStack = $requestStack;
30			$this->defaultFormat = $defaultFormat;
31			}
32
33			public function getFormat(): string
34			{
35			$request = $this->requestStack->getMasterRequest();
36			if (!$request) {
37			return $this->defaultFormat;
38			}
39
40			return $this->getFormatFromRequest($request);
41			}
42
43			public function getFormatFromRequest(Request $request): string
44			{
45			return $request->getRequestFormat($this->defaultFormat);
			1 ignored issue – show Bug Best Practice introduced 2020-04-02 11:46 UTC by Report Bug Copy Issue Report The expression `return $request->getRequ...t($this->defaultFormat)` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
46			// return $request->attributes->get('_format') ?: $request->getFormat($request->headers->get('CONTENT_TYPE')) ?: $this->defaultFormat;
47			}
48			}
49

components-web-app / api-components-bundle

Push — v2 ( 9b853e...868892 )

RequestFormatResolver::getFormatFromRequest() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like